From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:48766 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389168AbhARJom (ORCPT ); Mon, 18 Jan 2021 04:44:42 -0500 Subject: Re: [kvm-unit-tests PATCH v4 0/9] s390x: Add SIE library and simple tests From: Janosch Frank References: <20210112132054.49756-1-frankja@linux.ibm.com> Message-ID: <45420c5f-cf5f-a3bc-d555-6093d88a0c59@linux.ibm.com> Date: Mon, 18 Jan 2021 10:43:52 +0100 MIME-Version: 1.0 In-Reply-To: <20210112132054.49756-1-frankja@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-ID: To: kvm@vger.kernel.org Cc: thuth@redhat.com, david@redhat.com, borntraeger@de.ibm.com, imbrenda@linux.ibm.com, cohuck@redhat.com, linux-s390@vger.kernel.org On 1/12/21 2:20 PM, Janosch Frank wrote: > This is the absolute minimum needed to run VMs inside the KVM Unit > Tests. It's more of a base for other tests that I can't (yet) publish > than an addition of tests that check KVM functionality. However, I > wanted to decrease the number of WIP patches in my private > branch. Once the library is available maybe others will come and > extend the SIE test itself. > > Yes, I have added VM management functionality like VM create/destroy, > etc but as it is not needed right now, I'd like to exclude it from > this patch set for now. I've picked patches 1-8. Patch 9 is dropped for now, it's only a comment anyway. Thanks for all of your review comments! > > v4: > * Removed asm directory and moved all asm files into s390x/ (I changed my view) > * Review fixes > * Removed a stray newline in the asm offsets file > > v3: > * Rebased on re-license patches > * Split assembly > * Now using ICPT_* constants > * Added read_info asserts > * Fixed missing spin_lock() in smp.c lib > * Replaced duplicated code in sie test with generic intercept test > * Replaced uv-guest.x bit testing with test_bit_inv() > * Some other minor cleanups > > Gitlab: > https://gitlab.com/frankja/kvm-unit-tests/-/tree/sie > > CI: > https://gitlab.com/frankja/kvm-unit-tests/-/pipelines/240506525 > > > Janosch Frank (9): > s390x: Add test_bit to library > s390x: Consolidate sclp read info > s390x: SCLP feature checking > s390x: Split assembly into multiple files > s390x: sie: Add SIE to lib > s390x: sie: Add first SIE test > s390x: Add diag318 intercept test > s390x: Fix sclp.h style issues > s390x: sclp: Add CPU entry offset comment > > lib/s390x/asm-offsets.c | 11 +++ > lib/s390x/asm/arch_def.h | 9 ++ > lib/s390x/asm/bitops.h | 26 ++++++ > lib/s390x/asm/facility.h | 3 +- > lib/s390x/interrupt.c | 7 ++ > lib/s390x/io.c | 2 + > lib/s390x/sclp.c | 57 +++++++++-- > lib/s390x/sclp.h | 181 +++++++++++++++++++---------------- > lib/s390x/sie.h | 197 +++++++++++++++++++++++++++++++++++++++ > lib/s390x/smp.c | 27 +++--- > s390x/Makefile | 7 +- > s390x/cstart64.S | 119 +---------------------- > s390x/intercept.c | 19 ++++ > s390x/lib.S | 121 ++++++++++++++++++++++++ > s390x/macros.S | 77 +++++++++++++++ > s390x/sie.c | 113 ++++++++++++++++++++++ > s390x/unittests.cfg | 3 + > s390x/uv-guest.c | 6 +- > 18 files changed, 761 insertions(+), 224 deletions(-) > create mode 100644 lib/s390x/sie.h > create mode 100644 s390x/lib.S > create mode 100644 s390x/macros.S > create mode 100644 s390x/sie.c >