From: David Collins <collinsd@codeaurora.org>
To: Douglas Anderson <dianders@chromium.org>, broonie@kernel.org
Cc: mka@chromium.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH] regulator: core: Allow for regulators that can't be read at bootup
Date: Wed, 16 May 2018 15:47:22 -0700 [thread overview]
Message-ID: <4547e1cb-a39c-decd-9384-4e2c6d28f64d@codeaurora.org> (raw)
In-Reply-To: <20180515220717.254950-1-dianders@chromium.org>
On 05/15/2018 03:07 PM, Douglas Anderson wrote:
> As discussed in the patches to try to support the RPMh regulators [1],
> the fact that regulators are write-only means that its driver's
> get_voltage_sel() should return an error code if it's called before
> any calls to set_voltage_sel(). This causes problems in
> machine_constraints_voltage() when trying to apply the constraints.
This problem specifically arises in the latest RPMh regulator patch [1] if
regulator-min-microvolt and regulator-max-microvolt are specified for a
VRM managed RPMh regulator device but the qcom,regulator-initial-microvolt
property is not provided. Therefore, listing
qcom,regulator-initial-microvolt is a way to avoid regulator registration
issues.
> In this patch I propose the error code -ENOTRECOVERABLE. In errno.h
> this error is described as "State not recoverable".
I'm fine with this constant. Hopefully Mark is as well.
> If this patch is accepted then we'll need to update the latest RPMh
> regulator patch to return it. The current patch returns -EINVAL which
> means that the regulator always fails.
I'll make this modification if needed.
Take care,
David
[1] https://lkml.org/lkml/2018/5/11/703
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-05-16 22:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-15 22:07 [PATCH] regulator: core: Allow for regulators that can't be read at bootup Douglas Anderson
2018-05-16 22:47 ` David Collins [this message]
2018-05-17 16:41 ` Applied "regulator: core: Allow for regulators that can't be read at bootup" to the regulator tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4547e1cb-a39c-decd-9384-4e2c6d28f64d@codeaurora.org \
--to=collinsd@codeaurora.org \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.