From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: update bbdev library documentation
Date: Mon, 23 Apr 2018 13:12:10 +0200
Message-ID: <4551437.8ZCrZuEaxO@xps>
References: <20180404140602.9344-1-kamilx.chalupnik@intel.com>
 <2713250.YhKZBbbERd@xps>
 <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: "Mokhtar, Amr" <amr.mokhtar@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3FA19DED
 for <dev@dpdk.org>; Mon, 23 Apr 2018 13:12:13 +0200 (CEST)
In-Reply-To: <3D3765A8CDB52A4C8B410430AA19CB236ECAFFC8@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

23/04/2018 12:56, Mokhtar, Amr:
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 04/04/2018 16:05, KamilX Chalupnik:
> > > From: "Chalupnik, KamilX" <kamilx.chalupnik@intel.com>
> > 
> > >  doc/guides/prog_guide/bbdev.rst               | 247
> > +++++++++++++++++++++++---
> > >  doc/guides/prog_guide/img/turbo_tb_decode.png | Bin 0 -> 43552
> > bytes
> > >  doc/guides/prog_guide/img/turbo_tb_encode.png | Bin 0 -> 46944
> > bytes
> > >  3 files changed, 222 insertions(+), 25 deletions(-)
> > >  create mode 100644 doc/guides/prog_guide/img/turbo_tb_decode.png
> > >  create mode 100644 doc/guides/prog_guide/img/turbo_tb_encode.png
> > 
> > No, sorry, you cannot add binary file in this repository.
> > It is an Open Source project, we provide sources.
> > For figures, the SVG format is preferred.
> > 
> > I'm sorry that your Intel colleagues did not warn you.
> > 
> 
> I wasn't aware there is specific preference for figures, this can be fixed.
> There is no specific reason for choosing .png except that there are files already
> in prog_guide/img/* of type .png. So it was assumed that its ok.
> And BTW, did I miss it somewhere in DPDK documentation what particular image
> types should be submitted.

Yes, it is in this doc:
	http://dpdk.org/doc/guides/contributing/documentation.html#images

> Will get this fixed. Thanks.

Thanks