From: "Pali Rohár" <pali.rohar@gmail.com>
To: linux-kernel@vger.kernel.org, Anton Vorontsov <cbou@mail.ru>,
syed rafiuddin <rafiuddin.sayed@gmail.com>,
Rodolfo Giometti <giometti@linux.it>,
Lars-Peter Clausen <lars@metafoo.de>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 9/9] bq27x00: Fix OOPS caused by unregistring bq27x00 driver
Date: Sun, 13 Nov 2011 21:54:16 +0100 [thread overview]
Message-ID: <45584927.uAIXTvEKdg@pali-elitebook> (raw)
In-Reply-To: <1320108191-6647-9-git-send-email-pali.rohar@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1345 bytes --]
On Tuesday 01 November 2011 01:43:11 you wrote:
> * power_supply_unregister call bq27x00_battery_get_property which call
> bq27x00_battery_poll * make sure that bq27x00_battery_poll will not call
> schedule_delayed_work again after unregister (which cause OOPS)
>
> Signed-off-by: Pali Rohár <pali.rohar@gmail.com>
> ---
> drivers/power/bq27x00_battery.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/power/bq27x00_battery.c
> b/drivers/power/bq27x00_battery.c index 15ecd42..29ce907 100644
> --- a/drivers/power/bq27x00_battery.c
> +++ b/drivers/power/bq27x00_battery.c
> @@ -722,6 +722,10 @@ static int bq27x00_powersupply_init(struct
> bq27x00_device_info *di)
>
> static void bq27x00_powersupply_unregister(struct bq27x00_device_info *di)
> {
> + /* power_supply_unregister call bq27x00_battery_get_property which call
> bq27x00_battery_poll */ + /* make sure that bq27x00_battery_poll will not
> call schedule_delayed_work again after unregister (which cause OOPS) */
> + poll_interval = 0;
> +
> cancel_delayed_work_sync(&di->work);
>
> bq27x00_battery_reg_exit(di);
Can somebody review this patch series? At least this last patch fix rebooting
device Nokia N900 after unloading bq27x00_battery module with rmmod!
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2011-11-13 20:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-20 15:18 [PATCH 1/7] bq27x00: Do not cache current_now value for bq27000 batery Pali Rohár
2011-09-20 15:18 ` [PATCH 2/7] bq27x00: Add support for property POWER_SUPPLY_PROP_CAPACITY_LEVEL Pali Rohár
2011-09-20 15:18 ` [PATCH 3/7] bq27x00: Report -ENODATA if bq27000 battery was not calibrated Pali Rohár
2011-09-20 15:18 ` [PATCH 4/7] bq27x00: Cache energy property Pali Rohár
2011-09-20 15:18 ` [PATCH 5/7] bq27x00: Cache temperature value in converted unit Pali Rohár
2011-09-20 15:18 ` [PATCH 6/7] bq27x00: Fix reporting status value for bq27500 battery Pali Rohár
2011-09-20 15:18 ` [PATCH 7/7] bq27x00: Fix reporting error messages Pali Rohár
2011-11-01 0:43 ` [PATCH 1/9] bq27x00: Do not cache current_now value for bq27000 batery Pali Rohár
2011-11-01 0:43 ` [PATCH 2/9] bq27x00: Add support for property POWER_SUPPLY_PROP_CAPACITY_LEVEL Pali Rohár
2011-11-01 0:43 ` [PATCH 3/9] bq27x00: Report -ENODATA if bq27000 battery was not calibrated Pali Rohár
2011-11-01 0:43 ` [PATCH 4/9] bq27x00: Cache energy property Pali Rohár
2011-11-01 0:43 ` [PATCH 5/9] bq27x00: Cache temperature value in converted unit Pali Rohár
2011-11-01 0:43 ` [PATCH 6/9] bq27x00: Fix reporting status value for bq27500 battery Pali Rohár
2011-11-01 0:43 ` [PATCH 7/9] bq27x00: Fix reporting error messages Pali Rohár
2011-11-01 0:43 ` [PATCH 8/9] bq27x00: Add miscdevice for each battery with ioctl for reading registers Pali Rohár
2011-11-01 12:09 ` Lars-Peter Clausen
2011-11-01 12:23 ` Pali Rohár
2011-11-01 12:46 ` Lars-Peter Clausen
2011-11-01 12:53 ` Pali Rohár
2011-11-25 20:10 ` Anton Vorontsov
2011-11-25 20:30 ` Pali Rohár
2011-11-25 20:46 ` Anton Vorontsov
2011-11-25 20:54 ` Pali Rohár
2011-11-25 22:04 ` Anton Vorontsov
2011-11-25 22:48 ` Pali Rohár
2011-11-27 11:54 ` Mark Brown
2011-12-05 19:37 ` Pali Rohár
2011-12-05 19:40 ` Mark Brown
2011-11-01 0:43 ` [PATCH 9/9] bq27x00: Fix OOPS caused by unregistring bq27x00 driver Pali Rohár
2011-11-13 20:54 ` Pali Rohár [this message]
2011-11-25 22:53 ` [PATCH] rx51: add bq27200 i2c board info Pali Rohár
2011-11-25 23:03 ` Anton Vorontsov
2011-12-05 19:24 ` Felipe Contreras
2011-12-06 15:49 ` Pali Rohár
2011-12-07 20:25 ` Tony Lindgren
2011-12-17 9:55 ` Pali Rohár
2012-01-06 1:41 ` Anton Vorontsov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45584927.uAIXTvEKdg@pali-elitebook \
--to=pali.rohar@gmail.com \
--cc=cbou@mail.ru \
--cc=dwmw2@infradead.org \
--cc=giometti@linux.it \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rafiuddin.sayed@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.