From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v8 0/7] add encap and decap actions to Direct
 Verbs flow in MLX5 PMD
Date: Thu, 1 Nov 2018 17:17:46 +0000
Message-ID: <4559ad20-47f7-20df-ef68-1cbdf128436e@intel.com>
References: <1540969847-48919-1-git-send-email-dekelp@mellanox.com>
 <1541065053-28436-1-git-send-email-dekelp@mellanox.com>
 <DB7PR05MB4426EEC19C5FEC3F55C21037C3CE0@DB7PR05MB4426.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@mellanox.com>
To: Shahaf Shuler <shahafs@mellanox.com>, Dekel Peled <dekelp@mellanox.com>,
 Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id E850B1B0FC
 for <dev@dpdk.org>; Thu,  1 Nov 2018 18:17:49 +0100 (CET)
In-Reply-To: <DB7PR05MB4426EEC19C5FEC3F55C21037C3CE0@DB7PR05MB4426.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/1/2018 12:51 PM, Shahaf Shuler wrote:
> Thursday, November 1, 2018 11:37 AM, Dekel Peled:
>> Subject: [dpdk-dev] [PATCH v8 0/7] add encap and decap actions to Direct
>> Verbs flow in MLX5 PMD
>>
>> This series adds support of encap and decap actions in DV format.
>> L2 tunnel support for VXLAN and NVGRE, and L2/L3 tunnel support using raw
>> data buffer.
>> It is using the generic encapsulation framework from [1].
>>
>> [1] "ethdev: add generic L2/L3 tunnel encapsulation actions"
>>
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fmail
>> s.dpdk.org%2Farchives%2Fdev%2F2018-
>> October%2F114654.html&amp;data=02%7C01%7Cshahafs%40mellanox.com
>> %7Cfcb2ee95be4d41ce3c6508d63fddcf5d%7Ca652971c7d2e4d9ba6a4d149256
>> f461b%7C0%7C0%7C636766619229826892&amp;sdata=Lgp9Dl3jVsrSAbvrWIe
>> 6QNfUvdBJir7opduWpcnBvN0%3D&amp;reserved=0
> 
> There were few compilation issues. Fixed locally, please have a look on the diff and confirm.
> 
> Ferruh - please note this patchset depends on the following patch to fix compilation issues:
> https://patches.dpdk.org/patch/47676/

The dependent patch looks OK, but I wonder why I don't see the build error.

mlx5_flow_dv.c has a big `#ifdef HAVE_IBV_FLOW_DV_SUPPORT` block

And `HAVE_IBV_FLOW_DV_SUPPORT` set:
if `infiniband/mlx5dv.h` has `mlx5dv_create_flow_action_packet_reformat()`

In the rdma-core I have this function is not set, so I guess I don't compile
this file at all.

What is the dependency to have `mlx5dv_create_flow_action_packet_reformat()`?
All the rdma-core versions I checked doesn't have this function, am I doing
something wrong? Or is direct verbs feature something not released yet?