From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FB6CC43214 for ; Sat, 31 Jul 2021 09:03:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC67361052 for ; Sat, 31 Jul 2021 09:03:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232568AbhGaJDS (ORCPT ); Sat, 31 Jul 2021 05:03:18 -0400 Received: from smtp-relay-canonical-1.canonical.com ([185.125.188.121]:58794 "EHLO smtp-relay-canonical-1.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232350AbhGaJDS (ORCPT ); Sat, 31 Jul 2021 05:03:18 -0400 Received: from mail-ed1-f72.google.com (mail-ed1-f72.google.com [209.85.208.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-1.canonical.com (Postfix) with ESMTPS id 36F9B3F114 for ; Sat, 31 Jul 2021 09:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627722191; bh=xAvGdDMakW4Wo5VhUe4CQjuLm6JHx80DZ/BBoHmFnVY=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=q10RyZKtgjaE0FmOh4DcGdbjBRwDfNSXNVppCHthKvSJ+du7F/zv7kkJE41R3tnRl nruk5+atnHUNuSfzrUUn1WPEiqKJvCbtkudYyhRipYNHVwPZJkiyzb5Ar2stMbukXp BJgh9DNxqVgvMN7u2x5UMS1Mj2xFL7l4SF+UpKfXf7IaX9YbT8jHbD6tVZhgPA2U4h dDikbeMFPpbAjhDU/SsKgNYWDwIyznfNQFo+SdFjfVlYW4rDQSrkZY5Ml/pZVezAPW zY8O3JbQE0RAsodehUjJw4/IM3OAZBSrDCWSWFGd82D8u7IMcyKw8JqTQyfmoRA91I Kszda8RIOffQQ== Received: by mail-ed1-f72.google.com with SMTP id x1-20020a05640218c1b02903bc7f97f858so4256729edy.2 for ; Sat, 31 Jul 2021 02:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xAvGdDMakW4Wo5VhUe4CQjuLm6JHx80DZ/BBoHmFnVY=; b=OnKdD2KKWPiS6fczG+7EBZYTA8ZS1K/Se4SvZNM6Wah7OmZqDAolhEi1lPl+xo+2cQ 1N5xi0XOE0j9o3rtdr7PYWvNRr7rzbXQ516Pcf/OTMHL27AqVxmjUvQlXhgyWSAmb/7i rXTJeRPoDU6Mx4kzCs2myjcXPG3OqcNvO1RJ5chFeGp8hh+nIDyBYGhb46PhPgG1hf3w r29VNSOZoYpSz1gjtensDcLp0trFDgTWb9pyC6oSL8VDXqbX5nipWLeLTcoOIsWO4V9/ f/1t3MuKni47RfYVgOMXqZ/Rv3MobyzAg8Zhg7Iu3n/kC+V2PO2saz/0PHf7AsnZcUH2 LoOw== X-Gm-Message-State: AOAM532ipXuugXE9wD1pHc7hgx3GJJ6Xz8azluxwzg4/dyrrFH0WQWlO ZxBXDlTP5ntul8pNHCqb25TTqQzFe8fjoP6vtGQ8HDHuzx8BgXMR4lmXK7hDav1rVhPZmgADNqS Zlgm6LUfFIrd9zd6f0BQDZO3NlvUJuc0cG61h1z8= X-Received: by 2002:a17:906:cb96:: with SMTP id mf22mr2326949ejb.50.1627722190386; Sat, 31 Jul 2021 02:03:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjcorQOIS88HLhmYNu5hYzY5lta8pKxaU2fxmGljQkD9n5onqcJel1kmPGG2SvlUwMqkoJAg== X-Received: by 2002:a17:906:cb96:: with SMTP id mf22mr2326922ejb.50.1627722190002; Sat, 31 Jul 2021 02:03:10 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id cw9sm1397382ejc.59.2021.07.31.02.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 02:03:09 -0700 (PDT) To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-13-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Subject: Re: [PATCH 12/12] arm64: dts: exynos: Add Exynos850 SoC support Message-ID: <455cfb5e-dff7-a5c0-3875-49abe3e900f3@canonical.com> Date: Sat, 31 Jul 2021 11:03:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-13-semen.protsenko@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 30/07/2021 16:49, Sam Protsenko wrote: > Samsung Exynos850 is ARMv8-based mobile-oriented SoC. > > Features: > * CPU: Cortex-A55 Octa (8 cores), up to 2 GHz > * Memory interface: LPDDR4/4x 2 channels (12.8 GB/s) > * SD/MMC: SD 3.0, eMMC5.1 DDR 8-bit > * Modem: 4G LTE, 3G, GSM/GPRS/EDGE > * RF: Quad GNSS, WiFi 5 (802.11ac), Bluetooth 5.0 > * GPU: Mali-G52 MP1 > * Codec: 1080p 60fps H64, HEVC, JPEG HW Codec > * Display: Full HD+ (2520x1080)@60fps LCD > * Camera: 16+5MP/13+8MP ISP, MIPI CSI 4/4/2, FD, DRC > * Connectivity: USB 2.0 DRD, USI (SPI/UART/I2C), HSI2C, I3C, ADC, Audio Please document first the features you add (and are working) and afterwards mention all others capabilities. > > This patch adds minimal SoC support. Particular board device tree files > can include exynos850.dtsi file to get SoC related nodes, and then > reference those nodes further as needed. > > Signed-off-by: Sam Protsenko > --- > .../boot/dts/exynos/exynos850-pinctrl.dtsi | 782 ++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos850-usi.dtsi | 30 + > arch/arm64/boot/dts/exynos/exynos850.dtsi | 245 ++++++ Not buildable. Missing Makefile, missing DTS. Please submit with initial DTS, otherwise no one is able to verify it even compiles. > 3 files changed, 1057 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > create mode 100644 arch/arm64/boot/dts/exynos/exynos850.dtsi > > diff --git a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > new file mode 100644 > index 000000000000..4cf0a22cc6db > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > @@ -0,0 +1,782 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos850 SoC pin-mux and pin-config device tree source > + * > + * Copyright (C) 2017 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung's Exynos850 SoC pin-mux and pin-config options are listed as device > + * tree nodes in this file. > + */ > + > +#include > + > +/ { > + /* ALIVE */ > + pinctrl@11850000 { > + gpa0: gpa0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; That's odd a little, why three cells? How this would be used/referenced? > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa1: gpa1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa2: gpa2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa3: gpa3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa4: gpa4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + ; > + }; > + > + gpq0: gpq0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + /* USI_PERI_UART_DBG */ > + uart0_bus: uart0-bus { > + samsung,pins = "gpq0-0", "gpq0-1"; > + samsung,pin-function = <2>; EXYNOS_PIN_FUNC_2 > + samsung,pin-pud = <0>; EXYNOS_PIN_PULL_xx? > + }; > + > + decon_f_te_on: decon_f_te_on { 1. Where is it used? 2. Use hyphens in node names. Please build it with W=1 and fix the warnings. > + samsung,pins = "gpa4-1"; Order the nodes based on first pin name, so: i2c5_bus i2c6_bus decon_f_te_on uart0_bus > + samsung,pin-function = <0xf>; > + }; > + > + decon_f_te_off: decon_f_te_off { Where is it used? > + samsung,pins = "gpa4-1"; > + samsung,pin-function = <0x0>; > + }; > + > + /* I2C_5 | CAM_PMIC_I2C */ This comment is confusing. I2C-5 is obvious from node name and label. CAM_PMIC_I2C does not look like property of SoC but board. > + i2c5_bus: i2c5-bus { > + samsung,pins = "gpa3-5", "gpa3-6"; > + samsung,pin-function = <3>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* I2C_6 | MOTOR_I2C */ > + i2c6_bus: i2c6-bus { > + samsung,pins = "gpa3-7", "gpa4-0"; > + samsung,pin-function = <3>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + }; > + > + /* CMGP */ > + pinctrl@11c30000 { > + gpm0: gpm0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm1: gpm1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm2: gpm2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm3: gpm3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm4: gpm4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm5: gpm5 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + /* usi_cmgp00 */ > + hsi2c3_bus: hsi2c3-bus { > + samsung,pins = "gpm0-0", "gpm1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_cmgp01 */ > + hsi2c4_bus: hsi2c4-bus { > + samsung,pins = "gpm4-0", "gpm5-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* spi usi_cmgp00 */ > + spi1_bus: spi1-bus { > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi1_cs: spi1-cs { > + samsung,pins = "gpm3-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi1_cs_func: spi1-cs-func { > + samsung,pins = "gpm3-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + /* spi usi_cmgp01 */ > + spi2_bus: spi2-bus { > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi2_cs: spi2-cs { > + samsung,pins = "gpm7-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi2_cs_func: spi2-cs-func { > + samsung,pins = "gpm7-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_cmgp00_uart */ > + uart1_bus_single: uart1-bus { > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0", "gpm3-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + uart1_bus_dual: uart1-bus-dual { > + samsung,pins = "gpm0-0", "gpm1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + /* usi_cmgp01_uart */ > + uart2_bus_single: uart2-bus { > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0", "gpm7-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + uart2_bus_dual: uart2-bus-dual { > + samsung,pins = "gpm4-0", "gpm5-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + }; > + > + /* AUD */ > + pinctrl@14a60000 { > + gpb0: gpb0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb1: gpb1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + aud_codec_mclk: aud-codec-mclk { > + samsung,pins = "gpb0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_codec_mclk_idle: aud-codec-mclk-idle { > + samsung,pins = "gpb0-0"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s0_bus: aud-i2s0-bus { > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s0_idle: aud-i2s0-idle { > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s1_bus: aud-i2s1-bus { > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s1_idle: aud-i2s1-idle { > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_fm_bus: aud-fm-bus { > + samsung,pins = "gpb1-4"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_fm_idle: aud-fm-idle { > + samsung,pins = "gpb1-4"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + }; > + > + /* HSI */ > + pinctrl@13430000 { > + gpf2: gpf2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd2_clk: sd2-clk { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_cmd: sd2-cmd { > + samsung,pins = "gpf2-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_bus1: sd2-bus-width1 { > + samsung,pins = "gpf2-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_bus4: sd2-bus-width4 { > + samsung,pins = "gpf2-3", "gpf2-4", "gpf2-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_clk_fast_slew_rate_1x: sd2-clk_fast_slew_rate_1x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + sd2_clk_fast_slew_rate_1_5x: sd2-clk_fast_slew_rate_1_5x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <1>; > + }; > + > + sd2_clk_fast_slew_rate_2x: sd2-clk_fast_slew_rate_2x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_clk_fast_slew_rate_2_5x: sd2-clk_fast_slew_rate_2_5x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + sd2_clk_fast_slew_rate_3x: sd2-clk_fast_slew_rate_3x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <4>; > + }; > + > + sd2_clk_fast_slew_rate_4x: sd2-clk_fast_slew_rate_4x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <5>; > + }; > + > + sd2_pins_as_pdn: sd2-pins-as-pdn { > + samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3", > + "gpf2-4", "gpf2-5"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <2>; > + }; > + No need for blank line. > + }; > + > + /* CORE */ > + pinctrl@12070000 { > + gpf0: gpf0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd0_clk: sd0-clk { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_cmd: sd0-cmd { > + samsung,pins = "gpf0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_rdqs: sd0-rdqs { > + samsung,pins = "gpf0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_nreset: sd0-nreset { > + samsung,pins = "gpf0-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_clk_fast_slew_rate_1x: sd0-clk_fast_slew_rate_1x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <1>; > + }; > + > + sd0_clk_fast_slew_rate_2x: sd0-clk_fast_slew_rate_2x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd0_clk_fast_slew_rate_3x: sd0-clk_fast_slew_rate_3x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd0_clk_fast_slew_rate_4x: sd0-clk_fast_slew_rate_4x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + gpf1: gpf1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd0_bus1: sd0-bus-width1 { > + samsung,pins = "gpf1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_bus4: sd0-bus-width4 { > + samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_bus8: sd0-bus-width8 { > + samsung,pins = "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + }; > + > + /* PERI */ > + pinctrl@139b0000 { > + gpg0: gpg0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpp0: gpp0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + gpp1: gpp1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpp2: gpp2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg1: gpg1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg2: gpg2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg3: gpg3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpc0: gpc0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpc1: gpc1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + xclkout: xclkout { > + samsung,pins = "gpq0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + /* usi_hsi2c_0 */ Comment seems to duplicate node name/label. > + hsi2c0_bus: hsi2c0-bus { > + samsung,pins = "gpc1-0", "gpc1-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_hsi2c_1 */ > + hsi2c1_bus: hsi2c1-bus { > + samsung,pins = "gpc1-2", "gpc1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_hsi2c_2 */ > + hsi2c2_bus: hsi2c2-bus { > + samsung,pins = "gpc1-4", "gpc1-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_spi_0 */ > + spi0_bus: spi0-bus { > + samsung,pins = "gpp2-0", "gpp2-2", "gpp2-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi0_cs: spi0-cs { > + samsung,pins = "gpp2-1"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi0_cs_func: spi0-cs-func { > + samsung,pins = "gpp2-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + i2c0_bus: i2c0-bus { > + samsung,pins = "gpp0-0", "gpp0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + i2c1_bus: i2c1-bus { > + samsung,pins = "gpp0-2", "gpp0-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c2_bus: i2c2-bus { > + samsung,pins = "gpp0-4", "gpp0-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c3_bus: i2c3-bus { > + samsung,pins = "gpp1-0", "gpp1-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c4_bus: i2c4-bus { > + samsung,pins = "gpp1-2", "gpp1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + fm_lna_en: fm-lna-en { > + samsung,pins = "gpg2-3"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-val = <0>; > + }; > + > + sensor_mclk0_in: sensor-mclk0-in { > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk0_out: sensor-mclk0-out { > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk0_fn: sensor-mclk0-fn { No, seriously. What sensor is it? In SoC? > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_in: sensor-mclk1-in { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_out: sensor-mclk1-out { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_fn: sensor-mclk1-fn { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_in: sensor-mclk2-in { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_out: sensor-mclk2-out { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_fn: sensor-mclk2-fn { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > new file mode 100644 > index 000000000000..fb243e0a6260 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos850 SoC USI device tree source > + * > + * Copyright (C) 2019 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung's Exynos850 SoC USI channels are listed in this file as device tree > + * nodes. Why here not in exynos850.dtsi? > + */ > + > +#include > + > +/ { > + aliases { > + uart0 = &serial_0; > + }; > + > + /* USI_UART */ > + serial_0: uart@13820000 { This should ne in soc node. > + compatible = "samsung,exynos850-uart"; > + reg = <0x0 0x13820000 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_bus>; > + clocks = <&clock GATE_UART_QCH>, <&clock DOUT_UART>; > + clock-names = "gate_uart_clk0", "uart"; > + status = "disabled"; > + }; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > new file mode 100644 > index 000000000000..ed2d1c8ae0c3 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > @@ -0,0 +1,245 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung Exynos850 SoC device tree source > + * > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung Exynos850 SoC device nodes are listed in this file. > + * Exynos based board files can include this file and provide > + * values for board specific bindings. > + */ > + > +#include > +#include > +#include "exynos850-pinctrl.dtsi" > +#include "exynos850-usi.dtsi" > + > +/ { Add a comment like: /* Also known under engineering name exynos3830 */ > + compatible = "samsung,exynos850"; Undocumented compatible. Checkpatch should complain. > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <1>; > + > + aliases { > + pinctrl0 = &pinctrl_0; > + pinctrl1 = &pinctrl_1; > + pinctrl2 = &pinctrl_2; > + pinctrl3 = &pinctrl_3; > + pinctrl4 = &pinctrl_4; > + pinctrl5 = &pinctrl_5; > + }; > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + core1 { > + cpu = <&cpu1>; > + }; > + core2 { > + cpu = <&cpu2>; > + }; > + core3 { > + cpu = <&cpu3>; > + }; > + }; > + > + cluster1 { > + core0 { > + cpu = <&cpu4>; > + }; > + core1 { > + cpu = <&cpu5>; > + }; > + core2 { > + cpu = <&cpu6>; > + }; > + core3 { > + cpu = <&cpu7>; > + }; > + }; > + }; > + > + cpu0: cpu@0000 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0000>; reg = <0x0 0x0>; (in following places similarly) > + enable-method = "psci"; > + }; > + cpu1: cpu@0001 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0001>; > + enable-method = "psci"; > + }; > + cpu2: cpu@0002 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0002>; > + enable-method = "psci"; > + }; > + cpu3: cpu@0003 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0003>; > + enable-method = "psci"; > + }; > + cpu4: cpu@0004 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0100>; > + enable-method = "psci"; > + }; > + cpu5: cpu@0005 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0101>; > + enable-method = "psci"; > + }; > + cpu6: cpu@0006 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0102>; > + enable-method = "psci"; > + }; > + cpu7: cpu@0007 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0103>; > + enable-method = "psci"; > + }; > + }; > + > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + gic: interrupt-controller@12a00000 { > + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x0 0x12a01000 0x1000>, > + <0x0 0x12a02000 0x1000>, > + <0x0 0x12a04000 0x2000>, > + <0x0 0x12a06000 0x2000>; > + interrupts = + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <26000000>; > + use-clocksource-only; > + use-physical-timer; > + }; > + All below should be under soc node. Please don't write new DTS/DTSI from scratch but use exynos5433.dtsi as template/example. > + clock: clock-controller@0x120e0000 { > + compatible = "samsung,exynos850-clock"; > + reg = <0x0 0x120e0000 0x8000>; > + #clock-cells = <1>; > + }; > + > + /* ALIVE */ > + pinctrl_0: pinctrl@11850000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x11850000 0x1000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + wakeup-interrupt-controller { > + compatible = "samsung,exynos7-wakeup-eint"; > + }; > + }; > + > + /* CMGP */ > + pinctrl_1: pinctrl@11c30000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x11c30000 0x1000>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + > + wakeup-interrupt-controller { > + compatible = "samsung,exynos7-wakeup-eint"; > + }; > + }; > + > + /* AUD */ > + pinctrl_2: pinctrl@14a60000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x14a60000 0x1000>; > + }; > + > + /* HSI */ > + pinctrl_3: pinctrl@13430000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x13430000 0x1000>; > + interrupts = ; > + }; > + > + /* CORE */ > + pinctrl_4: pinctrl@12070000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x12070000 0x1000>; > + interrupts = ; > + }; > + > + /* PERI */ > + pinctrl_5: pinctrl@139b0000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x139b0000 0x1000>; > + interrupts = ; > + }; > +}; > Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2CF5C4338F for ; Sat, 31 Jul 2021 09:05:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DAD060FE7 for ; Sat, 31 Jul 2021 09:05:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DAD060FE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=gQDVN5o11sl9ije6FfWDUQ3Bw+xAWjIziTTo2LMDmq8=; b=UNJTtfuE1jhQyKBpfKXDGvaRR/ xK2LH664zaSki/fzlCwcoe07HffhmsePFR+3L9oa7AJH6tLOEBKX/AJXSGP5mPlpHi3IJynEY/FmD GuGVa4bdpTXsGrRGYYcf22Ne1JLZBuH05t6RKgXIM9zYPTcAGWXCgiTrdYjessqsc8F8H87hLI3rd NNpVxggUDjIsk54qRSDo9oNpxUYtGjIPeHbDaZnFWZkqLFdURBqAMlAHs4q+KACAkTRYV+x6wW1iO SP5gHllRwRzsmoLktsR5jXu0ZJxiqW+EAV50bzxQrjirTqcdGjOzToVMiIk3VXLdZVC18TBbEW9KS WOeSUFxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9ktq-00BJIr-9A; Sat, 31 Jul 2021 09:03:18 +0000 Received: from smtp-relay-canonical-0.canonical.com ([185.125.188.120]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m9ktk-00BJIP-I2 for linux-arm-kernel@lists.infradead.org; Sat, 31 Jul 2021 09:03:16 +0000 Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPS id 1F90E3F230 for ; Sat, 31 Jul 2021 09:03:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1627722191; bh=xAvGdDMakW4Wo5VhUe4CQjuLm6JHx80DZ/BBoHmFnVY=; h=To:Cc:References:From:Subject:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=q10RyZKtgjaE0FmOh4DcGdbjBRwDfNSXNVppCHthKvSJ+du7F/zv7kkJE41R3tnRl nruk5+atnHUNuSfzrUUn1WPEiqKJvCbtkudYyhRipYNHVwPZJkiyzb5Ar2stMbukXp BJgh9DNxqVgvMN7u2x5UMS1Mj2xFL7l4SF+UpKfXf7IaX9YbT8jHbD6tVZhgPA2U4h dDikbeMFPpbAjhDU/SsKgNYWDwIyznfNQFo+SdFjfVlYW4rDQSrkZY5Ml/pZVezAPW zY8O3JbQE0RAsodehUjJw4/IM3OAZBSrDCWSWFGd82D8u7IMcyKw8JqTQyfmoRA91I Kszda8RIOffQQ== Received: by mail-ed1-f69.google.com with SMTP id s8-20020a0564020148b02903948b71f25cso5855214edu.4 for ; Sat, 31 Jul 2021 02:03:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xAvGdDMakW4Wo5VhUe4CQjuLm6JHx80DZ/BBoHmFnVY=; b=mrClwbrncHyugcsMCqw9JIzOJ19LEB46nrs9g3Q1RnZfyOUYUI6CzruN1RuxAumZY+ nnj9rK5nQfnmdwCWSkyDtysdxnBAhY9YLayzQ86KLkv4GxPmAz0vvtIhWoicqCHX4Qjf W1VPcSkAfrzXzbyAqqTjiUhNzRQqo6aEXq18ddD3C30j2zkyykFZIWn+zZhb+7i5q37b iEkn80blR4UrNJq6ByUEg6dySfj5jypdScCkd6j3mspn3wrG/SKC+OarC5MVPxol/OLJ iZFUVihav/zhT8mSEW0FeNeNDcmucN+ecFepOzZr5tVphQYUOAOYODzJ4w94Aexc8bZK MUUw== X-Gm-Message-State: AOAM531uZGzkc4rUpXKzJ9DWm9prEmt06967PDJhxoI3i0gLAzlcW9sL vJ1RB8gC2upyovRM4v2N2AXRaEoQ7F9wNw5q0Eow9XaMF5jaJsvzewlxoCH0kPQDn5/8IlfDAMb B7n+3RjH6b8khMeNgmiy6VsHDL3uqZ558EbhvkH93rowNqdhE6BtI X-Received: by 2002:a17:906:cb96:: with SMTP id mf22mr2326943ejb.50.1627722190384; Sat, 31 Jul 2021 02:03:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyjcorQOIS88HLhmYNu5hYzY5lta8pKxaU2fxmGljQkD9n5onqcJel1kmPGG2SvlUwMqkoJAg== X-Received: by 2002:a17:906:cb96:: with SMTP id mf22mr2326922ejb.50.1627722190002; Sat, 31 Jul 2021 02:03:10 -0700 (PDT) Received: from [192.168.8.102] ([86.32.47.9]) by smtp.gmail.com with ESMTPSA id cw9sm1397382ejc.59.2021.07.31.02.03.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Jul 2021 02:03:09 -0700 (PDT) To: Sam Protsenko , Sylwester Nawrocki , Chanwoo Choi , Linus Walleij , Tomasz Figa Cc: Rob Herring , Stephen Boyd , Michael Turquette , Jiri Slaby , Greg Kroah-Hartman , Charles Keepax , Ryu Euiyoul , Tom Gall , Sumit Semwal , John Stultz , Amit Pundir , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org References: <20210730144922.29111-1-semen.protsenko@linaro.org> <20210730144922.29111-13-semen.protsenko@linaro.org> From: Krzysztof Kozlowski Subject: Re: [PATCH 12/12] arm64: dts: exynos: Add Exynos850 SoC support Message-ID: <455cfb5e-dff7-a5c0-3875-49abe3e900f3@canonical.com> Date: Sat, 31 Jul 2021 11:03:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210730144922.29111-13-semen.protsenko@linaro.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210731_020312_999732_BD6C7EF5 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 30/07/2021 16:49, Sam Protsenko wrote: > Samsung Exynos850 is ARMv8-based mobile-oriented SoC. > > Features: > * CPU: Cortex-A55 Octa (8 cores), up to 2 GHz > * Memory interface: LPDDR4/4x 2 channels (12.8 GB/s) > * SD/MMC: SD 3.0, eMMC5.1 DDR 8-bit > * Modem: 4G LTE, 3G, GSM/GPRS/EDGE > * RF: Quad GNSS, WiFi 5 (802.11ac), Bluetooth 5.0 > * GPU: Mali-G52 MP1 > * Codec: 1080p 60fps H64, HEVC, JPEG HW Codec > * Display: Full HD+ (2520x1080)@60fps LCD > * Camera: 16+5MP/13+8MP ISP, MIPI CSI 4/4/2, FD, DRC > * Connectivity: USB 2.0 DRD, USI (SPI/UART/I2C), HSI2C, I3C, ADC, Audio Please document first the features you add (and are working) and afterwards mention all others capabilities. > > This patch adds minimal SoC support. Particular board device tree files > can include exynos850.dtsi file to get SoC related nodes, and then > reference those nodes further as needed. > > Signed-off-by: Sam Protsenko > --- > .../boot/dts/exynos/exynos850-pinctrl.dtsi | 782 ++++++++++++++++++ > arch/arm64/boot/dts/exynos/exynos850-usi.dtsi | 30 + > arch/arm64/boot/dts/exynos/exynos850.dtsi | 245 ++++++ Not buildable. Missing Makefile, missing DTS. Please submit with initial DTS, otherwise no one is able to verify it even compiles. > 3 files changed, 1057 insertions(+) > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > create mode 100644 arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > create mode 100644 arch/arm64/boot/dts/exynos/exynos850.dtsi > > diff --git a/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > new file mode 100644 > index 000000000000..4cf0a22cc6db > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-pinctrl.dtsi > @@ -0,0 +1,782 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos850 SoC pin-mux and pin-config device tree source > + * > + * Copyright (C) 2017 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung's Exynos850 SoC pin-mux and pin-config options are listed as device > + * tree nodes in this file. > + */ > + > +#include > + > +/ { > + /* ALIVE */ > + pinctrl@11850000 { > + gpa0: gpa0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; That's odd a little, why three cells? How this would be used/referenced? > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa1: gpa1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa2: gpa2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa3: gpa3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > + gpa4: gpa4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + , > + , > + , > + ; > + }; > + > + gpq0: gpq0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + /* USI_PERI_UART_DBG */ > + uart0_bus: uart0-bus { > + samsung,pins = "gpq0-0", "gpq0-1"; > + samsung,pin-function = <2>; EXYNOS_PIN_FUNC_2 > + samsung,pin-pud = <0>; EXYNOS_PIN_PULL_xx? > + }; > + > + decon_f_te_on: decon_f_te_on { 1. Where is it used? 2. Use hyphens in node names. Please build it with W=1 and fix the warnings. > + samsung,pins = "gpa4-1"; Order the nodes based on first pin name, so: i2c5_bus i2c6_bus decon_f_te_on uart0_bus > + samsung,pin-function = <0xf>; > + }; > + > + decon_f_te_off: decon_f_te_off { Where is it used? > + samsung,pins = "gpa4-1"; > + samsung,pin-function = <0x0>; > + }; > + > + /* I2C_5 | CAM_PMIC_I2C */ This comment is confusing. I2C-5 is obvious from node name and label. CAM_PMIC_I2C does not look like property of SoC but board. > + i2c5_bus: i2c5-bus { > + samsung,pins = "gpa3-5", "gpa3-6"; > + samsung,pin-function = <3>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* I2C_6 | MOTOR_I2C */ > + i2c6_bus: i2c6-bus { > + samsung,pins = "gpa3-7", "gpa4-0"; > + samsung,pin-function = <3>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + }; > + > + /* CMGP */ > + pinctrl@11c30000 { > + gpm0: gpm0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm1: gpm1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm2: gpm2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm3: gpm3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm4: gpm4 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + gpm5: gpm5 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <3>; > + interrupt-parent = <&gic>; > + interrupts = > + ; > + }; > + > + /* usi_cmgp00 */ > + hsi2c3_bus: hsi2c3-bus { > + samsung,pins = "gpm0-0", "gpm1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_cmgp01 */ > + hsi2c4_bus: hsi2c4-bus { > + samsung,pins = "gpm4-0", "gpm5-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* spi usi_cmgp00 */ > + spi1_bus: spi1-bus { > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi1_cs: spi1-cs { > + samsung,pins = "gpm3-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi1_cs_func: spi1-cs-func { > + samsung,pins = "gpm3-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + /* spi usi_cmgp01 */ > + spi2_bus: spi2-bus { > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi2_cs: spi2-cs { > + samsung,pins = "gpm7-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi2_cs_func: spi2-cs-func { > + samsung,pins = "gpm7-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_cmgp00_uart */ > + uart1_bus_single: uart1-bus { > + samsung,pins = "gpm0-0", "gpm1-0", "gpm2-0", "gpm3-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + uart1_bus_dual: uart1-bus-dual { > + samsung,pins = "gpm0-0", "gpm1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + /* usi_cmgp01_uart */ > + uart2_bus_single: uart2-bus { > + samsung,pins = "gpm4-0", "gpm5-0", "gpm6-0", "gpm7-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + uart2_bus_dual: uart2-bus-dual { > + samsung,pins = "gpm4-0", "gpm5-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + }; > + > + /* AUD */ > + pinctrl@14a60000 { > + gpb0: gpb0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpb1: gpb1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + aud_codec_mclk: aud-codec-mclk { > + samsung,pins = "gpb0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_codec_mclk_idle: aud-codec-mclk-idle { > + samsung,pins = "gpb0-0"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s0_bus: aud-i2s0-bus { > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s0_idle: aud-i2s0-idle { > + samsung,pins = "gpb0-1", "gpb0-2", "gpb0-3", "gpb0-4"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s1_bus: aud-i2s1-bus { > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_i2s1_idle: aud-i2s1-idle { > + samsung,pins = "gpb1-0", "gpb1-1", "gpb1-2", "gpb1-3"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + > + aud_fm_bus: aud-fm-bus { > + samsung,pins = "gpb1-4"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + }; > + > + aud_fm_idle: aud-fm-idle { > + samsung,pins = "gpb1-4"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <1>; > + }; > + }; > + > + /* HSI */ > + pinctrl@13430000 { > + gpf2: gpf2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd2_clk: sd2-clk { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_cmd: sd2-cmd { > + samsung,pins = "gpf2-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_bus1: sd2-bus-width1 { > + samsung,pins = "gpf2-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_bus4: sd2-bus-width4 { > + samsung,pins = "gpf2-3", "gpf2-4", "gpf2-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_clk_fast_slew_rate_1x: sd2-clk_fast_slew_rate_1x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + sd2_clk_fast_slew_rate_1_5x: sd2-clk_fast_slew_rate_1_5x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <1>; > + }; > + > + sd2_clk_fast_slew_rate_2x: sd2-clk_fast_slew_rate_2x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd2_clk_fast_slew_rate_2_5x: sd2-clk_fast_slew_rate_2_5x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + sd2_clk_fast_slew_rate_3x: sd2-clk_fast_slew_rate_3x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <4>; > + }; > + > + sd2_clk_fast_slew_rate_4x: sd2-clk_fast_slew_rate_4x { > + samsung,pins = "gpf2-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <5>; > + }; > + > + sd2_pins_as_pdn: sd2-pins-as-pdn { > + samsung,pins = "gpf2-0", "gpf2-1", "gpf2-2", "gpf2-3", > + "gpf2-4", "gpf2-5"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <2>; > + }; > + No need for blank line. > + }; > + > + /* CORE */ > + pinctrl@12070000 { > + gpf0: gpf0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd0_clk: sd0-clk { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_cmd: sd0-cmd { > + samsung,pins = "gpf0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_rdqs: sd0-rdqs { > + samsung,pins = "gpf0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_nreset: sd0-nreset { > + samsung,pins = "gpf0-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_clk_fast_slew_rate_1x: sd0-clk_fast_slew_rate_1x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <1>; > + }; > + > + sd0_clk_fast_slew_rate_2x: sd0-clk_fast_slew_rate_2x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd0_clk_fast_slew_rate_3x: sd0-clk_fast_slew_rate_3x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sd0_clk_fast_slew_rate_4x: sd0-clk_fast_slew_rate_4x { > + samsung,pins = "gpf0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <3>; > + }; > + > + gpf1: gpf1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + sd0_bus1: sd0-bus-width1 { > + samsung,pins = "gpf1-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_bus4: sd0-bus-width4 { > + samsung,pins = "gpf1-1", "gpf1-2", "gpf1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + > + sd0_bus8: sd0-bus-width8 { > + samsung,pins = "gpf1-4", "gpf1-5", "gpf1-6", "gpf1-7"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <3>; > + }; > + }; > + > + /* PERI */ > + pinctrl@139b0000 { > + gpg0: gpg0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpp0: gpp0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + gpp1: gpp1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpp2: gpp2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg1: gpg1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg2: gpg2 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpg3: gpg3 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpc0: gpc0 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + gpc1: gpc1 { > + gpio-controller; > + #gpio-cells = <2>; > + > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > + > + xclkout: xclkout { > + samsung,pins = "gpq0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + }; > + > + /* usi_hsi2c_0 */ Comment seems to duplicate node name/label. > + hsi2c0_bus: hsi2c0-bus { > + samsung,pins = "gpc1-0", "gpc1-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_hsi2c_1 */ > + hsi2c1_bus: hsi2c1-bus { > + samsung,pins = "gpc1-2", "gpc1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_hsi2c_2 */ > + hsi2c2_bus: hsi2c2-bus { > + samsung,pins = "gpc1-4", "gpc1-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + /* usi_spi_0 */ > + spi0_bus: spi0-bus { > + samsung,pins = "gpp2-0", "gpp2-2", "gpp2-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi0_cs: spi0-cs { > + samsung,pins = "gpp2-1"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + spi0_cs_func: spi0-cs-func { > + samsung,pins = "gpp2-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + i2c0_bus: i2c0-bus { > + samsung,pins = "gpp0-0", "gpp0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <0>; > + }; > + > + i2c1_bus: i2c1-bus { > + samsung,pins = "gpp0-2", "gpp0-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c2_bus: i2c2-bus { > + samsung,pins = "gpp0-4", "gpp0-5"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c3_bus: i2c3-bus { > + samsung,pins = "gpp1-0", "gpp1-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + i2c4_bus: i2c4-bus { > + samsung,pins = "gpp1-2", "gpp1-3"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <3>; > + samsung,pin-drv = <0>; > + }; > + > + fm_lna_en: fm-lna-en { > + samsung,pins = "gpg2-3"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <0>; > + samsung,pin-val = <0>; > + }; > + > + sensor_mclk0_in: sensor-mclk0-in { > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk0_out: sensor-mclk0-out { > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk0_fn: sensor-mclk0-fn { No, seriously. What sensor is it? In SoC? > + samsung,pins = "gpc0-0"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_in: sensor-mclk1-in { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_out: sensor-mclk1-out { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk1_fn: sensor-mclk1-fn { > + samsung,pins = "gpc0-1"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_in: sensor-mclk2-in { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <0>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_out: sensor-mclk2-out { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <1>; > + samsung,pin-pud = <1>; > + samsung,pin-drv = <2>; > + }; > + > + sensor_mclk2_fn: sensor-mclk2-fn { > + samsung,pins = "gpc0-2"; > + samsung,pin-function = <2>; > + samsung,pin-pud = <0>; > + samsung,pin-drv = <2>; > + }; > + }; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > new file mode 100644 > index 000000000000..fb243e0a6260 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850-usi.dtsi > @@ -0,0 +1,30 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos850 SoC USI device tree source > + * > + * Copyright (C) 2019 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung's Exynos850 SoC USI channels are listed in this file as device tree > + * nodes. Why here not in exynos850.dtsi? > + */ > + > +#include > + > +/ { > + aliases { > + uart0 = &serial_0; > + }; > + > + /* USI_UART */ > + serial_0: uart@13820000 { This should ne in soc node. > + compatible = "samsung,exynos850-uart"; > + reg = <0x0 0x13820000 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&uart0_bus>; > + clocks = <&clock GATE_UART_QCH>, <&clock DOUT_UART>; > + clock-names = "gate_uart_clk0", "uart"; > + status = "disabled"; > + }; > +}; > diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi > new file mode 100644 > index 000000000000..ed2d1c8ae0c3 > --- /dev/null > +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi > @@ -0,0 +1,245 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung Exynos850 SoC device tree source > + * > + * Copyright (C) 2018 Samsung Electronics Co., Ltd. > + * Copyright (C) 2021 Linaro Ltd. > + * > + * Samsung Exynos850 SoC device nodes are listed in this file. > + * Exynos based board files can include this file and provide > + * values for board specific bindings. > + */ > + > +#include > +#include > +#include "exynos850-pinctrl.dtsi" > +#include "exynos850-usi.dtsi" > + > +/ { Add a comment like: /* Also known under engineering name exynos3830 */ > + compatible = "samsung,exynos850"; Undocumented compatible. Checkpatch should complain. > + interrupt-parent = <&gic>; > + #address-cells = <2>; > + #size-cells = <1>; > + > + aliases { > + pinctrl0 = &pinctrl_0; > + pinctrl1 = &pinctrl_1; > + pinctrl2 = &pinctrl_2; > + pinctrl3 = &pinctrl_3; > + pinctrl4 = &pinctrl_4; > + pinctrl5 = &pinctrl_5; > + }; > + > + cpus { > + #address-cells = <2>; > + #size-cells = <0>; > + > + cpu-map { > + cluster0 { > + core0 { > + cpu = <&cpu0>; > + }; > + core1 { > + cpu = <&cpu1>; > + }; > + core2 { > + cpu = <&cpu2>; > + }; > + core3 { > + cpu = <&cpu3>; > + }; > + }; > + > + cluster1 { > + core0 { > + cpu = <&cpu4>; > + }; > + core1 { > + cpu = <&cpu5>; > + }; > + core2 { > + cpu = <&cpu6>; > + }; > + core3 { > + cpu = <&cpu7>; > + }; > + }; > + }; > + > + cpu0: cpu@0000 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0000>; reg = <0x0 0x0>; (in following places similarly) > + enable-method = "psci"; > + }; > + cpu1: cpu@0001 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0001>; > + enable-method = "psci"; > + }; > + cpu2: cpu@0002 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0002>; > + enable-method = "psci"; > + }; > + cpu3: cpu@0003 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0003>; > + enable-method = "psci"; > + }; > + cpu4: cpu@0004 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0100>; > + enable-method = "psci"; > + }; > + cpu5: cpu@0005 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0101>; > + enable-method = "psci"; > + }; > + cpu6: cpu@0006 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0102>; > + enable-method = "psci"; > + }; > + cpu7: cpu@0007 { > + device_type = "cpu"; > + compatible = "arm,cortex-a55", "arm,armv8"; > + reg = <0x0 0x0103>; > + enable-method = "psci"; > + }; > + }; > + > + psci { > + compatible = "arm,psci-1.0"; > + method = "smc"; > + }; > + > + gic: interrupt-controller@12a00000 { > + compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic"; > + #interrupt-cells = <3>; > + #address-cells = <0>; > + interrupt-controller; > + reg = <0x0 0x12a01000 0x1000>, > + <0x0 0x12a02000 0x1000>, > + <0x0 0x12a04000 0x2000>, > + <0x0 0x12a06000 0x2000>; > + interrupts = + (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; > + }; > + > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>, > + + (GIC_CPU_MASK_SIMPLE(8) | IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <26000000>; > + use-clocksource-only; > + use-physical-timer; > + }; > + All below should be under soc node. Please don't write new DTS/DTSI from scratch but use exynos5433.dtsi as template/example. > + clock: clock-controller@0x120e0000 { > + compatible = "samsung,exynos850-clock"; > + reg = <0x0 0x120e0000 0x8000>; > + #clock-cells = <1>; > + }; > + > + /* ALIVE */ > + pinctrl_0: pinctrl@11850000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x11850000 0x1000>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + > + wakeup-interrupt-controller { > + compatible = "samsung,exynos7-wakeup-eint"; > + }; > + }; > + > + /* CMGP */ > + pinctrl_1: pinctrl@11c30000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x11c30000 0x1000>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + ; > + > + wakeup-interrupt-controller { > + compatible = "samsung,exynos7-wakeup-eint"; > + }; > + }; > + > + /* AUD */ > + pinctrl_2: pinctrl@14a60000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x14a60000 0x1000>; > + }; > + > + /* HSI */ > + pinctrl_3: pinctrl@13430000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x13430000 0x1000>; > + interrupts = ; > + }; > + > + /* CORE */ > + pinctrl_4: pinctrl@12070000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x12070000 0x1000>; > + interrupts = ; > + }; > + > + /* PERI */ > + pinctrl_5: pinctrl@139b0000 { > + compatible = "samsung,exynos850-pinctrl"; > + reg = <0x0 0x139b0000 0x1000>; > + interrupts = ; > + }; > +}; > Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel