From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35536C4741F for ; Wed, 4 Nov 2020 21:00:14 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 5F615207BB for ; Wed, 4 Nov 2020 21:00:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="RIHZxslu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5F615207BB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.vnet.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05E5D2BF7; Wed, 4 Nov 2020 22:00:11 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by dpdk.org (Postfix) with ESMTP id 54FB02BDB for ; Wed, 4 Nov 2020 22:00:08 +0100 (CET) Received: from pps.filterd (m0098413.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0A4KY0VR002415; Wed, 4 Nov 2020 16:00:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=tbhIRb3jkywx4WT5eyoygMFzBOhWhJaK9/gXNs4FcC0=; b=RIHZxslukKzVwu0G+h/hJODW/sVSQepFO7lrj5rFGcc/BXoEYcLdBCq8MBPgiVS+8R/N Uuhwvb2rZVLq0Q6u6ZycLgcanjNLwC7ij7V+lAZChR/03wG6TuXsMZMM0oeXNyZ+QH30 8YG/DhwtgfUYJ7NzfiVkF4rd+X+N5eyLt7hd/uQQ0LnYXzNyeaE+qP5r8sE9oqkwCOvK sApq8cv6gougerXtj5Uu5s1tguQLkEttIxctD/GCqx/BRvVKLD68wCDK5D2gqygiLUq4 85TORjRmdh4EiWMSoSqunb/FL82Jm/N9CGW3BvR//gNsLWYl6LcrgFQe4QM8dqIo5Pj5 LA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 34kxepawvh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 16:00:06 -0500 Received: from m0098413.ppops.net (m0098413.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0A4Kk8sW040973; Wed, 4 Nov 2020 16:00:06 -0500 Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 34kxepawuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 16:00:06 -0500 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0A4KrAGL019165; Wed, 4 Nov 2020 21:00:05 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma03dal.us.ibm.com with ESMTP id 34hs336ud8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 04 Nov 2020 21:00:05 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0A4L04Gp44237300 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 4 Nov 2020 21:00:04 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 97E21124078; Wed, 4 Nov 2020 21:00:04 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2BF37124070; Wed, 4 Nov 2020 21:00:04 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.93.107]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Wed, 4 Nov 2020 21:00:04 +0000 (GMT) To: Thomas Monjalon Cc: dev@dpdk.org, anatoly.burakov@intel.com, david.marchand@redhat.com References: <20201015172305.105717-1-drc@linux.vnet.ibm.com> <20201103220532.176225-1-drc@linux.vnet.ibm.com> <20201103220532.176225-2-drc@linux.vnet.ibm.com> <4042743.04XgZqB5lT@thomas> From: David Christensen Message-ID: <45613e0e-7824-d976-9dd0-ffc74513dc88@linux.vnet.ibm.com> Date: Wed, 4 Nov 2020 13:00:03 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: <4042743.04XgZqB5lT@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-04_14:2020-11-04, 2020-11-04 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 mlxlogscore=875 impostorscore=0 malwarescore=0 suspectscore=0 adultscore=0 clxscore=1015 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011040144 Subject: Re: [dpdk-dev] [PATCH v5 1/1] vfio: modify spapr iommu support to use static window sizing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/4/20 11:43 AM, Thomas Monjalon wrote: >> Signed-off-by: David Christensen >> Acked-by: Anatoly Burakov >> --- >> -#ifdef VFIO_IOMMU_SPAPR_INFO_DDW >> - /* try possible page_shift and levels for workaround */ >> + /* if at first we don't succeed, try more levels */ >> uint32_t levels; >> >> - for (levels = create->levels + 1; >> + for (levels = create.levels + 1; >> ret && levels <= info.ddw.levels; levels++) { > > There is a compilation failure with ppc64le-power8-linux-gcc: > error: ‘struct vfio_iommu_spapr_tce_info’ has no member named ‘ddw’ How did you find that error? It builds locally for me on a POWER system with Meson/gcc and there were no build failures on Travis (https://travis-ci.com/github/drchristensen/dpdk/builds/198047029) when I checked it against AMD64/ARM systems. The code is PPC specific but it will build on all architectures (there are no IFDEFs around it). Dave