From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752257AbcENOnH (ORCPT ); Sat, 14 May 2016 10:43:07 -0400 Received: from mail-ig0-f196.google.com ([209.85.213.196]:34245 "EHLO mail-ig0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751718AbcENOnF (ORCPT ); Sat, 14 May 2016 10:43:05 -0400 Subject: Re: [PATCH v3 3/7 UPDATE] perf tools: Add option for the path of buildid dsos under symfs To: He Kuang , peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, wangnan0@huawei.com, jpoimboe@redhat.com, ak@linux.intel.com, eranian@google.com, namhyung@kernel.org, adrian.hunter@intel.com, sukadev@linux.vnet.ibm.com, masami.hiramatsu.pt@hitachi.com, tumanova@linux.vnet.ibm.com, kan.liang@intel.com, penberg@kernel.org References: <20160513180104.GL11346@kernel.org> <1463213965-35230-1-git-send-email-hekuang@huawei.com> Cc: linux-kernel@vger.kernel.org From: David Ahern Message-ID: <4572f136-796d-059f-6b81-613e8f63be24@gmail.com> Date: Sat, 14 May 2016 08:43:03 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1463213965-35230-1-git-send-email-hekuang@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/14/16 2:19 AM, He Kuang wrote: > In the cross-platform perf record/script scenario, we need vdsos in > buildid-cache dir and other libs in symfs dir at the same time. For > the reason that to have every single file opened by perf is relative > to symfs dirctory, perf skips the buildid dir if symfs is given. > > This patch references the buildid dir under symfs if '--symfs' is > used, and adds new option '--dso-prefix' to specify the subdir path in > symfs which contains the buildid dsos. In the previous version of this patch you just wanted to drop the symfs check. That means there is a path that perf searches for buildid files and reading it worked for you. Why is adding symsfs to that path not enough? ie., Why do you need to specify a different location under the symfs?