All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Maple <liujian@raisecom.com>
Cc: dev@dpdk.org, 李非 <lifei@raisecom.com>, 施展 <shizhan@raisecom.com>
Subject: Re: Example(Load_balancer) Tx Flush Bug(This bug DPDK each version)
Date: Wed, 21 Dec 2016 16:08:47 +0100	[thread overview]
Message-ID: <4577901.1XJahbXBcx@xps13> (raw)
In-Reply-To: <2016122122394164225248@raisecom.com>

Hi,

Thanks for trying to send a patch.
Below are some comments to help you sending a proper patch.

2016-12-21 22:39, Maple:
> From 94f2eaed51e6e5402e8c03b80e0999a4fd420390 Mon Sep 17 00:00:00 2001
> From: root <root@liujian@raisecom.com>

Here we should have your real name, not "root".

> To: <dev@dpdk.org>
> Cc: <thomas.monjalon@6wind.com>, <lifei@raisecom.com>,<shizhan@raisecom.com>
> Date: Wed, 21 Dec 2016 22:31:29 +0800
> Subject: [PATCH] load_balancer Tx Flush Bug
> 
> We found a bug in use load_balancer example,and,This bug DPDK each version.
> In IO tx flush, only flush port 0.
> So,If I enable more than the Port,then,In addition to 0 port won't flush.
> 
> Signed-off-by: root <root@liujian@raisecom.com>

Here alse we should have your real name.
See ~/.gitconfig

> ---
>  a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++
>  b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++

You are sending the whole file instead of the diff.
Are you using git?
It should be as simple as "git clone git://dpdk.org/dpdk", then
modify the file, then "git commit -as", then send patch with
"git send-email -1 --to dev@dpdk.org".
As it will be your second version, you should add these options:
-v2 --in-reply-to '<2016122122394164225248@raisecom.com>'

Thanks

  reply	other threads:[~2016-12-21 15:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2016122121181642100644@raisecom.com>
     [not found] ` <2016122121292174988745@raisecom.com>
2016-12-21 14:39   ` Example(Load_balancer) Tx Flush Bug(This bug DPDK each version) Maple
2016-12-21 15:08     ` Thomas Monjalon [this message]
2016-12-22  2:05     ` Example(Load_balancer) Tx Flush Bug(This bug dpdk " Maple
2016-12-22 13:07       ` Maple
2016-12-23  8:23         ` Example(Load_balancer) Tx flush bug Maple
2017-01-16 11:09     ` Example(Load_balancer) Tx Flush Bug(This bug DPDK each version) Yang, Qiming
     [not found]       ` <2017011619162170012425@raisecom.com>
2017-01-16 14:18         ` [dpdk-maintainers] " Thomas Monjalon
2017-04-27  9:35           ` Andriy Berestovskyy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4577901.1XJahbXBcx@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=lifei@raisecom.com \
    --cc=liujian@raisecom.com \
    --cc=shizhan@raisecom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.