From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B7D6C48BCF for ; Wed, 9 Jun 2021 17:18:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3C328613C8 for ; Wed, 9 Jun 2021 17:18:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231435AbhFIRUd (ORCPT ); Wed, 9 Jun 2021 13:20:33 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:58946 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231396AbhFIRU1 (ORCPT ); Wed, 9 Jun 2021 13:20:27 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 159HILJ6126249; Wed, 9 Jun 2021 12:18:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1623259101; bh=msVLVZG0CgVTC8C90E1q2rYU+c929NvK/sY0LT7l5HA=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=e6wQ+V+QWTryRvGqW35cn35YyN6E7kiaagNtcEm+j5gTBRq6P7lLHtuEYSqpuznrd viJaqBZx6WnhDHtDePt20EDZIRechQEY+3Vw720Tcw/wx2eNr7r7UsI2po5CKxmLXG QhwQ9CURsspE0w6ErGDZNPTCy3UXx3EJc7/SKdiM= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 159HILxw023347 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 9 Jun 2021 12:18:21 -0500 Received: from DFLE100.ent.ti.com (10.64.6.21) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Wed, 9 Jun 2021 12:18:21 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Wed, 9 Jun 2021 12:18:21 -0500 Received: from [10.250.100.73] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 159HIJEL047861; Wed, 9 Jun 2021 12:18:20 -0500 Subject: Re: [PATCH net-next] net: ethernet: ti: cpsw: Use devm_platform_get_and_ioremap_resource() To: Yang Yingliang , , CC: , References: <20210609140152.3198309-1-yangyingliang@huawei.com> From: Grygorii Strashko Message-ID: <457bcc88-00a1-61fd-7a1d-1c8dfaaf56d6@ti.com> Date: Wed, 9 Jun 2021 20:18:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210609140152.3198309-1-yangyingliang@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/06/2021 17:01, Yang Yingliang wrote: > Use devm_platform_get_and_ioremap_resource() to simplify > code. > > Signed-off-by: Yang Yingliang > --- > drivers/net/ethernet/ti/cpsw.c | 3 +-- > drivers/net/ethernet/ti/cpsw_new.c | 3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c > index c0cd7de88316..b1e80cc96f56 100644 > --- a/drivers/net/ethernet/ti/cpsw.c > +++ b/drivers/net/ethernet/ti/cpsw.c > @@ -1532,8 +1532,7 @@ static int cpsw_probe(struct platform_device *pdev) > } > cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000; > > - ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ss_regs = devm_ioremap_resource(dev, ss_res); > + ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res); > if (IS_ERR(ss_regs)) > return PTR_ERR(ss_regs); > cpsw->regs = ss_regs; > diff --git a/drivers/net/ethernet/ti/cpsw_new.c b/drivers/net/ethernet/ti/cpsw_new.c > index 69b7a4e0220a..8d4f3c53385d 100644 > --- a/drivers/net/ethernet/ti/cpsw_new.c > +++ b/drivers/net/ethernet/ti/cpsw_new.c > @@ -1883,8 +1883,7 @@ static int cpsw_probe(struct platform_device *pdev) > } > cpsw->bus_freq_mhz = clk_get_rate(clk) / 1000000; > > - ss_res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - ss_regs = devm_ioremap_resource(dev, ss_res); > + ss_regs = devm_platform_get_and_ioremap_resource(pdev, 0, &ss_res); > if (IS_ERR(ss_regs)) { > ret = PTR_ERR(ss_regs); > return ret; > Reviewed-by: Grygorii Strashko -- Best regards, grygorii