All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Lance Richardson <lance.richardson@broadcom.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	Pallavi Kadam <pallavi.kadam@intel.com>,
	dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] eal: fix memory mapping for 32-bit targets
Date: Mon, 10 May 2021 17:55:21 +0200	[thread overview]
Message-ID: <4580427.4aQfPY00Ab@thomas> (raw)
In-Reply-To: <7d299b6c-80ba-cb35-f5ac-daf2a5670217@intel.com>

10/05/2021 17:31, Burakov, Anatoly:
> On 10-May-21 1:42 PM, Thomas Monjalon wrote:
> > +Cc Anatoly
> > 
> > 08/05/2021 16:27, Lance Richardson:
> >> For 32-bit targets, size_t is normally a 32-bit type and
> >> does not have sufficient range to represent 64-bit offsets
> >> that can are needed when mapping PCI addresses. Use uint64_t
> >> instead.
> >>
> >> Found when attempting to run 32-bit Linux dpdk-testpmd
> >> using VFIO driver:
> >>
> >>      EAL: pci_map_resource(): cannot map resource(63, 0xc0010000, \
> >>      0x200000, 0x20000000000): Invalid argument ((nil))
> >>
> >> Fixes: c4b89ecb64ea ("eal: introduce memory management wrappers")
> >> Cc: stable@dpdk.org
> >> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
> >> ---
> 
> LGTM, although the Fixes: tag is probably wrong because IIRC previous 
> versions did have the same issue.

What should be the right Fixes tag Anatoly?




  reply	other threads:[~2021-05-10 15:55 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-07 18:10 [dpdk-dev] [PATCH] eal: fix memory mapping for 32-bit targets Lance Richardson
2021-05-07 18:50 ` Lance Richardson
2021-05-07 18:55   ` Lance Richardson
2021-05-07 19:06 ` [dpdk-dev] [PATCH v2] " Lance Richardson
2021-05-07 20:51   ` Dmitry Kozlyuk
2021-05-07 21:35     ` Lance Richardson
2021-05-08 14:12 ` [dpdk-dev] [PATCH] " Lance Richardson
2021-05-08 14:27 ` [dpdk-dev] [PATCH v3] " Lance Richardson
2021-05-10 12:42   ` Thomas Monjalon
2021-05-10 15:31     ` Burakov, Anatoly
2021-05-10 15:55       ` Thomas Monjalon [this message]
2021-05-10 16:04         ` Lance Richardson
2021-05-11  7:55           ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2021-05-11 20:45       ` [dpdk-dev] " Thomas Monjalon
2021-05-11  8:17   ` Thomas Monjalon
2021-05-11 13:33     ` Lance Richardson
2021-05-11 14:45 ` [dpdk-dev] [PATCH v4] " Lance Richardson
2021-05-11 15:56   ` Lance Richardson
2021-05-11 16:08     ` Dmitry Kozlyuk
2021-05-11 20:45       ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4580427.4aQfPY00Ab@thomas \
    --to=thomas@monjalon.net \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=lance.richardson@broadcom.com \
    --cc=navasile@linux.microsoft.com \
    --cc=pallavi.kadam@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.