From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754986AbeDWL7b (ORCPT ); Mon, 23 Apr 2018 07:59:31 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:52086 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754746AbeDWL73 (ORCPT ); Mon, 23 Apr 2018 07:59:29 -0400 From: Laurent Pinchart To: jacopo mondi Cc: Peter Rosin , Jacopo Mondi , architt@codeaurora.org, a.hajda@samsung.com, airlied@linux.ie, daniel@ffwll.ch, linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 14:59:40 +0300 Message-ID: <4581508.09qg8X0yyC@avalon> Organization: Ideas on Board Oy In-Reply-To: <20180423073504.GN4235@w540> References: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> <17d6f6b0-e657-4a5f-63a6-572cdf062bd3@axentia.se> <20180423073504.GN4235@w540> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Monday, 23 April 2018 10:35:04 EEST jacopo mondi wrote: > On Sun, Apr 22, 2018 at 10:02:41PM +0200, Peter Rosin wrote: > > On 2018-04-19 11:31, Jacopo Mondi wrote: > >> The THC63LVD1024 LVDS to RGB bridge supports two different input mapping > >> modes, selectable by means of an external pin. > >> > >> Describe the LVDS mode map through a newly defined mandatory property in > >> device tree bindings. > >> > >> Signed-off-by: Jacopo Mondi > >> --- > >> > >> .../devicetree/bindings/display/bridge/thine,thc63lvd1024.txt | 3 +++ > >> 1 file changed, 3 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> index 37f0c04..0937595 100644 > >> --- > >> a/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> +++ > >> b/Documentation/devicetree/bindings/display/bridge/thine,thc63lvd1024.txt > >> @@ -12,6 +12,8 @@ Required properties: > >> - compatible: Shall be "thine,thc63lvd1024" > >> - vcc-supply: Power supply for TTL output, TTL CLOCKOUT signal, LVDS > >> input, > >> PPL and digital circuitry > >> > >> +- thine,map: LVDS mapping mode selection signal, pin name "MAP". Shall > >> be <1> > >> + for mapping mode 1, <0> for mapping mode 2 > > > > Since the MAP pin is an input pin, I would expect there to be an optional > > gpio specifier like thine,map-gpios so that the driver can set it > > according to the value given in thine,map in case the HW has a line from > > some gpio output to the MAP pin (instead of hardwired hi/low which seem > > to be your thinking). > > I see... As the only use case I had has the pin tied to vcc, I > thought about making it a binary property, and I wonder in how many > cases the chip 'MAP' pin would actually be GPIO controlled input and > not an hardwired one instead. I don't see the LVDS mapping mode to be > changed at runtime, but you are right, who knows.... > > Do you think we can add an options 'thine,map-gpios' property along > to the proposed ones? If the MAP pin is connected to an SoC-controlled GPIO for a given platform then we will likely need a thine,map-gpios property to control the pin. I think we can leave it out for now and add it later if the need arises. The thine,map property serves a different purpose, it indicates the level of the MAP pin for platforms where the pin is hardwired. If we later introduce a thine,map-gpios property it should be mutually exclusive with the thine,map property. The level of the MAP pin should be then software-controlled, not set through DT. > >> Optional properties: > >> - powerdown-gpios: Power down GPIO signal, pin name "/PDWN". Active low > >> > >> @@ -36,6 +38,7 @@ Example: > >> vcc-supply = <®_lvds_vcc>; > >> powerdown-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>; > >> + thine,map = <1>; > >> > >> ports { > >> #address-cells = <1>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/8] dt-bindings: display: bridge: thc63lvd1024: Add lvds map property Date: Mon, 23 Apr 2018 14:59:40 +0300 Message-ID: <4581508.09qg8X0yyC@avalon> References: <1524130269-32688-1-git-send-email-jacopo+renesas@jmondi.org> <17d6f6b0-e657-4a5f-63a6-572cdf062bd3@axentia.se> <20180423073504.GN4235@w540> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180423073504.GN4235@w540> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: jacopo mondi Cc: devicetree@vger.kernel.org, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Jacopo Mondi , Peter Rosin , linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgSmFjb3BvLAoKT24gTW9uZGF5LCAyMyBBcHJpbCAyMDE4IDEwOjM1OjA0IEVFU1QgamFjb3Bv IG1vbmRpIHdyb3RlOgo+IE9uIFN1biwgQXByIDIyLCAyMDE4IGF0IDEwOjAyOjQxUE0gKzAyMDAs IFBldGVyIFJvc2luIHdyb3RlOgo+ID4gT24gMjAxOC0wNC0xOSAxMTozMSwgSmFjb3BvIE1vbmRp IHdyb3RlOgo+ID4+IFRoZSBUSEM2M0xWRDEwMjQgTFZEUyB0byBSR0IgYnJpZGdlIHN1cHBvcnRz IHR3byBkaWZmZXJlbnQgaW5wdXQgbWFwcGluZwo+ID4+IG1vZGVzLCBzZWxlY3RhYmxlIGJ5IG1l YW5zIG9mIGFuIGV4dGVybmFsIHBpbi4KPiA+PiAKPiA+PiBEZXNjcmliZSB0aGUgTFZEUyBtb2Rl IG1hcCB0aHJvdWdoIGEgbmV3bHkgZGVmaW5lZCBtYW5kYXRvcnkgcHJvcGVydHkgaW4KPiA+PiBk ZXZpY2UgdHJlZSBiaW5kaW5ncy4KPiA+PiAKPiA+PiBTaWduZWQtb2ZmLWJ5OiBKYWNvcG8gTW9u ZGkgPGphY29wbytyZW5lc2FzQGptb25kaS5vcmc+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gIC4uLi9k ZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL3RoaW5lLHRoYzYzbHZkMTAyNC50eHQg ICAgfCAzICsrKwo+ID4+ICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCj4gPj4gCj4g Pj4gZGlmZiAtLWdpdAo+ID4+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rp c3BsYXkvYnJpZGdlL3RoaW5lLHRoYzYzbHZkMTAyNC50eHQKPiA+PiBiL0RvY3VtZW50YXRpb24v ZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2ZDEwMjQudHh0 Cj4gPj4gaW5kZXggMzdmMGMwNC4uMDkzNzU5NSAxMDA2NDQKPiA+PiAtLS0KPiA+PiBhL0RvY3Vt ZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L2JyaWRnZS90aGluZSx0aGM2M2x2 ZDEwMjQudHh0Cj4gPj4gKysrCj4gPj4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvZGlzcGxheS9icmlkZ2UvdGhpbmUsdGhjNjNsdmQxMDI0LnR4dAo+ID4+IEBAIC0xMiw2ICsx Miw4IEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6Cj4gPj4gIC0gY29tcGF0aWJsZTogU2hhbGwgYmUg InRoaW5lLHRoYzYzbHZkMTAyNCIKPiA+PiAgLSB2Y2Mtc3VwcGx5OiBQb3dlciBzdXBwbHkgZm9y IFRUTCBvdXRwdXQsIFRUTCBDTE9DS09VVCBzaWduYWwsIExWRFMKPiA+PiAgaW5wdXQsCj4gPj4g ICAgUFBMIGFuZCBkaWdpdGFsIGNpcmN1aXRyeQo+ID4+IAo+ID4+ICstIHRoaW5lLG1hcDogTFZE UyBtYXBwaW5nIG1vZGUgc2VsZWN0aW9uIHNpZ25hbCwgcGluIG5hbWUgIk1BUCIuIFNoYWxsCj4g Pj4gYmUgPDE+Cj4gPj4gKyAgZm9yIG1hcHBpbmcgbW9kZSAxLCA8MD4gZm9yIG1hcHBpbmcgbW9k ZSAyCj4gPiAKPiA+IFNpbmNlIHRoZSBNQVAgcGluIGlzIGFuIGlucHV0IHBpbiwgSSB3b3VsZCBl eHBlY3QgdGhlcmUgdG8gYmUgYW4gb3B0aW9uYWwKPiA+IGdwaW8gc3BlY2lmaWVyIGxpa2UgdGhp bmUsbWFwLWdwaW9zIHNvIHRoYXQgdGhlIGRyaXZlciBjYW4gc2V0IGl0Cj4gPiBhY2NvcmRpbmcg dG8gdGhlIHZhbHVlIGdpdmVuIGluIHRoaW5lLG1hcCBpbiBjYXNlIHRoZSBIVyBoYXMgYSBsaW5l IGZyb20KPiA+IHNvbWUgZ3BpbyBvdXRwdXQgdG8gdGhlIE1BUCBwaW4gKGluc3RlYWQgb2YgaGFy ZHdpcmVkIGhpL2xvdyB3aGljaCBzZWVtCj4gPiB0byBiZSB5b3VyIHRoaW5raW5nKS4KPiAKPiBJ IHNlZS4uLiBBcyB0aGUgb25seSB1c2UgY2FzZSBJIGhhZCBoYXMgdGhlIHBpbiB0aWVkIHRvIHZj YywgSQo+IHRob3VnaHQgYWJvdXQgbWFraW5nIGl0IGEgYmluYXJ5IHByb3BlcnR5LCBhbmQgSSB3 b25kZXIgaW4gaG93IG1hbnkKPiBjYXNlcyB0aGUgY2hpcCAnTUFQJyBwaW4gd291bGQgYWN0dWFs bHkgYmUgR1BJTyBjb250cm9sbGVkIGlucHV0IGFuZAo+IG5vdCBhbiBoYXJkd2lyZWQgb25lIGlu c3RlYWQuIEkgZG9uJ3Qgc2VlIHRoZSBMVkRTIG1hcHBpbmcgbW9kZSB0byBiZQo+IGNoYW5nZWQg YXQgcnVudGltZSwgYnV0IHlvdSBhcmUgcmlnaHQsIHdobyBrbm93cy4uLi4KPiAKPiBEbyB5b3Ug dGhpbmsgd2UgY2FuIGFkZCBhbiBvcHRpb25zICd0aGluZSxtYXAtZ3Bpb3MnIHByb3BlcnR5IGFs b25nCj4gdG8gdGhlIHByb3Bvc2VkIG9uZXM/CgpJZiB0aGUgTUFQIHBpbiBpcyBjb25uZWN0ZWQg dG8gYW4gU29DLWNvbnRyb2xsZWQgR1BJTyBmb3IgYSBnaXZlbiBwbGF0Zm9ybSAKdGhlbiB3ZSB3 aWxsIGxpa2VseSBuZWVkIGEgdGhpbmUsbWFwLWdwaW9zIHByb3BlcnR5IHRvIGNvbnRyb2wgdGhl IHBpbi4gSSAKdGhpbmsgd2UgY2FuIGxlYXZlIGl0IG91dCBmb3Igbm93IGFuZCBhZGQgaXQgbGF0 ZXIgaWYgdGhlIG5lZWQgYXJpc2VzLgoKVGhlIHRoaW5lLG1hcCBwcm9wZXJ0eSBzZXJ2ZXMgYSBk aWZmZXJlbnQgcHVycG9zZSwgaXQgaW5kaWNhdGVzIHRoZSBsZXZlbCBvZiAKdGhlIE1BUCBwaW4g Zm9yIHBsYXRmb3JtcyB3aGVyZSB0aGUgcGluIGlzIGhhcmR3aXJlZC4gSWYgd2UgbGF0ZXIgaW50 cm9kdWNlIGEgCnRoaW5lLG1hcC1ncGlvcyBwcm9wZXJ0eSBpdCBzaG91bGQgYmUgbXV0dWFsbHkg ZXhjbHVzaXZlIHdpdGggdGhlIHRoaW5lLG1hcCAKcHJvcGVydHkuIFRoZSBsZXZlbCBvZiB0aGUg TUFQIHBpbiBzaG91bGQgYmUgdGhlbiBzb2Z0d2FyZS1jb250cm9sbGVkLCBub3Qgc2V0IAp0aHJv dWdoIERULgoKPiA+PiAgT3B0aW9uYWwgcHJvcGVydGllczoKPiA+PiAgLSBwb3dlcmRvd24tZ3Bp b3M6IFBvd2VyIGRvd24gR1BJTyBzaWduYWwsIHBpbiBuYW1lICIvUERXTiIuIEFjdGl2ZSBsb3cK PiA+PiAKPiA+PiBAQCAtMzYsNiArMzgsNyBAQCBFeGFtcGxlOgo+ID4+ICAJCXZjYy1zdXBwbHkg PSA8JnJlZ19sdmRzX3ZjYz47Cj4gPj4gIAkJcG93ZXJkb3duLWdwaW9zID0gPCZncGlvNCAxNSBH UElPX0FDVElWRV9MT1c+Owo+ID4+ICsJCXRoaW5lLG1hcCA9IDwxPjsKPiA+PiAKPiA+PiAgCQlw b3J0cyB7Cj4gPj4gIAkJCSNhZGRyZXNzLWNlbGxzID0gPDE+OwoKLS0gClJlZ2FyZHMsCgpMYXVy ZW50IFBpbmNoYXJ0CgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo=