All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Juhamatti Kuusisaari <Juhamatti.Kuusisaari@coriant.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 1/2] net/pcap: physical interface MAC support
Date: Tue, 17 Apr 2018 15:12:44 +0100	[thread overview]
Message-ID: <45878138-737a-1aca-4ff5-76ef59e2af1c@intel.com> (raw)
In-Reply-To: <1523969590-40071-1-git-send-email-juhamatti.kuusisaari@coriant.com>

On 4/17/2018 1:53 PM, Juhamatti Kuusisaari wrote:
> Support for PCAP MAC address using physical interface MAC.
> Support for getting proper link status, speed and duplex.
> 
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> ---
>  config/common_base              |  1 +
>  drivers/net/pcap/rte_eth_pcap.c | 52 ++++++++++++++++++++++++++++++++++++++++-
>  2 files changed, 52 insertions(+), 1 deletion(-)
> 
> diff --git a/config/common_base b/config/common_base
> index c2b0d91..9804585 100644
> --- a/config/common_base
> +++ b/config/common_base
> @@ -410,6 +410,7 @@ CONFIG_RTE_LIBRTE_PMD_NULL=y
>  # Compile software PMD backed by PCAP files
>  #
>  CONFIG_RTE_LIBRTE_PMD_PCAP=n
> +CONFIG_RTE_LIBRTE_PMD_PCAP_IF_MAC_SUPPORT=n

Hi Juhamatti,

Why a build time config option for this? Can we make it a runtime devarg?
Overall we are trying to reduce config options already and this seems no need to
be build time option at all.

btw, this is a little late in release cycle, so lets target this patch for next
release.

Thanks,
ferruh

  parent reply	other threads:[~2018-04-17 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-17 12:53 [PATCH v2 1/2] net/pcap: physical interface MAC support Juhamatti Kuusisaari
2018-04-17 12:53 ` [PATCH v2 2/2] " Juhamatti Kuusisaari
2018-04-17 14:12 ` Ferruh Yigit [this message]
2018-04-18  4:35   ` [PATCH v2 1/2] " Kuusisaari, Juhamatti
2018-04-18 13:44     ` Ferruh Yigit
2018-04-19  5:16       ` Kuusisaari, Juhamatti
2018-04-19 10:49         ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45878138-737a-1aca-4ff5-76ef59e2af1c@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=Juhamatti.Kuusisaari@coriant.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.