From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF43CC433F5 for ; Wed, 16 Mar 2022 07:48:50 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 419A883951; Wed, 16 Mar 2022 08:48:47 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=samsung.com header.i=@samsung.com header.b="JpRmMFms"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 5CF3C83952; Wed, 16 Mar 2022 08:48:41 +0100 (CET) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 60B5A838F5 for ; Wed, 16 Mar 2022 08:48:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=jh80.chung@samsung.com Received: from epcas1p4.samsung.com (unknown [182.195.41.48]) by mailout3.samsung.com (KnoxPortal) with ESMTP id 20220316074832epoutp03c121a7681019d5751f796c27fdf14d27~czPQW-Pmk1467014670epoutp03k for ; Wed, 16 Mar 2022 07:48:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout3.samsung.com 20220316074832epoutp03c121a7681019d5751f796c27fdf14d27~czPQW-Pmk1467014670epoutp03k DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1647416912; bh=CRgfPy580yKM8qDvcnDmth/gV+pGQSDVejHZ1aWBkX8=; h=Date:Subject:To:Cc:From:In-Reply-To:References:From; b=JpRmMFmse8gCbLPIfBKBSazZ++attVfJxB3r2h8c+v5mM7Fy44V0TM+TLOnYnGqQp 5GdpKb4K5R7wsqUHOiJj+bPhQ7JNoLwNeWc3ApkY+4YBY6+T/TsNkGyf4iFZEQfBel DHsTMtwin4IWXd/U+DktJVQ9lPaGxn65kzEmworo= Received: from epsnrtp2.localdomain (unknown [182.195.42.163]) by epcas1p2.samsung.com (KnoxPortal) with ESMTP id 20220316074832epcas1p22893fd4aaef8e4c163d770c1074f1472~czPQIoitM0836108361epcas1p2z; Wed, 16 Mar 2022 07:48:32 +0000 (GMT) Received: from epsmges1p5.samsung.com (unknown [182.195.36.135]) by epsnrtp2.localdomain (Postfix) with ESMTP id 4KJMpN33tnz4x9QM; Wed, 16 Mar 2022 07:48:28 +0000 (GMT) Received: from epcas1p1.samsung.com ( [182.195.41.45]) by epsmges1p5.samsung.com (Symantec Messaging Gateway) with SMTP id BD.BC.28648.C4691326; Wed, 16 Mar 2022 16:48:28 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas1p2.samsung.com (KnoxPortal) with ESMTPA id 20220316074827epcas1p24eab937a423fb1e8875e3e7e51019ad6~czPMMTzX31062010620epcas1p2_; Wed, 16 Mar 2022 07:48:27 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20220316074827epsmtrp1ecd92d09f41d87941821a885d7b6c0c9~czPMLGVbI1932319323epsmtrp1g; Wed, 16 Mar 2022 07:48:27 +0000 (GMT) X-AuditID: b6c32a39-003ff70000006fe8-c5-6231964c0fde Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id CD.8B.29871.B4691326; Wed, 16 Mar 2022 16:48:27 +0900 (KST) Received: from [10.113.113.235] (unknown [10.113.113.235]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20220316074827epsmtip12ef9d72bcb4abf9126da49d632aa7583~czPL54CVU1952719527epsmtip11; Wed, 16 Mar 2022 07:48:27 +0000 (GMT) Message-ID: <4591f87c-8389-ca52-a80c-64f77709b92b@samsung.com> Date: Wed, 16 Mar 2022 16:48:27 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] mmc: xenon_sdhci: remove wait_dat0 SDHCI OP Content-Language: en-US To: Tom Rini , Robert Marko Cc: Stefan Roese , peng.fan@nxp.com, stcarlso@linux.microsoft.com, U-Boot-Denx , =?UTF-8?Q?Pali_Roh=c3=a1r?= From: Jaehoon Chung In-Reply-To: <20220315122255.GX9986@bill-the-cat> Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEJsWRmVeSWpSXmKPExsWy7bCmrq7PNMMkg91/RCwW7DnNZvFj1RdW i6VXHSxOrvvAZLHs9XxWi6mTNrNbvN3bye7A7jFv1gkWj02rOtk8Xh1Yxe7xa/tRJo+zd3Yw emx8t4PJ48f3XuYA9qhsm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRb JRefAF23zBygg5QUyhJzSoFCAYnFxUr6djZF+aUlqQoZ+cUltkqpBSk5BaYFesWJucWleel6 eaklVoYGBkamQIUJ2Rl35zUxFvTxVuz5fYm1gfEoVxcjJ4eEgInE9ceXmboYuTiEBHYwSlx5 vZsRwvnEKLHu7guozDdGicnN91hhWia8m8gMYgsJ7GWU6PguDlH0nlFi76x9YEW8AnYSj860 sIPYLAKqEpNePGKBiAtKnJz5BMwWFYiQeHnkLxOILSzgIPFzTTfYUGYBcYlbT+aDxUUEPCX+ t+5kBlnALLCEUWJ6519GkASbgI7E9m/HgYo4ODgFDCV+XZOA6JWX2P52Dli9hMBcDomLLQeY Ia52kWi7sIENwhaWeHV8CzuELSXxsr+NHaKhmVFi6ZKDrBBOD6PEv4brUB3GEvuXTgbbxiyg KbF+lz5EWFFi5++5jBCb+STefe1hBSmREOCV6GgTgihRkbj0+iUTzK67T/5DlXhINF/nm8Co OAspWGYheX8WkndmIexdwMiyilEstaA4Nz212LDAFB7byfm5mxjBiVXLcgfj9Lcf9A4xMnEw HmKU4GBWEuE980I/SYg3JbGyKrUoP76oNCe1+BCjKTByJjJLiSbnA1N7Xkm8oYmlgYmZkbGJ haGZoZI476pppxOFBNITS1KzU1MLUotg+pg4OKUamOp/ftpj61KQtGr63bWL/reJOL1uvvpx /WruVbYiy15Pfrw0lm9OauI6m1dB3od0Vr67EN0eu8Qk+IxCsqWM+9zAyLZWm5zGQx2f5HlU /ZhEXy1KFi2S29r0jG2mwLr59xX1XI3uSrPc/1Fk2rUpes2kz2+5PgQk7SqYm7l+mZaexXn1 q+bTcq6ZX80/M3PF8yPiTtEfSphkeRjCLoVwXt9uNCP1oMyk+zwliya7O3vK8F6RDCn6OL+R ad2RsLlrOTe+bahcbbNRvTpce5/sr8tHD3Ha5R/rvrG3qzUjz2LS6k2xFqfrHrp+mJ0pt+P2 dzX7httqdQUzX949EM9wXNK7f4dVUdeqndm5tyK0FimxFGckGmoxFxUnAgCkHsXrNQQAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrPLMWRmVeSWpSXmKPExsWy7bCSnK73NMMkg/PPzCwW7DnNZvFj1RdW i6VXHSxOrvvAZLHs9XxWi6mTNrNbvN3bye7A7jFv1gkWj02rOtk8Xh1Yxe7xa/tRJo+zd3Yw emx8t4PJ48f3XuYA9igum5TUnMyy1CJ9uwSujLvzmhgL+ngr9vy+xNrAeJSri5GTQ0LARGLC u4nMXYxcHEICuxklWk48ZoZISEl8fjqVrYuRA8gWljh8uBii5i2jxN+rB8BqeAXsJB6daWEH sVkEVCUmvXjEAhEXlDg58wmYLSoQIdG2bApYvbCAg8TPNd1gNrOAuMStJ/OZQGwRAU+J/607 wY5gFljCKNH5YycrxLY7TBLbr98Eq2IT0JHY/u04E8hFnAKGEr+uSYCYzALqEuvnCUHMlJfY /nYO8wRGoVlIzpiFZN0shI5ZSDoWMLKsYpRMLSjOTc8tNiwwzEst1ytOzC0uzUvXS87P3cQI jiMtzR2M21d90DvEyMTBeIhRgoNZSYT3zAv9JCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8F7pO xgsJpCeWpGanphakFsFkmTg4pRqYFt50/NT44M+u6T0boxnezZ7d+jpEtUpgQ8AZpufKRr3n feZnSdv4KSUdEeL9qrPdP+BtNveOg2kp+lOOT1VbOXWTvswl/d3lyyZ2X16+L1qBbV22xAMx vo/HEgpflj9YwVN5bNl7j6nWc+eVli15z7730WbHl1aRy4Uik7QFft45YLLK8ZlxsJG5K9f/ S5M5hXODc1cc0Vkm672vt/Kd7bHpy4MOrYqTcw2wylMXfrRdh6uLraraYO+v6ycMFm+uiRJr 69ETmzibt/hyor7vNH/BGyEn5H/tTuL/Ocv4lcubvdVZ6/Ms408Ly+f8d2fceJMr+JCBeo3V BCc9/nN/V29y5z7Utn/3MdNabtOLSizFGYmGWsxFxYkA5Cdk7xIDAAA= X-CMS-MailID: 20220316074827epcas1p24eab937a423fb1e8875e3e7e51019ad6 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: SVC_REQ_APPROVE CMS-TYPE: 101P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20220311181417epcas1p4207a65f5b292a3ff7bb8e4c0092f0f18 References: <20220311181407.1930327-1-robert.marko@sartura.hr> <39424ebb-eac3-7c94-20e0-02a73fa538e1@samsung.com> <20220314131010.GY9986@bill-the-cat> <20220315122255.GX9986@bill-the-cat> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 3/15/22 21:22, Tom Rini wrote: > On Tue, Mar 15, 2022 at 10:47:57AM +0100, Robert Marko wrote: >> On Mon, Mar 14, 2022 at 2:10 PM Tom Rini wrote: >>> >>> On Mon, Mar 14, 2022 at 06:37:02PM +0900, Jaehoon Chung wrote: >>>> On 3/12/22 03:14, Robert Marko wrote: >>>>> Generic SDHCI driver received support for checking the busy status by >>>>> polling the DAT[0] level instead of waiting for the worst MMC switch time. >>>>> >>>>> Unfortunately, it appears that this does not work for Xenon controllers >>>>> despite being a part of the standard SDHCI registers and the Armada 3720 >>>>> datasheet itself telling that BIT(20) is useful for detecting the DAT[0] >>>>> busy signal. >>>>> >>>>> I have tried increasing the timeout value, but I have newer managed to >>>>> catch DAT_LEVEL bits change from 0 at all. >>>>> >>>>> This issue appears to hit most if not all SoC-s supported by Xenon driver, >>>>> at least A3720, A8040 and CN9130 have non working eMMC currently. >>>>> >>>>> So, until a better solution is found drop the wait_dat0 OP for Xenon. >>>>> I was able to only test it on A3720, but it should work for others as well. >>>>> >>>>> Fixes: 40e6f52454fc ("drivers: mmc: Add wait_dat0 support for sdhci driver") >>>>> Signed-off-by: Robert Marko >>>> >>>> Reviewed-by: Jaehoon Chung >>> >>> Since this is a regression fix, will this be in the PR with the imx fix >>> as well? Thanks! >> >> Hi Tom, >> Was this question directed at me or? > > Sorry, to Jaehoon or Peng. Applied u-boot-mmc, Thanks! Sorry for late. Best Regards, Jaehoon Chung >