From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759185AbcJYU14 (ORCPT ); Tue, 25 Oct 2016 16:27:56 -0400 Received: from mout.kundenserver.de ([212.227.126.130]:49914 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbcJYU1z (ORCPT ); Tue, 25 Oct 2016 16:27:55 -0400 From: Arnd Bergmann To: Sriram Dash Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, mathias.nyman@intel.com, gregkh@linuxfoundation.org, suresh.gupta@nxp.com, felipe.balbi@linux.intel.com, stern@rowland.harvard.edu, pku.leo@gmail.com Subject: Re: [PATCH 3/3] usb: dwc3: host: Do not use dma_coerce_mask_and_coherent Date: Tue, 25 Oct 2016 22:27:37 +0200 Message-ID: <4598901.ugkIQYLvkL@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1477392988-7253-4-git-send-email-sriram.dash@nxp.com> References: <1477392988-7253-1-git-send-email-sriram.dash@nxp.com> <1477392988-7253-4-git-send-email-sriram.dash@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:js+e8+tp5G/b4RJoQRkr0ZMgpNvBTVqNpDBGqEbe4E/noqy3gBH zvXAlMXlJJczPGyq8WgZEoLJEV9AmF8Pp4u6svgSNh6MeyAGoZGZfHJrCFG80hTRGk9pvC7 0ntMzV/vnLGIQVps1yTTcAlfyOJsqAnOmxTyO/syHmcBkqtp5TYim8Zc1ozAt413RHNr0+k qkepfFMBi+uzPC1Q75rKw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Oml8v/609Fg=:uUTWfyGpsdUO5RViAleYMS /wzZr3Ni77HO9IDEAE/jIk7/GTCGOIswPvYsQZayciYXqRRZBeznodm1HH75B+eLSPqm1BXqL BqEOmgXQy4bN+Uy+g50Y/4iuRLYy1ZYU7vzdmEkUvZ6gUj+203akeIY35C5XkTnfdXn8zxR/A Y1dUCTZFzirCCwU4F2FWPM0Y00JvBE5ofAdQhT/hrU94PQNEtNUlSSJfvA5x1DRbYQnv5P59m ee9VNQTMfVgEqmaw/9VBurLFnVbdrUmOqBTmJjuJL/T6aubXLNcfEBc0rTkV6YChc748GLppm jLU+VIriXNANnNqNP2Xevl0fkLsJLwykRQss3cX/eyEXqqWsSXDbgwuW2CWtDu1ud4wlzI9zn IYJiCLt2wIEe9/ju8A4t9rG9yMqOwi9JnR5yGTgVguOsKzagOmUm/WQ8pDOXfTKEiPriCj30L 1+UPloSiQ5k/Qzl4MkcZa2kTkXyraMmwilPC6SzS94kxiv0SDoa6otq4xDel2r0XvqxH7zEuV R6ZDPhaC/q3XyJQwDmW8rHGz5e6sygNYEwmx7E3dHoOhUZ3sWNf1xBCRudUjDQzvMeLGGfdJO /W8Tt5Xn3BbIt8powN6jmOMYAqnRcN1oP/p3Gtt8z+83cP/KAXCtfc4sXg3KuKIxyN2ZFC57s ayKzddaaKZ9RN/Tdblzh3eijST9OlKX82TOI/JX8YkVBWDeOJV33icu2WR7v0Q4sFrADNnYpJ oL2AEgi97EV4ZlF5 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday, October 25, 2016 4:26:28 PM CEST Sriram Dash wrote: > Do not use dma_coerce_mask_and_coherent for hcd. > > Signed-off-by: Arnd Bergmann The patch is good, but please follow the usual rules for submitting someone else's patch: - As the first line, have "From: Arnd Bergmann ". "git format-patch" adds this automatically if you pass that address as the "--author" argument to "git commit". - Add you "Signed-off-by" line at below mine (or any other lines) I would also suggest a more elaborate changelog text, the free-form text should explain why something is done, rather than repeat the subject: | The dma mask is correctly set up by the DT probe function, no | need to override it any more. Arnd