From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 469CFC56202 for ; Sun, 15 Nov 2020 13:05:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0B072244C for ; Sun, 15 Nov 2020 13:05:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727088AbgKONFq (ORCPT ); Sun, 15 Nov 2020 08:05:46 -0500 Received: from m9785.mail.qiye.163.com ([220.181.97.85]:40758 "EHLO m9785.mail.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbgKONFp (ORCPT ); Sun, 15 Nov 2020 08:05:45 -0500 Received: from [192.168.1.8] (unknown [116.237.150.27]) by m9785.mail.qiye.163.com (Hmail) with ESMTPA id 920B75C17F2; Sun, 15 Nov 2020 21:05:42 +0800 (CST) Subject: Re: [PATCH v10 net-next 3/3] net/sched: act_frag: add implict packet fragment support. To: Cong Wang Cc: Jakub Kicinski , Marcelo Ricardo Leitner , Vlad Buslov , Linux Kernel Network Developers References: <1605151497-29986-1-git-send-email-wenxu@ucloud.cn> <1605151497-29986-4-git-send-email-wenxu@ucloud.cn> From: wenxu Message-ID: <459a1453-8026-cca1-fb7c-ded0890992cf@ucloud.cn> Date: Sun, 15 Nov 2020 21:05:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSUI3V1ktWUFJV1kPCR oVCBIfWUFZTUlKSBhKQhgaHhkfVkpNS05PT05OT0lDS0JVGRETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Myo6ORw5Az0zCD4rCTISOk8J HhoKFBJVSlVKTUtOT09OTk9JQk5NVTMWGhIXVQweFQMOOw4YFxQOH1UYFUVZV1kSC1lBWUpKTVVJ SExVSk5LVUlMWVdZCAFZQUlMSk43Bg++ X-HM-Tid: 0a75cc02e3662087kuqy920b75c17f2 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 在 2020/11/15 2:05, Cong Wang 写道: > On Wed, Nov 11, 2020 at 9:44 PM wrote: >> diff --git a/net/sched/act_frag.c b/net/sched/act_frag.c >> new file mode 100644 >> index 0000000..3a7ab92 >> --- /dev/null >> +++ b/net/sched/act_frag.c > It is kinda confusing to see this is a module. It provides some > wrappers and hooks the dev_xmit_queue(), it belongs more to > the core tc code than any modularized code. How about putting > this into net/sched/sch_generic.c? > > Thanks. All the operations in the act_frag  are single L3 action. So we put in a single module. to keep it as isolated/contained as possible Maybe put this in a single file is better than a module? Buildin in the tc core code or not. Enable this feature in Kconifg with NET_ACT_FRAG? +config NET_ACT_FRAG + bool "Packet fragmentation" + depends on NET_CLS_ACT + help + Say Y here to allow fragmenting big packets when outputting + with the mirred action. + + If unsure, say N. >