From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
peterz@infradead.org, jolsa@redhat.com, maddy@linux.vnet.ibm.com
Cc: Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
acme@kernel.org
Subject: Re: [PATCH 2/2] powerpc/perf: Fix mmcra corruption by bhrb_filter
Date: Sat, 25 May 2019 10:54:47 +1000 (AEST) [thread overview]
Message-ID: <459lBb45HVz9sB8@ozlabs.org> (raw)
In-Reply-To: <20190511024217.4013-2-ravi.bangoria@linux.ibm.com>
On Sat, 2019-05-11 at 02:42:17 UTC, Ravi Bangoria wrote:
> Consider a scenario where user creates two events:
>
> 1st event:
> attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;
> attr.branch_sample_type = PERF_SAMPLE_BRANCH_ANY;
> fd = perf_event_open(attr, 0, 1, -1, 0);
>
> This sets cpuhw->bhrb_filter to 0 and returns valid fd.
>
> 2nd event:
> attr.sample_type |= PERF_SAMPLE_BRANCH_STACK;
> attr.branch_sample_type = PERF_SAMPLE_BRANCH_CALL;
> fd = perf_event_open(attr, 0, 1, -1, 0);
>
> It overrides cpuhw->bhrb_filter to -1 and returns with error.
>
> Now if power_pmu_enable() gets called by any path other than
> power_pmu_add(), ppmu->config_bhrb(-1) will set mmcra to -1.
>
> Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.ibm.com>
> Reviewed-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Applied to powerpc fixes, thanks.
https://git.kernel.org/powerpc/c/3202e35ec1c8fc19cea24253ff83edf7
cheers
next prev parent reply other threads:[~2019-05-25 0:54 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-11 2:42 [PATCH 1/2] perf ioctl: Add check for the sample_period value Ravi Bangoria
2019-05-11 2:42 ` Ravi Bangoria
2019-05-11 2:42 ` [PATCH 2/2] powerpc/perf: Fix mmcra corruption by bhrb_filter Ravi Bangoria
2019-05-11 2:42 ` Ravi Bangoria
2019-05-11 2:47 ` Ravi Bangoria
2019-05-11 2:47 ` Ravi Bangoria
2019-05-22 5:01 ` Madhavan Srinivasan
2019-05-22 5:01 ` Madhavan Srinivasan
2019-05-25 0:54 ` Michael Ellerman [this message]
2019-05-13 7:42 ` [PATCH 1/2] perf ioctl: Add check for the sample_period value Peter Zijlstra
2019-05-13 7:42 ` Peter Zijlstra
2019-05-13 8:56 ` Peter Zijlstra
2019-05-13 8:56 ` Peter Zijlstra
2019-05-13 10:07 ` Ravi Bangoria
2019-05-13 10:07 ` Ravi Bangoria
2019-05-28 9:50 ` Michael Ellerman
2019-05-28 9:50 ` Michael Ellerman
2019-06-04 4:29 ` [PATCH v2] " Ravi Bangoria
2019-06-04 4:29 ` Ravi Bangoria
2019-06-17 8:38 ` Ravi Bangoria
2019-06-17 8:38 ` Ravi Bangoria
2019-06-18 12:28 ` Michael Ellerman
2019-06-18 12:28 ` Michael Ellerman
2019-06-25 8:19 ` [tip:perf/urgent] perf/ioctl: " tip-bot for Ravi Bangoria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459lBb45HVz9sB8@ozlabs.org \
--to=patch-notifications@ellerman.id.au \
--cc=acme@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.