All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charles Hardin <ckhardin@exablox.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/xfsprogs: install in the same location as e2fsprogs
Date: Thu, 9 Jun 2016 13:58:38 -0700	[thread overview]
Message-ID: <45AB37CC-F067-411E-AF46-EF448E6B073F@exablox.com> (raw)
In-Reply-To: <20160609220905.41f050b5@free-electrons.com>

Sorry, there was a better submission sent which is basically make xfsprogs match the e2fsprogs which go in /usr/sbin.

I just found that highly annoying not see mkfs.ext in the same directory.

Sent from my iPhone

> On Jun 9, 2016, at 1:09 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
> 
> Hello,
> 
>> On Wed, 25 May 2016 23:11:10 +0200, Thomas Petazzoni wrote:
>> 
>>> On Tue, 24 May 2016 06:31:16 -0700, Charles Hardin wrote:
>>> The configure script hard codes "/sbin" for installation which
>>> installs the XFS tools in a different location then the e2fsprogs.
>>> 
>>> This is just a cosmetic patch so all the tools end up in "/usr/sbin"
>>> for consistency.
>>> 
>>> Signed-off-by: Charles Hardin <ckhardin@exablox.com>  
>> 
>> What is the motivation for this change? If the upstream xfsprogs
>> developers think it should be installed in /sbin, why should we change
>> it?
>> 
>> In any case, the patch itself needs a description + your Signed-off-by
>> line. Also, it should be submitted to the upstream xfsprogs developers
>> to see if they might accept it. Otherwise I think we would prefer to
>> keep the existing behavior.
> 
> Since there was no reply to my questions, I've marked this patch as
> "Rejected" in our patch tracking system. Do not hesitate to resend an
> updated version that takes into account the comments and that provides
> a more detailed justification.
> 
> Thanks for your contribution!
> 
> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com

      reply	other threads:[~2016-06-09 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-24 13:31 [Buildroot] [PATCH 1/1] package/xfsprogs: install in the same location as e2fsprogs Charles Hardin
2016-05-25 21:11 ` Thomas Petazzoni
2016-06-09 20:09   ` Thomas Petazzoni
2016-06-09 20:58     ` Charles Hardin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45AB37CC-F067-411E-AF46-EF448E6B073F@exablox.com \
    --to=ckhardin@exablox.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.