All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix compile warning caused by ignoring __must_check results
Date: Tue, 23 Jan 2007 02:07:05 +0900	[thread overview]
Message-ID: <45B4EF39.2010006@gmail.com> (raw)
In-Reply-To: <20070122112945.772a1c40@localhost.localdomain>

Alan wrote:
> On Sat, 20 Jan 2007 14:23:29 +0900
> Tejun Heo <htejun@gmail.com> wrote:
> 
>> Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which
>> are caused by throwing away return values marked with __must_check.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> NAK NAK NAK NAK NAK NAK
> 
> As was previously discussed the bug is the bogus __must_check on
> pci_set_mwi. That __must_check should be removed and that was also the
> decision before but nothing happened. Please therefore get the pci header
> fixed.

That works for me too.  I'll drop pci_set_mwi() part.

Thanks.

-- 
tejun

  reply	other threads:[~2007-01-22 17:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-20  5:23 [PATCH] libata: fix compile warning caused by ignoring __must_check results Tejun Heo
2007-01-22 11:29 ` Alan
2007-01-22 17:07   ` Tejun Heo [this message]
2007-01-20  6:45 Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45B4EF39.2010006@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.