Hi, > * blktools: I'm not sure if this approach will be necessary. Brendan Cully > is adding support for pulling kernel image metadata into xend early during > domain creation. We can include target arch as part of that metadata and > then plumb that into the BlkifController to set the protocol automatically. > Unless there are other reasons to want to manually specify the protocol then > we are probably better to wait for the 'proper' solution. I don't mind, as noted in the patch that is just the easiest way I've found and most likely not the best one. Just drop it. > * blkback: You didn't sign off, and the changeset comment is stale (still > refers to v1/v2 protocols for example). Also in a couple of places (the > blkif_mmap functions in both blkback and blktap) you switch on blkif > protocol with cases 1 and 2, rather than using the enumeration names. That > looks a bit dodgy to me -- did you miss updating them? Yep, thanks for spotting these. Fixed version attached. Also changed the blk_protocol to enum, so the compiler will warn on such bugs in the future. cheers, Gerd -- Gerd Hoffmann