All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP
Date: Fri, 26 Jan 2007 15:49:47 -0600	[thread overview]
Message-ID: <45BA777B.303@freescale.com> (raw)
In-Reply-To: <20070126214631.BF238353CC1@atlas.denx.de>

Wolfgang Denk wrote:
> In message <45BA718E.1070005@freescale.com> you wrote:
>> The patch currently does this:
>>
>> MPC8349ITX_config \
>> MPC8349ITX_LOWBOOT_config \
>> MPC8349ITXGP_config:	unconfig
>> 	@mkdir -p $(obj)include
>> 	@mkdir -p $(obj)board/mpc8349itx
>> 	@CTYPE=$(subst MPC,,$(@:_config=)); \
>> 	echo "#define CONFIG_MPC$${CTYPE}" >> $(obj)include/config.h
>> 	@if [ "$(findstring GP,$@)" ] ; then \
>> 		echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ; \
>> 	fi
>> 	@if [ "$(findstring LOWBOOT,$@)" ] ; then \
>> 		echo "TEXT_BASE = 0xFE000000" >$(obj)board/mpc8349itx/config.tmp ; \
>> 	fi
>> 	@$(MKCONFIG) -a MPC8349ITX ppc mpc83xx mpc8349itx
> 
> I would not reject such a patch. It looks resonable to me. [You could
> get rid of the CTYPE thingy which would save one line.]

How else would I do this, then?

  	echo "#define CONFIG_MPC$${CTYPE}" >> $(obj)include/config.h
                                 ^^^^^^^^^

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-01-26 21:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-17 15:09 [U-Boot-Users] [PATCH] Add support for the MPC8349E-mITX-GP timur at freescale.com
2007-01-26  1:17 ` Kim Phillips
2007-01-26  4:41   ` Timur Tabi
2007-01-26  5:57     ` Kumar Gala
2007-01-26  9:46       ` Wolfgang Denk
2007-01-26 17:19         ` Kim Phillips
2007-01-26 17:38           ` Timur Tabi
2007-01-26 21:17             ` Wolfgang Denk
2007-01-26 21:24               ` Timur Tabi
2007-01-26 21:46                 ` Wolfgang Denk
2007-01-26 21:49                   ` Timur Tabi [this message]
2007-01-27  0:37                     ` Wolfgang Denk
2007-01-29 10:07             ` Stefan Roese
2007-01-26 21:11           ` Wolfgang Denk
2007-01-26  9:42     ` Wolfgang Denk
2007-01-26 14:45       ` Timur Tabi
2007-01-26 14:58         ` Wolfgang Denk
2007-01-26 15:03           ` Timur Tabi
2007-01-26 15:37             ` Wolfgang Denk
2007-01-31 21:54 Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BA777B.303@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.