All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: Jerry Van Baren <gerald.vanbaren@smiths-aerospace.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [PATCH] Check mac-address first in fsl_soc.c
Date: Fri, 09 Feb 2007 15:51:25 -0600	[thread overview]
Message-ID: <45CCECDD.8060502@freescale.com> (raw)
In-Reply-To: <45CCE696.5070309@smiths-aerospace.com>

Jerry Van Baren wrote:

> If you want to check for common errors, add a check that the first byte 
> does not have the multicast flag set.  

Actually, I'm not checking for errors when I check for all zeros.  I'm checking 
for a situation where the property exists in the device tree, but it has not 
been initialized by U-Boot.

Some versions of U-Boot only update the local-mac-address property, but some 
device trees have both mac-address and local-mac-address in them.  In this case, 
mac-address will be all zeros, and the MAC address will be in local-mac-address.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

      reply	other threads:[~2007-02-09 21:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-09 20:02 [PATCH] Check mac-address first in fsl_soc.c Timur Tabi
2007-02-09 20:52 ` Sergei Shtylyov
2007-02-09 20:55   ` Timur Tabi
2007-02-09 20:58     ` Sergei Shtylyov
2007-02-09 21:00       ` Timur Tabi
2007-02-09 21:06         ` Kumar Gala
2007-02-09 21:09           ` Timur Tabi
2007-02-13 17:25       ` Timur Tabi
2007-02-13 17:33         ` Sergei Shtylyov
2007-02-13 17:37           ` Timur Tabi
2007-02-13 17:37         ` Kumar Gala
2007-02-13 17:45           ` Timur Tabi
2007-02-13 18:01             ` Kumar Gala
2007-02-13 18:51               ` Timur Tabi
2007-02-13 19:01                 ` Kumar Gala
2007-02-13 19:10                   ` Timur Tabi
2007-02-13 19:20                   ` Timur Tabi
2007-02-13 19:50               ` Timur Tabi
2007-02-13 21:23                 ` Timur Tabi
2007-02-13 22:14                   ` Kumar Gala
2007-02-09 21:24 ` Jerry Van Baren
2007-02-09 21:51   ` Timur Tabi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CCECDD.8060502@freescale.com \
    --to=timur@freescale.com \
    --cc=gerald.vanbaren@smiths-aerospace.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.