* current git breaks resume @ 2007-02-09 19:03 Jens Axboe 2007-02-10 9:49 ` Rafael J. Wysocki 2007-02-11 5:02 ` Len Brown 0 siblings, 2 replies; 12+ messages in thread From: Jens Axboe @ 2007-02-09 19:03 UTC (permalink / raw) To: linux-kernel Hi, Unfortunately I'm a little short on time as I'll be travelling tomorrow, but of course preparing a new kernel for the laptop is something you want to do right before leaving. So I discovered that the current (well as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) doesn't resume on my x60. 2.6.20 works fine, so something broke since then. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-09 19:03 current git breaks resume Jens Axboe @ 2007-02-10 9:49 ` Rafael J. Wysocki 2007-02-10 11:24 ` Jens Axboe 2007-02-11 5:02 ` Len Brown 1 sibling, 1 reply; 12+ messages in thread From: Rafael J. Wysocki @ 2007-02-10 9:49 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel Hi, On Friday, 9 February 2007 20:03, Jens Axboe wrote: > Hi, > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > but of course preparing a new kernel for the laptop is something you > want to do right before leaving. So I discovered that the current (well > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > doesn't resume on my x60. 2.6.20 works fine, so something broke since > then. I think the patch from http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2 is likely to help. Greetings, Rafael -- If you don't have the time to read, you don't have the time or the tools to write. - Stephen King ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-10 9:49 ` Rafael J. Wysocki @ 2007-02-10 11:24 ` Jens Axboe 2007-02-10 11:50 ` Jens Axboe 0 siblings, 1 reply; 12+ messages in thread From: Jens Axboe @ 2007-02-10 11:24 UTC (permalink / raw) To: Rafael J. Wysocki; +Cc: linux-kernel On Sat, Feb 10 2007, Rafael J. Wysocki wrote: > Hi, > > On Friday, 9 February 2007 20:03, Jens Axboe wrote: > > Hi, > > > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > but of course preparing a new kernel for the laptop is something you > > want to do right before leaving. So I discovered that the current (well > > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > doesn't resume on my x60. 2.6.20 works fine, so something broke since > > then. > > I think the patch from > > http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2 > > is likely to help. Thanks, will give it a shot. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-10 11:24 ` Jens Axboe @ 2007-02-10 11:50 ` Jens Axboe 2007-02-10 11:57 ` Rafael J. Wysocki 0 siblings, 1 reply; 12+ messages in thread From: Jens Axboe @ 2007-02-10 11:50 UTC (permalink / raw) To: Rafael J. Wysocki; +Cc: linux-kernel On Sat, Feb 10 2007, Jens Axboe wrote: > On Sat, Feb 10 2007, Rafael J. Wysocki wrote: > > Hi, > > > > On Friday, 9 February 2007 20:03, Jens Axboe wrote: > > > Hi, > > > > > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > > but of course preparing a new kernel for the laptop is something you > > > want to do right before leaving. So I discovered that the current (well > > > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > > doesn't resume on my x60. 2.6.20 works fine, so something broke since > > > then. > > > > I think the patch from > > > > http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2 > > > > is likely to help. > > Thanks, will give it a shot. Doesn't work, still hangs in the same way. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-10 11:50 ` Jens Axboe @ 2007-02-10 11:57 ` Rafael J. Wysocki 2007-02-11 3:28 ` Jens Axboe 0 siblings, 1 reply; 12+ messages in thread From: Rafael J. Wysocki @ 2007-02-10 11:57 UTC (permalink / raw) To: Jens Axboe; +Cc: linux-kernel On Saturday, 10 February 2007 12:50, Jens Axboe wrote: > On Sat, Feb 10 2007, Jens Axboe wrote: > > On Sat, Feb 10 2007, Rafael J. Wysocki wrote: > > > Hi, > > > > > > On Friday, 9 February 2007 20:03, Jens Axboe wrote: > > > > Hi, > > > > > > > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > > > but of course preparing a new kernel for the laptop is something you > > > > want to do right before leaving. So I discovered that the current (well > > > > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > > > doesn't resume on my x60. 2.6.20 works fine, so something broke since > > > > then. > > > > > > I think the patch from > > > > > > http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2 > > > > > > is likely to help. > > > > Thanks, will give it a shot. > > Doesn't work, still hangs in the same way. Well, looked promising ... Still, I suspect the ACPI changes cause the problem to happen. I've tested 2.6.20-git4 and it works on my box (HPC nx6325, x86_64). Unfortunately I have no i386 setup anywhere close to me right now. Greetings, Rafael ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-10 11:57 ` Rafael J. Wysocki @ 2007-02-11 3:28 ` Jens Axboe 0 siblings, 0 replies; 12+ messages in thread From: Jens Axboe @ 2007-02-11 3:28 UTC (permalink / raw) To: Rafael J. Wysocki; +Cc: linux-kernel On Sat, Feb 10 2007, Rafael J. Wysocki wrote: > On Saturday, 10 February 2007 12:50, Jens Axboe wrote: > > On Sat, Feb 10 2007, Jens Axboe wrote: > > > On Sat, Feb 10 2007, Rafael J. Wysocki wrote: > > > > Hi, > > > > > > > > On Friday, 9 February 2007 20:03, Jens Axboe wrote: > > > > > Hi, > > > > > > > > > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > > > > but of course preparing a new kernel for the laptop is something you > > > > > want to do right before leaving. So I discovered that the current (well > > > > > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > > > > doesn't resume on my x60. 2.6.20 works fine, so something broke since > > > > > then. > > > > > > > > I think the patch from > > > > > > > > http://marc.theaimsgroup.com/?l=linux-acpi&m=117103448629685&w=2 > > > > > > > > is likely to help. > > > > > > Thanks, will give it a shot. > > > > Doesn't work, still hangs in the same way. > > Well, looked promising ... > > Still, I suspect the ACPI changes cause the problem to happen. > > I've tested 2.6.20-git4 and it works on my box (HPC nx6325, x86_64). > Unfortunately I have no i386 setup anywhere close to me right now. When I'm on stable ground again, I'll try with pm tracing and see if that yields anything. Otherwise I'll do a bisect. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-09 19:03 current git breaks resume Jens Axboe 2007-02-10 9:49 ` Rafael J. Wysocki @ 2007-02-11 5:02 ` Len Brown 2007-02-11 14:34 ` Alexey Starikovskiy 2007-02-11 16:53 ` Jens Axboe 1 sibling, 2 replies; 12+ messages in thread From: Len Brown @ 2007-02-11 5:02 UTC (permalink / raw) To: Jens Axboe, linux-acpi; +Cc: linux-kernel On Friday 09 February 2007 14:03, Jens Axboe wrote: > Hi, > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > but of course preparing a new kernel for the laptop is something you > want to do right before leaving. So I discovered that the current (well > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > doesn't resume on my x60. 2.6.20 works fine, so something broke since > then. resume from RAM, or resume from disk? ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-11 5:02 ` Len Brown @ 2007-02-11 14:34 ` Alexey Starikovskiy 2007-02-11 16:53 ` Jens Axboe 1 sibling, 0 replies; 12+ messages in thread From: Alexey Starikovskiy @ 2007-02-11 14:34 UTC (permalink / raw) To: Len Brown; +Cc: Jens Axboe, linux-acpi, linux-kernel [-- Attachment #1: Type: text/plain, Size: 677 bytes --] Len Brown wrote: > On Friday 09 February 2007 14:03, Jens Axboe wrote: > >> Hi, >> >> Unfortunately I'm a little short on time as I'll be travelling tomorrow, >> but of course preparing a new kernel for the laptop is something you >> want to do right before leaving. So I discovered that the current (well >> as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) >> doesn't resume on my x60. 2.6.20 works fine, so something broke since >> then. >> > > resume from RAM, or resume from disk? > > Len, resume from RAM is still broken by "Disable all wakeup GPEs". My previous patch for T43 does not help, only attached one helps (revert original patch). [-- Attachment #2: fix-disable_all_wake_gpes.patch --] [-- Type: text/plain, Size: 1049 bytes --] Disable wake GPEs only once. From: Alexey Starikovskiy <alexey.y.starikovskiy@linux.intel.com> --- drivers/acpi/events/evgpe.c | 11 ----------- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/acpi/events/evgpe.c b/drivers/acpi/events/evgpe.c index dfac3ec..635ba44 100644 --- a/drivers/acpi/events/evgpe.c +++ b/drivers/acpi/events/evgpe.c @@ -636,17 +636,6 @@ acpi_ev_gpe_dispatch(struct acpi_gpe_eve } } - if (!acpi_gbl_system_awake_and_running) { - /* - * We just woke up because of a wake GPE. Disable any further GPEs - * until we are fully up and running (Only wake GPEs should be enabled - * at this time, but we just brute-force disable them all.) - * 1) We must disable this particular wake GPE so it won't fire again - * 2) We want to disable all wake GPEs, since we are now awake - */ - (void)acpi_hw_disable_all_gpes(); - } - /* * Dispatch the GPE to either an installed handler, or the control method * associated with this GPE (_Lxx or _Exx). If a handler exists, we invoke ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-11 5:02 ` Len Brown 2007-02-11 14:34 ` Alexey Starikovskiy @ 2007-02-11 16:53 ` Jens Axboe 2007-02-11 17:31 ` Alexey Starikovskiy 1 sibling, 1 reply; 12+ messages in thread From: Jens Axboe @ 2007-02-11 16:53 UTC (permalink / raw) To: Len Brown; +Cc: linux-acpi, linux-kernel On Sun, Feb 11 2007, Len Brown wrote: > On Friday 09 February 2007 14:03, Jens Axboe wrote: > > Hi, > > > > Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > but of course preparing a new kernel for the laptop is something you > > want to do right before leaving. So I discovered that the current (well > > as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > doesn't resume on my x60. 2.6.20 works fine, so something broke since > > then. > > resume from RAM, or resume from disk? Resume from RAM, I never use suspend-to-disk. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-11 16:53 ` Jens Axboe @ 2007-02-11 17:31 ` Alexey Starikovskiy 2007-02-11 17:36 ` Jens Axboe 0 siblings, 1 reply; 12+ messages in thread From: Alexey Starikovskiy @ 2007-02-11 17:31 UTC (permalink / raw) To: Jens Axboe; +Cc: Len Brown, linux-acpi, linux-kernel Jens Axboe wrote: > On Sun, Feb 11 2007, Len Brown wrote: > >> On Friday 09 February 2007 14:03, Jens Axboe wrote: >> >>> Hi, >>> >>> Unfortunately I'm a little short on time as I'll be travelling tomorrow, >>> but of course preparing a new kernel for the laptop is something you >>> want to do right before leaving. So I discovered that the current (well >>> as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) >>> doesn't resume on my x60. 2.6.20 works fine, so something broke since >>> then. >>> >> resume from RAM, or resume from disk? >> > > Resume from RAM, I never use suspend-to-disk. > > Jens, Could you please test the patch I've sent? Thanks, Alex. ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-11 17:31 ` Alexey Starikovskiy @ 2007-02-11 17:36 ` Jens Axboe 2007-02-11 17:56 ` Jens Axboe 0 siblings, 1 reply; 12+ messages in thread From: Jens Axboe @ 2007-02-11 17:36 UTC (permalink / raw) To: Alexey Starikovskiy; +Cc: Len Brown, linux-acpi, linux-kernel On Sun, Feb 11 2007, Alexey Starikovskiy wrote: > Jens Axboe wrote: > >On Sun, Feb 11 2007, Len Brown wrote: > > > >>On Friday 09 February 2007 14:03, Jens Axboe wrote: > >> > >>>Hi, > >>> > >>>Unfortunately I'm a little short on time as I'll be travelling tomorrow, > >>>but of course preparing a new kernel for the laptop is something you > >>>want to do right before leaving. So I discovered that the current (well > >>>as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > >>>doesn't resume on my x60. 2.6.20 works fine, so something broke since > >>>then. > >>> > >>resume from RAM, or resume from disk? > >> > > > >Resume from RAM, I never use suspend-to-disk. > > > > > Jens, > Could you please test the patch I've sent? Just saw it, will do. -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: current git breaks resume 2007-02-11 17:36 ` Jens Axboe @ 2007-02-11 17:56 ` Jens Axboe 0 siblings, 0 replies; 12+ messages in thread From: Jens Axboe @ 2007-02-11 17:56 UTC (permalink / raw) To: Alexey Starikovskiy; +Cc: Len Brown, linux-acpi, linux-kernel On Sun, Feb 11 2007, Jens Axboe wrote: > On Sun, Feb 11 2007, Alexey Starikovskiy wrote: > > Jens Axboe wrote: > > >On Sun, Feb 11 2007, Len Brown wrote: > > > > > >>On Friday 09 February 2007 14:03, Jens Axboe wrote: > > >> > > >>>Hi, > > >>> > > >>>Unfortunately I'm a little short on time as I'll be travelling tomorrow, > > >>>but of course preparing a new kernel for the laptop is something you > > >>>want to do right before leaving. So I discovered that the current (well > > >>>as of yesterday, HEAD is 5986a2ec35836a878350c54af4bd91b1de6abc59) > > >>>doesn't resume on my x60. 2.6.20 works fine, so something broke since > > >>>then. > > >>> > > >>resume from RAM, or resume from disk? > > >> > > > > > >Resume from RAM, I never use suspend-to-disk. > > > > > > > > Jens, > > Could you please test the patch I've sent? > > Just saw it, will do. With that patch applied, current git works as expected. Thanks! -- Jens Axboe ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2007-02-11 17:56 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2007-02-09 19:03 current git breaks resume Jens Axboe 2007-02-10 9:49 ` Rafael J. Wysocki 2007-02-10 11:24 ` Jens Axboe 2007-02-10 11:50 ` Jens Axboe 2007-02-10 11:57 ` Rafael J. Wysocki 2007-02-11 3:28 ` Jens Axboe 2007-02-11 5:02 ` Len Brown 2007-02-11 14:34 ` Alexey Starikovskiy 2007-02-11 16:53 ` Jens Axboe 2007-02-11 17:31 ` Alexey Starikovskiy 2007-02-11 17:36 ` Jens Axboe 2007-02-11 17:56 ` Jens Axboe
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.