All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prarit Bhargava <prarit@redhat.com>
To: ia64 Fedora Core Development <fedora-ia64-list@redhat.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [Fedora-ia64-list] The 5th bar of ide controller at legacy mode
Date: Mon, 12 Feb 2007 07:22:04 -0500	[thread overview]
Message-ID: <45D05BEC.6030502@redhat.com> (raw)
In-Reply-To: <1171244453.15989.389.camel@ymzhang>


Zhang, Yanmin wrote:
> Hi,
>
> I am using Fedora Core 7 Test1 on my ia64 box and run into an issue
> about my cd drive. FC6 works well on my machine, but FC7Test1 couldn't
> recognise the cd drive.
>
>   

Just an FYI for everyone on linux-ide ... F7 (not FC anymore ;) )
maps upstream. I think there is a bit of a delta ATM but it's small.

> I checked it and found FC6 uses ide-cd/piix drivers, while FC7Test1
> replaces them with ata/ata_piix drivers. When drivers call pci_enable_device,
> the calling will fail if the bar resource is incorrect.
>   

ide-cd/piix drivers are going to be deprecated some time in the future.
Fedora has already made the switch to ata/ata_piix in order to test the
"new" driver and catch any potential issues with BIOS, ACPI tables,
etc..
> The bar resource of the ide controller on my tiger machine:
> [root@tigerF 0000:00:1f.1]# pwd
> /sys/devices/pci0000:00/0000:00:1f.1
> [root@tigerF 0000:00:1f.1]# cat resource
> 0x00000000000001f0 0x00000000000001f7 0x0000000000000110
> 0x00000000000003f6 0x00000000000003f6 0x0000000000000110
> 0x0000000000000170 0x0000000000000177 0x0000000000000110
> 0x0000000000000376 0x0000000000000376 0x0000000000000110
> 0x0000000000001000 0x000000000000100f 0x0000000000000101
> 0x0000000000000000 0x00000000000003ff 0x0000000000000200
> 0x0000000000000000 0x0000000000000000 0x0000000000000000
>
> The 5th bar is incorrect. BIOS initiates ide controllers.
>   

Your BIOS is broken.

> So my question is: should ata/ata_piix also need to recall pci_enable_device_bars
> with parameter bars=(1<<4) if pci_enable_device fails like what ide-cd/piix does?
>   

No, ata/ata_piix should not call pci_enable_device, IMO.

You're hitting this issue due to a broken BIOS -- if that BIOS is fixed then
the system would boot properly.

IMO, the kernel cannot take care of EVERY single case of a broken BIOS.

Another better approach is to make a Fedora-only
drivers/pci/quirks.c patch to catch this issue ... but I'm not going to
guarantee its acceptance into the Fedora tree.

P.

  reply	other threads:[~2007-02-12 12:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-12  1:40 Zhang, Yanmin
2007-02-12 12:22 ` Prarit Bhargava [this message]
2007-02-12 12:56 ` Alan
2007-02-12 18:18   ` [Fedora-ia64-list] " Luck, Tony
2007-02-12 18:24     ` Prarit Bhargava
2007-02-12 19:24     ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D05BEC.6030502@redhat.com \
    --to=prarit@redhat.com \
    --cc=fedora-ia64-list@redhat.com \
    --cc=linux-ide@vger.kernel.org \
    --subject='Re: [Fedora-ia64-list] The 5th bar of ide controller at legacy mode' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.