From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [kvm-commits] kvm: revert r4386 (rev 4422) Date: Wed, 14 Feb 2007 14:31:09 +0100 Message-ID: <45D30F1D.6060803@bull.net> References: <20070214075713.2D6DC250354@il.qumranet.com> <20070214080623.GD461@rhun.ibm.com> <45D2C78A.4060203@qumranet.com> <20070214083039.GE461@rhun.ibm.com> <45D30B79.6080807@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0472233481==" Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <45D30B79.6080807-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============0472233481== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig0628F6FF1C108659D1D4E507" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0628F6FF1C108659D1D4E507 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Muli Ben-Yehuda wrote: >> On Wed, Feb 14, 2007 at 10:25:46AM +0200, Avi Kivity wrote: >> =20 >>> Muli Ben-Yehuda wrote: >>> =20 >>>> On Wed, Feb 14, 2007 at 09:57:13AM +0200, Avi Kivity wrote: >>>> =20 >>>> =20 >>>>> kvm: revert r4386 >>>>> >>>>> causes breakage, as well as using evil '?=3D' assignment. >>>>> =20 >>>>> =20 >>>> *sigh*, this breaks --kerneldir. >>>> >>>> The patch I resent early this morning does the right thing. >>>> =20 >>> Well, --kerneldir should be fixed without ?=3D and with testing. >>> =20 >> What's wrong with '?=3D'? >> =20 >=20 > It allows environment variables to affect the compilation. Environment variables affect compilation, try: # cd kvm-13 # make clean # ./configure --prefix=3D/usr --with-patched-kernel # export CC=3Dtoto # make make -C user make[1]: Entering directory `/home/vivierl/kvm-13/user' toto -I /usr/src/linux-2.6.20/include -MMD -MF ./.kvmctl.d -g -c -o kvm= ctl.o kvmctl.c make[1]: toto: Command not found make[1]: *** [kvmctl.o] Error 127 make[1]: Leaving directory `/home/vivierl/kvm-13/user' make: *** [user] Error 2 If you protect "KERNELDIR", perhaps you should protect "CC" too... and al= l other shell variables. IMHO, it is more flexible to allow environment to affect behaviour of com= mands : it is the aim of shell variables. Regards, Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Any sufficiently advanced technology is indistinguishable from magic." - Arthur C. Clarke --------------enig0628F6FF1C108659D1D4E507 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFF0w8i9Kffa9pFVzwRAjijAKCZfWjyARs2dA/renNz0QBZ40zKTwCeNDtg hiCub+WzaUtpnfNOSlCwREk= =dx6t -----END PGP SIGNATURE----- --------------enig0628F6FF1C108659D1D4E507-- --===============0472233481== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV --===============0472233481== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============0472233481==--