All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>,
	Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB
Date: Fri, 16 Feb 2007 08:39:33 +0000	[thread overview]
Message-ID: <45D57BD5.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C1FAA494.20DC%Keir.Fraser@cl.cam.ac.uk>

>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 16.02.07 01:00 >>>
>On 15/2/07 22:59, "Langsdorf, Mark" <mark.langsdorf@amd.com> wrote:
>
>> As part of my efforts to enable GART/IOMMU on x86_64,
>> I switch from using arch/i386/swiotlb-xen.c for the
>> SWIOTLB implementation to lib/swiotlb-xen.c for x86_64
>> processors.
>> 
>> After this patch is accepted, I'll submit the patch to
>> enable the GART/IOMMU.
>> 
>> Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com>
>
>Jan has been through the swiotlb code recently so may have an opinion on
>this patch. Using the common swiotlb code (as far as possible) for x86/64
>may make sense -- many of the nasty differences in our own swiotlb
>implementation are to deal with CONFIG_HIGHMEM which does not exist on
>x86/64.

I can't see how this can work: First, the way the change is done i386 will also
use that file (and then arch/i386/kernel/swiotlb.c should also be deleted by
the patch). Second, there's nothing Xen specific anymore in that file, not
even the contiguous region creation (the sole difference to plain 2.6.20 is
the use of virt_to_bus/bus_to_virt). I think the first patch should be really
just a move of arch/i386/kernel/swiotlb.c to lib/swiotlb-xen.c, nothing else.

Jan

  reply	other threads:[~2007-02-16  8:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 22:59 [PATCH] Use lib/swiotlb code for x86_64 SWIOTLB Langsdorf, Mark
2007-02-16  0:00 ` Keir Fraser
2007-02-16  8:39   ` Jan Beulich [this message]
2007-02-22  0:09     ` Langsdorf, Mark
2007-02-22 10:24       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D57BD5.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=mark.langsdorf@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.