All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon 'corecode' Schubert <corecode@fs.ei.tum.de>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Matthias Lederhofer <matled@gmx.net>, git@vger.kernel.org
Subject: Re: [PATCH] pager: use an environment variable for pager_in_use
Date: Fri, 16 Feb 2007 20:43:30 +0100	[thread overview]
Message-ID: <45D60962.6010605@fs.ei.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.63.0702162004590.22628@wbgn013.biozentrum.uni-wuerzburg.de>

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

Johannes Schindelin wrote:
>> Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>>> +int pager_in_use = getenv("GIT_PAGER_IN_USE");
>> test.c:3: error: initializer element is not constant
> Sorry.
> 
> Still, it feels wrong to use two system calls when you need none.

getenv() is usually no system call, but processed in userland.

However, I also always get the feeling that using environment variables within one process to communicate state seems wrong, but many old unix tools do it this way.

cheers
  simon

-- 
Serve - BSD     +++  RENT this banner advert  +++    ASCII Ribbon   /"\
Work - Mac      +++  space for low €€€ NOW!1  +++      Campaign     \ /
Party Enjoy Relax   |   http://dragonflybsd.org      Against  HTML   \
Dude 2c 2 the max   !   http://golden-apple.biz       Mail + News   / \


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

      reply	other threads:[~2007-02-16 19:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-16 15:19 [BUG] git -p status does not use colors Matthias Lederhofer
2007-02-16 15:56 ` Jeff King
2007-02-16 18:22   ` [PATCH] pager: use an environment variable for pager_in_use Matthias Lederhofer
2007-02-16 18:35     ` Johannes Schindelin
2007-02-16 18:56       ` Matthias Lederhofer
2007-02-16 19:06         ` Johannes Schindelin
2007-02-16 19:43           ` Simon 'corecode' Schubert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D60962.6010605@fs.ei.tum.de \
    --to=corecode@fs.ei.tum.de \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=matled@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.