From: Divy Le Ray <divy@chelsio.com>
To: David Miller <davem@davemloft.net>
Cc: shemminger@osdl.org, benh@kernel.crashing.org,
netdev@vger.kernel.org, ebs@ebshome.net,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] split NAPI from network device.
Date: Tue, 20 Feb 2007 23:39:55 -0800 [thread overview]
Message-ID: <45DBF74B.7070801@chelsio.com> (raw)
In-Reply-To: <20070220.213125.74747066.davem@davemloft.net>
David Miller wrote:
> From: Stephen Hemminger <shemminger@osdl.org>
> Date: Wed, 13 Dec 2006 15:46:35 -0800
>
>
>> Split off NAPI part from network device, this patch is build tested
>> only! It breaks kernel API for network devices, and only three examples
>> are fixed (skge, sky2, and tg3).
>>
>> 1. Decomposition allows different NAPI <-> network device
>> Some hardware has N devices for one IRQ, others like MSI-X
>> want multiple receive's for one device.
>>
>> 2. Cleanup locking with netpoll
>>
>> 3. Change poll callback arguements and semantics
>>
>> 4. Make softnet_data static (only in dev.c)
>>
>> Old:
>> dev->poll(dev, &budget)
>> returns 1 or 0
>> requeu if returns 1
>>
>> New:
>> napi->poll(napi, quota)
>> returns # of elements processed
>> requeue based on status
>>
>> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
>>
>
> I rebuffed this patch against current 2.6.x GIT and fixed all of
> the drivers.
>
>
Hi Dave,
I applied the patch to test the chelsio drivers.
The compilation of the forcedeth driver fails if CONFIG_FORCEDETH_NAPI
is not set.
/opt/sources/linux-2.6/drivers/net/forcedeth.c: In function `nv_nic_irq':
/opt/sources/linux-2.6/drivers/net/forcedeth.c:2866: error: structure
has no member named `weight'
/opt/sources/linux-2.6/drivers/net/forcedeth.c: In function
`nv_nic_irq_optimized':
/opt/sources/linux-2.6/drivers/net/forcedeth.c:2983: error: structure
has no member named `weight'
/opt/sources/linux-2.6/drivers/net/forcedeth.c: In function `nv_nic_irq_rx':
/opt/sources/linux-2.6/drivers/net/forcedeth.c:3177: error: structure
has no member named `weight'
The compilation of the cxgb driver also fails if CONFIG_CHELSIO_T1_NAPI
is not set, but it has nothing to do with your patch.
I'm looking into it.
Cheers,
Divy
next prev parent reply other threads:[~2007-02-21 7:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-12 5:27 [PATCH] add init_dummy_netdev() for napi only dummy intefaces Benjamin Herrenschmidt
2006-12-13 19:35 ` Stephen Hemminger
2006-12-13 20:42 ` Benjamin Herrenschmidt
2006-12-13 21:06 ` Stephen Hemminger
2006-12-13 23:46 ` [RFC] split NAPI from network device Stephen Hemminger
2006-12-14 20:01 ` Benjamin Herrenschmidt
2007-02-21 5:31 ` David Miller
2007-02-21 7:39 ` Divy Le Ray [this message]
2007-02-21 7:47 ` David Miller
2007-02-21 23:24 ` Benjamin Herrenschmidt
2007-02-22 11:18 ` David Miller
2007-02-22 12:24 ` Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DBF74B.7070801@chelsio.com \
--to=divy@chelsio.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=ebs@ebshome.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.