From: Jeff Garzik <jeff@garzik.org>
To: Robert Hancock <hancockr@shaw.ca>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] sata_nv: kill old private BMDMA helper functions
Date: Fri, 23 Feb 2007 05:37:25 -0500 [thread overview]
Message-ID: <45DEC3E5.6030004@garzik.org> (raw)
In-Reply-To: <45DBC136.9060103@shaw.ca>
Robert Hancock wrote:
> sata_nv implemented its own copies of the BMDMA helper functions for ADMA,
> since the ADMA BMDMA status registers are PIO while the other registers
> are MMIO, and this was the only way to handle this previously. Now that
> we have iomap support, the standard routines should just work, so use them.
> The only thing we need to override as far as ADMA and BMDMA is the
> post_internal_cmd callback, where we should only call ata_post_internal_cmd
> if we are in port-register mode.
>
> Signed-off-by: Robert Hancock <hancockr@shaw.ca>
applied
prev parent reply other threads:[~2007-02-23 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 3:49 [PATCH] sata_nv: kill old private BMDMA helper functions Robert Hancock
2007-02-23 10:37 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DEC3E5.6030004@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.