error modprobing

error modprobing

[richard lucassen]

Kernel: 2.6.20.1
kvm-15
AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
1G memory

After modprobing kvm-amd, the system becomes very very unstable and I
have to reboot te get things right (after modprobing kvm-amd e.g. the
ssh daemon is unaccessible)

Here's stdout from the compile session:

http://www.xaq.nl/kvm/index.html

I'm not a programmer, but if I can do some more tests, please let me
know.

R.

cc to Avi, sometimes I can't get through the list.

-- 
___________________________________________________________________
It is better to remain silent and be thought a fool, than to speak
aloud and remove all doubt.

+------------------------------------------------------------------+
| Richard Lucassen, Utrecht                                        |
| Public key and email address:                                    |
| http://www.lucassen.org/mail-pubkey.html                         |
+------------------------------------------------------------------+

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: error modprobing

[Avi Kivity]

richard lucassen wrote:
> Kernel: 2.6.20.1
> kvm-15
> AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
> 1G memory
>
> After modprobing kvm-amd, the system becomes very very unstable and I
> have to reboot te get things right (after modprobing kvm-amd e.g. the
> ssh daemon is unaccessible)
>
> Here's stdout from the compile session:
>
> http://www.xaq.nl/kvm/index.html
>   

dmesg says the modprobe failed, and then the internal filesystem used by 
kvm was not unregistered.  a subsequent read of /proc/filesystems failed.

I'll look into it.  Thanks for the report.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: error modprobing

[Andreas Hasenack]

On Monday 26 February 2007 03:39:28 Avi Kivity wrote:
> richard lucassen wrote:
> > Kernel: 2.6.20.1
> > kvm-15
> > AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
> > 1G memory
> >
> > After modprobing kvm-amd, the system becomes very very unstable and I
> > have to reboot te get things right (after modprobing kvm-amd e.g. the
> > ssh daemon is unaccessible)
> >
> > Here's stdout from the compile session:
> >
> > http://www.xaq.nl/kvm/index.html
>
> dmesg says the modprobe failed, and then the internal filesystem used by
> kvm was not unregistered.  a subsequent read of /proc/filesystems failed.
>
> I'll look into it.  Thanks for the report.


Same here with kvm-intel. I get an oops a few seconds later when doing 
something that would stat the mounted filesystems (like installing an rpm).

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: error modprobing

[Avi Kivity]

Andreas Hasenack wrote:
> On Monday 26 February 2007 03:39:28 Avi Kivity wrote:
>   
>> richard lucassen wrote:
>>     
>>> Kernel: 2.6.20.1
>>> kvm-15
>>> AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
>>> 1G memory
>>>
>>> After modprobing kvm-amd, the system becomes very very unstable and I
>>> have to reboot te get things right (after modprobing kvm-amd e.g. the
>>> ssh daemon is unaccessible)
>>>
>>> Here's stdout from the compile session:
>>>
>>> http://www.xaq.nl/kvm/index.html
>>>       
>> dmesg says the modprobe failed, and then the internal filesystem used by
>> kvm was not unregistered.  a subsequent read of /proc/filesystems failed.
>>
>> I'll look into it.  Thanks for the report.
>>     
>
>
> Same here with kvm-intel. I get an oops a few seconds later when doing 
> something that would stat the mounted filesystems (like installing an rpm).
>
>   

Looks like two separate issues:

- the kvm-15 tarball inadvertently ships kernel/*.mod.c files, which 
break the build.  Try removing these files (and kernel/*.o for good 
measure) and rebuilding.
- there's probably a missing unregister_filesystem() or a close relative 
on some error path.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: error modprobing

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 466 bytes --]

richard lucassen wrote:
> Kernel: 2.6.20.1
> kvm-15
> AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
> 1G memory
>
> After modprobing kvm-amd, the system becomes very very unstable and I
> have to reboot te get things right (after modprobing kvm-amd e.g. the
> ssh daemon is unaccessible)
>
>   

This was fixed by the attached patch.  Thanks to Richard for providing a 
machine for me to debug on.


-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: module-load-fix.patch --]
[-- Type: text/x-patch, Size: 1173 bytes --]

commit c1a8557e1da6e7d8bf8f77cb1b47c077f5c2a67d
Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Date:   Mon Feb 26 16:29:43 2007 +0200

    KVM: Fix bogus failure in kvm.ko module initialization
    
    A bogus 'return r' can cause an otherwise successful module load to fail.
    This both denies users the use of kvm, and it also denies them the use of
    their machine, as it leaves a filesystem registered with its callbacks
    pointing into now-freed module memory.
    
    Fix by returning a zero like a good module.
    
    Thanks to Richard Lucassen <mailinglists-+AO6ZX++/Fdg9hUCZPvPmw@public.gmane.org> (?) for reporting
    the problem and for providing access to a machine which exhibited it.
    
    Signed-off-by: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>

diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index e48b4d7..ca82ba3 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2540,7 +2540,7 @@ static __init int kvm_init(void)
 	bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT;
 	memset(__va(bad_page_address), 0, PAGE_SIZE);
 
-	return r;
+	return 0;
 
 out:
 	kvm_exit_debug();

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: error modprobing

[Andreas Hasenack]

On Mon, Feb 26, 2007 at 04:34:06PM +0200, Avi Kivity wrote:
> richard lucassen wrote:
> >Kernel: 2.6.20.1
> >kvm-15
> >AMD Athlon(tm) 64 X2 Dual Core Processor 3800+
> >1G memory
> >
> >After modprobing kvm-amd, the system becomes very very unstable and I
> >have to reboot te get things right (after modprobing kvm-amd e.g. the
> >ssh daemon is unaccessible)
> >
> >  
> 
> This was fixed by the attached patch.  Thanks to Richard for providing a 
> machine for me to debug on.

Problem fixed here (intel) as well (kvm-15 now works: module loads and
machine doesn't oopses).


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV