From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: error modprobing Date: Mon, 26 Feb 2007 16:34:06 +0200 Message-ID: <45E2EFDE.2000807@qumranet.com> References: <20070225221645.3adc491b.mailinglists@lucassen.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000509090700080008030004" To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Return-path: In-Reply-To: <20070225221645.3adc491b.mailinglists-+AO6ZX++/Fdg9hUCZPvPmw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------000509090700080008030004 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit richard lucassen wrote: > Kernel: 2.6.20.1 > kvm-15 > AMD Athlon(tm) 64 X2 Dual Core Processor 3800+ > 1G memory > > After modprobing kvm-amd, the system becomes very very unstable and I > have to reboot te get things right (after modprobing kvm-amd e.g. the > ssh daemon is unaccessible) > > This was fixed by the attached patch. Thanks to Richard for providing a machine for me to debug on. -- error compiling committee.c: too many arguments to function --------------000509090700080008030004 Content-Type: text/x-patch; name="module-load-fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="module-load-fix.patch" commit c1a8557e1da6e7d8bf8f77cb1b47c077f5c2a67d Author: Avi Kivity Date: Mon Feb 26 16:29:43 2007 +0200 KVM: Fix bogus failure in kvm.ko module initialization A bogus 'return r' can cause an otherwise successful module load to fail. This both denies users the use of kvm, and it also denies them the use of their machine, as it leaves a filesystem registered with its callbacks pointing into now-freed module memory. Fix by returning a zero like a good module. Thanks to Richard Lucassen (?) for reporting the problem and for providing access to a machine which exhibited it. Signed-off-by: Avi Kivity diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index e48b4d7..ca82ba3 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -2540,7 +2540,7 @@ static __init int kvm_init(void) bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT; memset(__va(bad_page_address), 0, PAGE_SIZE); - return r; + return 0; out: kvm_exit_debug(); --------------000509090700080008030004 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV --------------000509090700080008030004 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------000509090700080008030004--