All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zachary Amsden <zach@vmware.com>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Daniel Hecht <dhecht@vmware.com>,
	Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Bug in on_each_cpu?
Date: Thu, 01 Mar 2007 03:47:39 -0800	[thread overview]
Message-ID: <45E6BD5B.4030305@vmware.com> (raw)
In-Reply-To: <1172749278.10271.43.camel@localhost.localdomain>

Rusty Russell wrote:
> On Thu, 2007-03-01 at 03:34 -0800, Zachary Amsden wrote:
>   
>> What would be really, really nice would be to statically check all 
>> callsites that issue irq disables actually keep irqs disabled.  
>> Presumably, there was a reason they disabled irqs, and re-enabling them 
>> underneath their noses, even if it is to avoid a race, breaks the logic 
>> behind that reason.
>>     
>
> For the moment, how about a BUG_ON() in on_each_cpu()?
>   

Sounds quite decent.  But why does on_each_cpu need to disable 
interrupts at all?  It just calls func(), then re-enables interrupts.  
So whatever was going to happen during func() that might not be 
interrupt safe could just be done in the callee, avoiding the rather 
expensive mess of disabling and re-enabling interrupts for those cases 
where it doesn't matter.

I haven't looked at the call sites, but perhaps on_each_cpu() and 
on_each_cpu_noirq() might be an appropriate distinction.

Zach

  reply	other threads:[~2007-03-01 11:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <45E6AC1A.8050608@vmware.com>
     [not found] ` <20070301024524.c7c8ea1a.akpm@linux-foundation.org>
2007-03-01 11:34   ` Bug in on_each_cpu? Zachary Amsden
2007-03-01 11:41     ` Rusty Russell
2007-03-01 11:47       ` Zachary Amsden [this message]
2007-03-01 15:22         ` Andrew Morton
2007-03-01 20:31           ` Zachary Amsden
2007-03-02  4:46           ` Ernie Petrides
2007-03-01 15:28     ` Andrew Morton
2007-03-01 20:03       ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45E6BD5B.4030305@vmware.com \
    --to=zach@vmware.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhecht@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.