All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vignesh Raghavendra <vigneshr@ti.com>
To: "Behme Dirk (CM/ESO2)" <dirk.behme@de.bosch.com>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	<linux-mtd@lists.infradead.org>
Subject: Re: [PATCH v2] mtd: hyperbus: add Renesas RPC-IF driver
Date: Tue, 15 Sep 2020 10:57:43 +0530	[thread overview]
Message-ID: <45a1542d-d053-a571-fe0d-79bd6c2499d7@ti.com> (raw)
In-Reply-To: <663f56cb-d38c-1e38-8459-4306a6da88db@de.bosch.com>



On 9/15/20 9:37 AM, Behme Dirk (CM/ESO2) wrote:
> 
> 
> On 14.09.2020 15:09, Vignesh Raghavendra wrote:
>> Hi Sergei,
>>
>> On 5/14/20 2:13 AM, Sergei Shtylyov wrote:
>>> Add the HyperFLash driver for the Renesas RPC-IF.  It's the "front end"
>>> driver using the "back end" APIs in the main driver to talk to the real
>>> hardware.
>>>
>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
[...]
>>>
>>>
>> [...]
>>> --- /dev/null
>>> +++ linux/drivers/mtd/hyperbus/rpc-if.c
>>> @@ -0,0 +1,165 @@
>>> +// SPDX-License-Identifier: GPL-2.0
>>> +/*
>>> + * Linux driver for RPC-IF HyperFlash
>>> + *
>>> + * Copyright (C) 2019-2020 Cogent Embedded, Inc.
>>> + */
>>> +
>>> +#include <linux/err.h>
>>> +#include <linux/kernel.h>
>>> +#include <linux/module.h>
>>> +#include <linux/mtd/hyperbus.h>
>>> +#include <linux/mtd/mtd.h>
>>> +#include <linux/mux/consumer.h>
>>> +#include <linux/of.h>
>>> +#include <linux/platform_device.h>
>>> +#include <linux/types.h>
>>> +
>>> +#include <memory/renesas-rpc-if.h>
>>> +
>>> +/* FIXME: How to drop this? */
>>> +#ifndef CONFIG_MTD_CFI_BE_BYTE_SWAP
>>> +#error Enable config "Flash cmd/query data swapping (BIG_ENDIAN_BYTE)"
>>> +#endif
>>
>> select MTD_CFI_BE_BYTE_SWAP in Kconfig does not help?
> 
> 
> If I remember correctly 'select MTD_CFI_BE_BYTE_SWAP' in Kconfig doesn't
> seem to work. Therefore the FIXME. I can't remember exactly the root
> cause for that any more, but maybe it was the 'bool' type of
> MTD_CFI_BE_BYTE_SWAP?
> 

Ah, sorry MTD_CFI_BE_BYTE_SWAP is a choice and select does not work on
choice menus. how about:

> If anybody has a nice solution for that, it would be welcome :)

Does this work:

 config RPCIF_HYPERBUS
        tristate "Renesas RPC-IF HyperBus driver"
        depends on RENESAS_RPCIF
-       select MTD_CFI_ADV_OPTIONS
+       depends on MTD_CFI_BE_BYTE_SWAP || COMPILE_TEST
        help
          This option includes Renesas RPC-IF HyperFlash support.


Regards
Vignesh

[...]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2020-09-15  5:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 20:43 [PATCH v2] mtd: hyperbus: add Renesas RPC-IF driver Sergei Shtylyov
2020-05-14  8:38 ` Sergei Shtylyov
2020-09-12 19:15 ` Sergei Shtylyov
2020-09-14 13:09 ` Vignesh Raghavendra
2020-09-15  4:07   ` Behme Dirk (CM/ESO2)
2020-09-15  5:27     ` Vignesh Raghavendra [this message]
2020-09-15  9:37       ` Behme Dirk (CM/ESO2)
2020-09-16  6:10         ` Vignesh Raghavendra
2020-09-19 16:37   ` Sergei Shtylyov
2020-09-21  7:29     ` Vignesh Raghavendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45a1542d-d053-a571-fe0d-79bd6c2499d7@ti.com \
    --to=vigneshr@ti.com \
    --cc=dirk.behme@de.bosch.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=richard@nod.at \
    --cc=sergei.shtylyov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.