From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E244C433EF for ; Fri, 4 Feb 2022 13:29:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id DB58381BB0; Fri, 4 Feb 2022 13:29:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RZZamYQOCMzQ; Fri, 4 Feb 2022 13:29:48 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7367781BCF; Fri, 4 Feb 2022 13:29:47 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 54ACFC0011; Fri, 4 Feb 2022 13:29:47 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id 05F75C000B for ; Fri, 4 Feb 2022 13:29:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E79BA404DD for ; Fri, 4 Feb 2022 13:29:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0KywCXju4vdc for ; Fri, 4 Feb 2022 13:29:45 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp2.osuosl.org (Postfix) with ESMTPS id EC845403AA for ; Fri, 4 Feb 2022 13:29:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643981383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUrgC7ZPDwd9ypG7wapsAYini1Oc/WGJxsbJSS3jbuc=; b=Jc76oDHIesCM7zjVTE5y11NRHte+xvAGNMG+F44EF8lODhU6aAXKIP2Z/Cc7UZklyoJcfm JxK39UCoiSCr+/iuA40g/uJtT63g3Eb0UfkKfv/Sw1RK81zWveb22ktXOJ158hKkdfVSyI BL3i0J8W1GmIuZEBZkoYMAHggE2FmMM= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-fYsE8DpOOdqrkwArP7vuLA-1; Fri, 04 Feb 2022 08:29:42 -0500 X-MC-Unique: fYsE8DpOOdqrkwArP7vuLA-1 Received: by mail-wr1-f72.google.com with SMTP id j21-20020adfa555000000b001db55dd5a1dso2024968wrb.15 for ; Fri, 04 Feb 2022 05:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=cUrgC7ZPDwd9ypG7wapsAYini1Oc/WGJxsbJSS3jbuc=; b=vuS3bIBVGx7AL8/Sa13eHR0roEylqWjr6aBvbowWcGa/rrbMdRtcPD3YgjCHzGDKHs cXsKh5Lfb+axJZZAQ473kiArkR5wVIslIDC1sPAkR0MXbTJ+J+z+zXqBEhnvaojgyXFC +GhcdnuyissBMUztjru6tfllEOoej3rJrSI6Rz3xU8GFNxIMP+oYw8XcPor0hPk6KyAA iRZoXvCziw3HsFUWnLUg4gG7ZdCCpR87uMElaSX0aERG1+iBnrijR5apkNInMpjiDhpb ykNURikZDMy4jY1qIEQNN9rky9riIw+5e4HEriGpxULq/Un/SpCMgntEfcHvfwOT/gF0 o/MA== X-Gm-Message-State: AOAM530TXfKWehUrQJ6xouB9sjPu8npZZdSIHW52BEjhw178BYWkWImz BCFkxhqWrLrVN7cPW+kzVuGIl/t9EB8UlYGNulQMb+K7huRYPB8xcsw8dPIt631atwJ2lZwYcWM QszrGFO61RZUiF8N2bVwbicXHjDFQYg1BUcauJZncmw== X-Received: by 2002:adf:e350:: with SMTP id n16mr2434164wrj.160.1643981381362; Fri, 04 Feb 2022 05:29:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZ38bRNXgunml/7DCV21Ao0Pud0v5LzU8NDx1YgCFGcfR2VNHVJ0aIiHFBPjMEQbD3+T7JhQ== X-Received: by 2002:adf:e350:: with SMTP id n16mr2434149wrj.160.1643981381134; Fri, 04 Feb 2022 05:29:41 -0800 (PST) Received: from ?IPV6:2003:d8:2f11:9700:838c:3860:6500:5284? (p200300d82f119700838c386065005284.dip0.t-ipconnect.de. [2003:d8:2f11:9700:838c:3860:6500:5284]) by smtp.gmail.com with ESMTPSA id y6sm1461588wma.48.2022.02.04.05.29.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 05:29:40 -0800 (PST) Message-ID: <45a4987f-3a87-8c04-73a9-3ae68fafffcd@redhat.com> Date: Fri, 4 Feb 2022 14:29:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3] drivers/virtio: Enable virtio mem for ARM64 To: "Michael S. Tsirkin" References: <20220119010551.181405-1-gshan@redhat.com> <20220119022611-mutt-send-email-mst@kernel.org> <50422908-1917-bda9-ead5-40b02d57c545@redhat.com> <20220204082351-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220204082351-mutt-send-email-mst@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: Jonathan.Cameron@huawei.com, shan.gavin@gmail.com, linux-arm-kernel@lists.infradead.org, virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 04.02.22 14:24, Michael S. Tsirkin wrote: > On Wed, Jan 19, 2022 at 09:35:05AM +0100, David Hildenbrand wrote: >> On 19.01.22 08:46, Gavin Shan wrote: >>> Hi Michael, >>> >>> On 1/19/22 3:39 PM, Michael S. Tsirkin wrote: >>>> On Wed, Jan 19, 2022 at 09:05:51AM +0800, Gavin Shan wrote: >>>>> This enables virtio-mem device support by allowing to enable the >>>>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the >>>>> architecture. >>>>> >>>>> Signed-off-by: Gavin Shan >>>>> Acked-by: David Hildenbrand >>>>> Acked-by: Jonathan Cameron >>>>> Acked-by: Michael S. Tsirkin >>>>> --- >>>>> v3: Pick ack-by tags from Jonathan and Michael >>>>> --- >>>>> drivers/virtio/Kconfig | 7 ++++--- >>>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig >>>>> index 34f80b7a8a64..74c8b0c7bc33 100644 >>>>> --- a/drivers/virtio/Kconfig >>>>> +++ b/drivers/virtio/Kconfig >>>>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON >>>>> config VIRTIO_MEM >>>>> tristate "Virtio mem driver" >>>>> default m >>>>> - depends on X86_64 >>>>> + depends on X86_64 || ARM64 >>>>> depends on VIRTIO >>>>> depends on MEMORY_HOTPLUG >>>>> depends on MEMORY_HOTREMOVE >>>>> @@ -116,8 +116,9 @@ config VIRTIO_MEM >>>>> This driver provides access to virtio-mem paravirtualized memory >>>>> devices, allowing to hotplug and hotunplug memory. >>>>> >>>>> - This driver was only tested under x86-64, but should theoretically >>>>> - work on all architectures that support memory hotplug and hotremove. >>>>> + This driver was only tested under x86-64 and arm64, but should >>>>> + theoretically work on all architectures that support memory hotplug >>>>> + and hotremove. >>>>> >>>> >>>> BTW isn't there a symbol saying "memory hotplug" that we can depend on? >>>> >> >> You mean >> >> depends on MEMORY_HOTPLUG >> depends on MEMORY_HOTREMOVE >> >> We still need a manual opt-in from architectures, because devil's in the >> detail. (e.g., memblock stuff we had to adjust) > > Is there any chance of documenting some of this here? The current comment makes it > look like it's just a question of whitelisting an architecture. I can send a patch to add more details. -- Thanks, David / dhildenb _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C47A5C433F5 for ; Fri, 4 Feb 2022 13:31:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t53zC+sQXIhPVOfa6aFLNVkLiDKYilco1Uk0UkP07jU=; b=4g9SPjxa4QIV9m twnrvqpVQORIOwlZPp8bJoZKMsAcMqkkPw+JqZIyInVDBIpmG8RuQlPApcgSsFFFnnki3hsIWrGH1 eNIuplRTF/tFBXZNRtjNCRjNd9WvNW2+v2RVLYasZXGRBluwYfNoytzE5jYZ4GuUCUKy26FIQRIDH DJlVm7u3yiKob9QrRQfF97GIfhO57jKiePKBAEwUtm1qa72g1EIRMH35xPerrc8tQKNrkbv/0C3E8 wqA+vq7Q1zWy4dpla8pl/M9GJXR2zHuUratUPvwA/uQsLIfaeWXLSPiQFZ//5qqEBO6QiooS+hmXP AyGjzF6wWJlHtvo0u1zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFyes-004ODu-Dd; Fri, 04 Feb 2022 13:29:50 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nFyeo-004OCz-D4 for linux-arm-kernel@lists.infradead.org; Fri, 04 Feb 2022 13:29:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1643981383; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cUrgC7ZPDwd9ypG7wapsAYini1Oc/WGJxsbJSS3jbuc=; b=Jc76oDHIesCM7zjVTE5y11NRHte+xvAGNMG+F44EF8lODhU6aAXKIP2Z/Cc7UZklyoJcfm JxK39UCoiSCr+/iuA40g/uJtT63g3Eb0UfkKfv/Sw1RK81zWveb22ktXOJ158hKkdfVSyI BL3i0J8W1GmIuZEBZkoYMAHggE2FmMM= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-Tn2810V0MT-b1BqclQi4FA-1; Fri, 04 Feb 2022 08:29:42 -0500 X-MC-Unique: Tn2810V0MT-b1BqclQi4FA-1 Received: by mail-wr1-f71.google.com with SMTP id g6-20020adfbc86000000b001a2d62be244so2008701wrh.23 for ; Fri, 04 Feb 2022 05:29:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=cUrgC7ZPDwd9ypG7wapsAYini1Oc/WGJxsbJSS3jbuc=; b=L6hQzDphRWIDl5ofI0P97EdifIqsD79DhoE/8ZnHWnIckGrMTaBgs5gmXsQBQWBpvX 8sDUeNFQ7XP04IldfMf57V8SOGXN/t1rE+kz6K/Zyn4BXwmgCW09dbeINrJxmeYntARm KYqigM9ryrFfOsLvn6klirra+uqyCPUV6tlBpNYFR2F7lVRtiPLLk6JuPlNEtPtPoSu1 RdRKPZEqcSwGeB75MtL/svpXPY62VuJ743N/nc1LDD1sUCj831z/fLOV7YyZnYSAUwMY K2o5fvf/i875h9+LRxCoILbRdiMKobz5kJHv0OcHxbTYRcOXxtasec9BtKXmjl0DiFHO 9fZA== X-Gm-Message-State: AOAM5334iZzV+eo3CJI2SAkac8WgdM8Q1XXcKhoWOfTemoCGAq/73Ebp 99soRe5ykA02HKOpL3OoaOsFbM3gFcoBge1dy6aqwB/YEI/8Q4NrgGUDc+KZhLOCobYV0zBoqx3 9daujqog3NiJTdR/9lYJJZaKCi383YkLemNc= X-Received: by 2002:adf:e350:: with SMTP id n16mr2434159wrj.160.1643981381357; Fri, 04 Feb 2022 05:29:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJxZ38bRNXgunml/7DCV21Ao0Pud0v5LzU8NDx1YgCFGcfR2VNHVJ0aIiHFBPjMEQbD3+T7JhQ== X-Received: by 2002:adf:e350:: with SMTP id n16mr2434149wrj.160.1643981381134; Fri, 04 Feb 2022 05:29:41 -0800 (PST) Received: from ?IPV6:2003:d8:2f11:9700:838c:3860:6500:5284? (p200300d82f119700838c386065005284.dip0.t-ipconnect.de. [2003:d8:2f11:9700:838c:3860:6500:5284]) by smtp.gmail.com with ESMTPSA id y6sm1461588wma.48.2022.02.04.05.29.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 05:29:40 -0800 (PST) Message-ID: <45a4987f-3a87-8c04-73a9-3ae68fafffcd@redhat.com> Date: Fri, 4 Feb 2022 14:29:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH v3] drivers/virtio: Enable virtio mem for ARM64 To: "Michael S. Tsirkin" Cc: Gavin Shan , virtualization@lists.linux-foundation.org, linux-arm-kernel@lists.infradead.org, Jonathan.Cameron@huawei.com, shan.gavin@gmail.com References: <20220119010551.181405-1-gshan@redhat.com> <20220119022611-mutt-send-email-mst@kernel.org> <50422908-1917-bda9-ead5-40b02d57c545@redhat.com> <20220204082351-mutt-send-email-mst@kernel.org> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220204082351-mutt-send-email-mst@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_052946_575364_DC0E7544 X-CRM114-Status: GOOD ( 19.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04.02.22 14:24, Michael S. Tsirkin wrote: > On Wed, Jan 19, 2022 at 09:35:05AM +0100, David Hildenbrand wrote: >> On 19.01.22 08:46, Gavin Shan wrote: >>> Hi Michael, >>> >>> On 1/19/22 3:39 PM, Michael S. Tsirkin wrote: >>>> On Wed, Jan 19, 2022 at 09:05:51AM +0800, Gavin Shan wrote: >>>>> This enables virtio-mem device support by allowing to enable the >>>>> corresponding kernel config option (CONFIG_VIRTIO_MEM) on the >>>>> architecture. >>>>> >>>>> Signed-off-by: Gavin Shan >>>>> Acked-by: David Hildenbrand >>>>> Acked-by: Jonathan Cameron >>>>> Acked-by: Michael S. Tsirkin >>>>> --- >>>>> v3: Pick ack-by tags from Jonathan and Michael >>>>> --- >>>>> drivers/virtio/Kconfig | 7 ++++--- >>>>> 1 file changed, 4 insertions(+), 3 deletions(-) >>>>> >>>>> diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig >>>>> index 34f80b7a8a64..74c8b0c7bc33 100644 >>>>> --- a/drivers/virtio/Kconfig >>>>> +++ b/drivers/virtio/Kconfig >>>>> @@ -106,7 +106,7 @@ config VIRTIO_BALLOON >>>>> config VIRTIO_MEM >>>>> tristate "Virtio mem driver" >>>>> default m >>>>> - depends on X86_64 >>>>> + depends on X86_64 || ARM64 >>>>> depends on VIRTIO >>>>> depends on MEMORY_HOTPLUG >>>>> depends on MEMORY_HOTREMOVE >>>>> @@ -116,8 +116,9 @@ config VIRTIO_MEM >>>>> This driver provides access to virtio-mem paravirtualized memory >>>>> devices, allowing to hotplug and hotunplug memory. >>>>> >>>>> - This driver was only tested under x86-64, but should theoretically >>>>> - work on all architectures that support memory hotplug and hotremove. >>>>> + This driver was only tested under x86-64 and arm64, but should >>>>> + theoretically work on all architectures that support memory hotplug >>>>> + and hotremove. >>>>> >>>> >>>> BTW isn't there a symbol saying "memory hotplug" that we can depend on? >>>> >> >> You mean >> >> depends on MEMORY_HOTPLUG >> depends on MEMORY_HOTREMOVE >> >> We still need a manual opt-in from architectures, because devil's in the >> detail. (e.g., memblock stuff we had to adjust) > > Is there any chance of documenting some of this here? The current comment makes it > look like it's just a question of whitelisting an architecture. I can send a patch to add more details. -- Thanks, David / dhildenb _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel