From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/mlx: update C compliance standard
Date: Sat, 1 Jul 2017 16:58:08 +0100
Message-ID: <45a80418-acd5-42d7-4319-365bed329fa9@intel.com>
References: <4bc47a8c50dc528f8061d95cdd0c0934e4e40b38.1498843072.git.adrien.mazarguil@6wind.com>
 <c3e5f96d-bc1f-6cf6-b8b3-b5d0a13e3d20@intel.com>
 <1C0F2AC4-AF9D-4A02-A35A-F70577FE67B5@mellanox.com>
 <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 =?UTF-8?Q?N=c3=a9lio_Laranjeiro?= <nelio.laranjeiro@6wind.com>,
 "dev@dpdk.org" <dev@dpdk.org>
To: Yongseok Koh <yskoh@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 380112BAF
 for <dev@dpdk.org>; Sat,  1 Jul 2017 17:58:11 +0200 (CEST)
In-Reply-To: <7672F9BE-1782-4F1A-B4B7-F28C82C34FD5@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/30/2017 7:25 PM, Yongseok Koh wrote:
> 
> Hi,
> 
> 
> 
> Thanks,
> Yongseok
> 
>> On Jun 30, 2017, at 11:14 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>>
>>
>>> On Jun 30, 2017, at 10:47 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>>>
>>> On 6/30/2017 6:19 PM, Adrien Mazarguil wrote:
>>>> This commit addresses a compilation issue against Glibc >= 2.25, which
>>>> implements assert() through a nonstandard ({ }) construct. Such constructs
>>>> can normally not be used without __extension__ keyword when -pedantic is
>>>> enabled, as is the case when compiling mlx4 and mlx5 PMDs in debug mode.
>>>>
>>>> While assert.h checks for the compiler ability to support GNU extensions,
>>>> Clang, unlike GCC, does not allow the above syntax when combining
>>>> -std=gnu99 with -pedantic.
>>>>
>>>> Work around missing keyword by moving these PMDs to a stricter compliance
>>>> standard without GNU extensions but properly checked by Glibc. Doing so is
>>>> supported on the DPDK side since includes have been cleaned up.
>>>>
>>>> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
>>>
>>> Applied to dpdk-next-net/master, thanks.
>> This breaks debug-enabled build of mlx5 as mlx5 isn't ready yet!
> Specifically, the following errors happen. It might be better to later make the
> change for mlx5 with further cleanup.

I don't see build errors.
Patch is requested to fix mlx DEBUG builds [1]. Can you please give more
details how to reproduce build error?

[1]
http://dpdk.org/ml/archives/dev/2017-June/067866.html