From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 069BAC433F5 for ; Fri, 4 Feb 2022 15:52:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=v7A1n8TEHbuInFdQ2TkKqtcmtawKfqLz2wPn/S/bvfw=; b=rs516xwQ5ZNTP6gjRmznkJzvJe 3xmT1BPwNb48OOJdUjIN08eZmEJDauLM2WZFP5uN/eey/mnBbfPQcC1KgsXtmiuctC2O2jcmtSxkj +QTxtqvxqePZR0wfftWyOsWAZ/AwlZcE3odXtR4SFc7PURkviDDThK5PNZ93JaZf2M/iADrhjg4u7 nLXx7z5IHn/b6sBF7F84nkcVmqYNWo0z4KUq2gIf0fi6SSdsMurR58prL94tkE6OGUkVkO0yS2tmJ BwdnGvrip1/ciocUhbo53oqtf1toz+GTnncxYckQ6EnNUdKXeQ9RsV482g0fp3nwQ4waNBOIFvILR /pGjyukw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG0rm-004paG-5I; Fri, 04 Feb 2022 15:51:18 +0000 Received: from mail-io1-xd35.google.com ([2607:f8b0:4864:20::d35]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nG0ri-004pZZ-0Z for linux-arm-kernel@lists.infradead.org; Fri, 04 Feb 2022 15:51:15 +0000 Received: by mail-io1-xd35.google.com with SMTP id n17so7842514iod.4 for ; Fri, 04 Feb 2022 07:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=eplSvyFmqr+B3dL1i1FApe/C2iMgy7A263Ginz12QSQ=; b=WuAxn9DkTiBtS6GeGV0LpPqCHo2T3m42d8cTwMVbGDeT3rPO/G98IOdHQI8J7CCKWA HKojpX6lH55cgUd0M+dE0DkyPS2Yd7+RUJjf9/pvUdzW/EV27R2yE4ItRKmb1B2+kD/e wapMSB/VyelL5LC6ANKRKuGGPWSbpWzQW+AXQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eplSvyFmqr+B3dL1i1FApe/C2iMgy7A263Ginz12QSQ=; b=qygAHNNeALmKu3+quCvuTLL0AZ4HHH6TOH29j4GPqlOXXGHpoj6zaFre5Oh+n+doVr vwk8qzb+Pj2PRl1R6pudfvZT4/1uJkjnOGc7s4Uwiua/Zf+NZm/F8qaj60fXi1ptZ0DK qGMhfZ2vXg6p+8IlEBfy/zF6icK9a1ydBXvIR2jLDC1fS65qumpUqKb0HvXe0HOOi0lE MSoTpgpe+sJNAnNB33WBHNKH9PNrwBiH20x0A2BCR1fCc1AQJyR6aQhXQR3HbZNl8p8L fcIovzSZR8/tApazFEC39kQiHNX2iDIh81aRp3Ze/MpPu/Dxu1QEWKxANW3cjAYBoLd9 8N7g== X-Gm-Message-State: AOAM533xW6YAK29LY+LT/ow9tv7bdbthSrsMdI5Qm58CRvY+eoRZhJ7S qkAcNslFcOL6hJAmlqigDmfvYg== X-Google-Smtp-Source: ABdhPJwwWPSfAFvdixgVIEf+07tE0rvVaFDJDB/5YaiuZdMebvMBqpZ4WQAT9V3XgpgrQWgqIn4mFw== X-Received: by 2002:a02:5b4a:: with SMTP id g71mr1624352jab.76.1643989872008; Fri, 04 Feb 2022 07:51:12 -0800 (PST) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id l13sm1145118ilj.24.2022.02.04.07.51.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Feb 2022 07:51:11 -0800 (PST) Subject: Re: [PATCH v2 1/6] kselftest/arm64: mte: user_mem: introduce tag_offset and tag_len To: Joey Gouly , linux-arm-kernel@lists.infradead.org Cc: nd@arm.com, broonie@kernel.org, catalin.marinas@arm.com, shuah@kernel.org, will@kernel.org, Shuah Khan References: <20220203143620.30629-1-joey.gouly@arm.com> <20220203143620.30629-2-joey.gouly@arm.com> From: Shuah Khan Message-ID: <45ab2d96-c8e0-7b72-a384-c4160b9312ac@linuxfoundation.org> Date: Fri, 4 Feb 2022 08:51:10 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220203143620.30629-2-joey.gouly@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220204_075114_097602_A79F73B3 X-CRM114-Status: GOOD ( 22.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/3/22 7:36 AM, Joey Gouly wrote: > These can be used to place a different tag not at a page size boundary. Please add more information here. Based on the code instead of pagesz, this test allows other sizes. This is a good change and bit more info. helps describe the value of this change. > > Signed-off-by: Joey Gouly > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Mark Brown > Cc: Shuah Khan > --- > .../selftests/arm64/mte/check_user_mem.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/tools/testing/selftests/arm64/mte/check_user_mem.c b/tools/testing/selftests/arm64/mte/check_user_mem.c > index 1de7a0abd0ae..5a5a7e1f5789 100644 > --- a/tools/testing/selftests/arm64/mte/check_user_mem.c > +++ b/tools/testing/selftests/arm64/mte/check_user_mem.c > @@ -19,7 +19,8 @@ > > static size_t page_sz; > > -static int check_usermem_access_fault(int mem_type, int mode, int mapping) > +static int check_usermem_access_fault(int mem_type, int mode, int mapping, > + int tag_offset, int tag_len) > { > int fd, i, err; > char val = 'A'; > @@ -54,10 +55,12 @@ static int check_usermem_access_fault(int mem_type, int mode, int mapping) > if (i < len) > goto usermem_acc_err; > > - /* Tag the next half of memory with different value */ > - ptr_next = (void *)((unsigned long)ptr + page_sz); > + if (!tag_len) > + tag_len = len - tag_offset; > + /* Tag a part of memory with different value */ > + ptr_next = (void *)((unsigned long)ptr + tag_offset); > ptr_next = mte_insert_new_tag(ptr_next); > - mte_set_tag_address_range(ptr_next, page_sz); > + mte_set_tag_address_range(ptr_next, tag_len); > > lseek(fd, 0, 0); > /* Copy from file into buffer with invalid tag */ > @@ -100,14 +103,14 @@ int main(int argc, char *argv[]) > /* Set test plan */ > ksft_set_plan(4); > > - evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE), > + evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_SYNC_ERR, MAP_PRIVATE, page_sz, 0), > "Check memory access from kernel in sync mode, private mapping and mmap memory\n"); Any reason to not print the size - old message is better? > - evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_SYNC_ERR, MAP_SHARED), > + evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_SYNC_ERR, MAP_SHARED, page_sz, 0), > "Check memory access from kernel in sync mode, shared mapping and mmap memory\n"); > > - evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_ASYNC_ERR, MAP_PRIVATE), > + evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_ASYNC_ERR, MAP_PRIVATE, page_sz, 0), > "Check memory access from kernel in async mode, private mapping and mmap memory\n"); > - evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_ASYNC_ERR, MAP_SHARED), > + evaluate_test(check_usermem_access_fault(USE_MMAP, MTE_ASYNC_ERR, MAP_SHARED, page_sz, 0), > "Check memory access from kernel in async mode, shared mapping and mmap memory\n"); > > mte_restore_setup(); > With these comments: Reviewed-by: Shuah Khan thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel