From mboxrd@z Thu Jan  1 00:00:00 1970
From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: Re: [PATCH 09/13] drm/fb-helper: Split dpms handling into legacy and
 atomic paths
Date: Thu, 29 Jun 2017 12:58:03 +0200
Message-ID: <45b24a01-ade9-f8df-d6c9-99ea9cc4309a@linux.intel.com>
References: <20170627145936.18983-1-daniel.vetter@ffwll.ch>
 <20170627145936.18983-10-daniel.vetter@ffwll.ch>
 <28764010-74e0-5049-ee9c-9ddc944efb20@linux.intel.com>
 <CAKMK7uHZqPd0MbnNx+5pvwQjw1ejY2Z8wiOn84qnLnXaJxsgow@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <CAKMK7uHZqPd0MbnNx+5pvwQjw1ejY2Z8wiOn84qnLnXaJxsgow@mail.gmail.com>
Content-Language: en-US
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Thierry Reding <treding@nvidia.com>, Peter Rosin <peda@axentia.se>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

T3AgMjktMDYtMTcgb20gMTI6MzEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IE9uIFRodSwgSnVu
IDI5LCAyMDE3IGF0IDEyOjIyIFBNLCBNYWFydGVuIExhbmtob3JzdAo+IDxtYWFydGVuLmxhbmto
b3JzdEBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgo+Pj4gK3N0YXRpYyB2b2lkIGRwbXNfYXRvbWlj
KHN0cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIsIGludCBkcG1zX21vZGUpCj4+PiArewo+
Pj4gKyAgICAgc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2Owo+Pj4gKyAg
ICAgc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+Pj4gKyAgICAgaW50IGksIHJldDsK
Pj4+ICsKPj4+ICsgICAgIHN0cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCBjdHg7Cj4+PiAr
Cj4+PiArICAgICBkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4+PiArCj4+PiAr
ICAgICBzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPj4+ICsgICAgIGlmICgh
c3RhdGUpIHsKPj4+ICsgICAgICAgICAgICAgcmV0ID0gLUVOT01FTTsKPj4+ICsgICAgICAgICAg
ICAgZ290byBvdXRfY3R4Owo+Pj4gKyAgICAgfQo+Pj4gKwo+Pj4gKyAgICAgc3RhdGUtPmFjcXVp
cmVfY3R4ID0gJmN0eDsKPj4+ICtyZXRyeToKPj4+ICsgICAgIGZvciAoaSA9IDA7IGkgPCBmYl9o
ZWxwZXItPmNydGNfY291bnQ7IGkrKykgewo+Pj4gKyAgICAgICAgICAgICBzdHJ1Y3QgZHJtX2Ny
dGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4+PiArICAgICAgICAgICAgIHN0cnVjdCBkcm1fY3J0YyAq
Y3J0YzsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgaWYgKCFmYl9oZWxwZXItPmNydGNfaW5mb1tp
XS5tb2RlX3NldC5tb2RlKQo+Pj4gKyAgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOwo+Pj4g
Kwo+Pj4gKyAgICAgICAgICAgICBjcnRjID0gZmJfaGVscGVyLT5jcnRjX2luZm9baV0ubW9kZV9z
ZXQuY3J0YzsKPj4+ICsKPj4+ICsgICAgICAgICAgICAgY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNf
Z2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+Pj4gKyAgICAgICAgICAgICBpZiAoSVNfRVJS
KGNydGNfc3RhdGUpKSB7Cj4+PiArICAgICAgICAgICAgICAgICAgICAgcmV0ID0gUFRSX0VSUihj
cnRjX3N0YXRlKTsKPj4+ICsgICAgICAgICAgICAgICAgICAgICBnb3RvIG91dF9zdGF0ZTsKPj4+
ICsgICAgICAgICAgICAgfQo+PiBIbSwgbWF5YmUgcmVtb3ZlIHRoZSBlYXJseSBjb250aW51ZSwg
YW5kIGNoYW5nZSB0aGlzIHRvIGlmIChjcnRjX3N0YXRlLT5lbmFibGUpIGNydGNfc3RhdGUtPmFj
dGl2ZSA9IC4uLjsgPwo+Pgo+PiBJIGRvbid0IGtub3cgaWYgaXQgbWF0dGVycyBpbiBwcmFjdGlj
ZSwgYnV0IGl0IG1pZ2h0IGJlIG1vcmUgcmVzaWxpZW50IHdoZW4gY3J0YyBzdGF0ZSBkb2VzIG5v
dCBtYXRjaCBvdXIgZXhwZWN0ZWQgc3RhdGUsCj4+IHNpbWlsYXIgdG8gaG93IERQTVMgb24gaXMg
aWdub3JlZCB3aXRob3V0IENSVEMuCj4gSSBqdXN0IGJsaW5kbHkgc21hc2hlZCB0aGUgb2xkIGZi
ZGV2IGNvZGUgaW4gd2l0aCB0aGUgaGVscGVyIGFuZCBtb3ZlZAo+IHRoZSBsb2NraW5nIG91dC4g
Tm90IHN1cmUgd2hhdCB3b3VsZCBiZSBiZXR0ZXIgaGVyZSwgc2luY2UgdGhlCj4gY29udGludWUg
aXMgaW4gYSB3YXkganVzdCBwYXJ0IG9mIGEgbm9uLWV4aXN0ZW50Cj4gZHJtX2ZiX2hlbHBlcl9m
b3JfZWFjaF9hY3RpdmVfY3J0YyBsb29wIGl0ZXJhdG9yLiBOb3Qgc3VyZSBpdCdzIHdvcnRoCj4g
aXQgdG8gb3ZlcnBvbGlzaCB0aGlzIGNvZGUgdG8gc3VjaCBhbiBleHRlbnQgOi0pCj4gLURhbmll
bAoKV2VsbCBjaGVja2luZyBmb3IgY3J0Y19zdGF0ZS0+ZW5hYmxlIGluc3RlYWQgb2YgbW9kZV9z
ZXQubW9kZSBwcm9iYWJseSBtZWFucyB3ZSdyZSBhdCBsZWFzdCBidWcgZm9yIGJ1Zwpjb21wYXRp
YmxlIHZzIGxlZ2FjeS4gSXQgbWlnaHQgYmUgYmV0dGVyIHRvIGFkZCBhIGJvb2wgYWN0aXZlIHRv
IHJlc3RvcmVfZmJkZXZfbW9kZV9hdG9taWMuCgpXaGF0IGFib3V0IHNvbWV0aGluZyBsaWtlIHRo
aXM/IFRoZSBsZXNzIGF0b21pYyBjb21taXRzIHRoZSBiZXR0ZXIuIDopCgpkaWZmIC0tZ2l0IGEv
ZHJpdmVycy9ncHUvZHJtL2RybV9mYl9oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fZmJf
aGVscGVyLmMKaW5kZXggZTQ5YmFlMTBmMGVlLi4yYzQwMWZlODUzMWMgMTAwNjQ0Ci0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9kcm1fZmJfaGVscGVyLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9m
Yl9oZWxwZXIuYwpAQCAtMzc4LDcgKzM3OCw3IEBAIGludCBkcm1fZmJfaGVscGVyX2RlYnVnX2xl
YXZlKHN0cnVjdCBmYl9pbmZvICppbmZvKQogfQogRVhQT1JUX1NZTUJPTChkcm1fZmJfaGVscGVy
X2RlYnVnX2xlYXZlKTsKIAotc3RhdGljIGludCByZXN0b3JlX2ZiZGV2X21vZGVfYXRvbWljKHN0
cnVjdCBkcm1fZmJfaGVscGVyICpmYl9oZWxwZXIpCitzdGF0aWMgaW50IHJlc3RvcmVfZmJkZXZf
bW9kZV9hdG9taWMoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlciwgYm9vbCBhY3RpdmUp
CiB7CiAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBlci0+ZGV2OwogCXN0cnVjdCBk
cm1fcGxhbmUgKnBsYW5lOwpAQCAtNDI3LDYgKzQyNywxNyBAQCBzdGF0aWMgaW50IHJlc3RvcmVf
ZmJkZXZfbW9kZV9hdG9taWMoc3RydWN0IGRybV9mYl9oZWxwZXIgKmZiX2hlbHBlcikKIAkJcmV0
ID0gX19kcm1fYXRvbWljX2hlbHBlcl9zZXRfY29uZmlnKG1vZGVfc2V0LCBzdGF0ZSk7CiAJCWlm
IChyZXQgIT0gMCkKIAkJCWdvdG8gb3V0X3N0YXRlOworCisJCS8qCisJCSAqIF9fZHJtX2F0b21p
Y19oZWxwZXJfc2V0X2NvbmZpZygpIHNldHMgYWN0aXZlIHdoZW4gYQorCQkgKiBtb2RlIGlzIHNl
dCwgdW5jb25kaXRpb25hbGx5IGNsZWFyIGl0IGlmIHdlIGZvcmNlIERQTVMgb2ZmCisJCSAqLwor
CQlpZiAoIWFjdGl2ZSkgeworCQkJc3RydWN0IGRybV9jcnRjICpjcnRjID0gbW9kZV9zZXQtPmNy
dGM7CisJCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPSBkcm1fYXRvbWljX2dl
dF9uZXdfY3J0Y19zdGF0ZShzdGF0ZSwgY3J0Yyk7CisKKwkJCWNydGNfc3RhdGUtPmFjdGl2ZSA9
IGZhbHNlOworCQl9CiAJfQogCiAJcmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwpAQCAt
NDk3LDcgKzUwOCw3IEBAIHN0YXRpYyBpbnQgcmVzdG9yZV9mYmRldl9tb2RlKHN0cnVjdCBkcm1f
ZmJfaGVscGVyICpmYl9oZWxwZXIpCiAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGZiX2hlbHBl
ci0+ZGV2OwogCiAJaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChkZXYpKQotCQlyZXR1
cm4gcmVzdG9yZV9mYmRldl9tb2RlX2F0b21pYyhmYl9oZWxwZXIpOworCQlyZXR1cm4gcmVzdG9y
ZV9mYmRldl9tb2RlX2F0b21pYyhmYl9oZWxwZXIsIHRydWUpOwogCWVsc2UKIAkJcmV0dXJuIHJl
c3RvcmVfZmJkZXZfbW9kZV9sZWdhY3koZmJfaGVscGVyKTsKIH0KQEAgLTcxNCw3ICs2NjksNyBA
QCBzdGF0aWMgdm9pZCBkcm1fZmJfaGVscGVyX2RwbXMoc3RydWN0IGZiX2luZm8gKmluZm8sIGlu
dCBkcG1zX21vZGUpCiAJfQogCiAJaWYgKGRybV9kcnZfdXNlc19hdG9taWNfbW9kZXNldChmYl9o
ZWxwZXItPmRldikpCi0JCWRwbXNfYXRvbWljKGZiX2hlbHBlciwgZHBtc19tb2RlKTsKKwkJcmVz
dG9yZV9mYmRldl9tb2RlX2F0b21pYyhmYl9oZWxwZXIsIGRwbXNfbW9kZSA9PSBEUk1fTU9ERV9E
UE1TX09OKTsKIAllbHNlCiAJCWRwbXNfbGVnYWN5KGZiX2hlbHBlciwgZHBtc19tb2RlKTsKIAlt
dXRleF91bmxvY2soJmZiX2hlbHBlci0+bG9jayk7CgpfX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBs
aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h
bi9saXN0aW5mby9kcmktZGV2ZWwK