From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Durrant Subject: Re: [PATCH v8 for-4.9 3/5] hvm/dmop: Implement copy_{to, from}_guest_buf() in terms of raw accessors Date: Fri, 21 Apr 2017 14:11:08 +0000 Message-ID: <45b2b165da694f209ffbaacb3c9a17e8@AMSPEX02CL03.citrite.net> References: <1492783552-29472-1-git-send-email-jennifer.herbert@citrix.com> <1492783552-29472-3-git-send-email-jennifer.herbert@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1492783552-29472-3-git-send-email-jennifer.herbert@citrix.com> Content-Language: en-US List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Xen-devel Cc: Andrew Cooper , Julien Grall , Jennifer Herbert , Jan Beulich List-Id: xen-devel@lists.xenproject.org PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+IEZyb206IGplbm5pZmVyLmhlcmJlcnRAY2l0 cml4LmNvbSBbbWFpbHRvOmplbm5pZmVyLmhlcmJlcnRAY2l0cml4LmNvbV0KPiBTZW50OiAyMSBB cHJpbCAyMDE3IDE1OjA2Cj4gVG86IFhlbi1kZXZlbCA8eGVuLWRldmVsQGxpc3RzLnhlbi5vcmc+ Cj4gQ2M6IEFuZHJldyBDb29wZXIgPEFuZHJldy5Db29wZXIzQGNpdHJpeC5jb20+OyBKZW5uaWZl ciBIZXJiZXJ0Cj4gPGplbm5pZmVyLmhlcmJlcnRAY2l0cml4LmNvbT47IFBhdWwgRHVycmFudCA8 UGF1bC5EdXJyYW50QGNpdHJpeC5jb20+OyBKYW4KPiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNv bT47IEp1bGllbiBHcmFsbCA8anVsaWVuLmdyYWxsQGFybS5jb20+Cj4gU3ViamVjdDogW1BBVENI IHY4IGZvci00LjkgMy81XSBodm0vZG1vcDogSW1wbGVtZW50IGNvcHlfe3RvLAo+IGZyb219X2d1 ZXN0X2J1ZigpIGluIHRlcm1zIG9mIHJhdyBhY2Nlc3NvcnMKPiAKPiBGcm9tOiBBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPgo+IAo+IFRoaXMgYWxzbyBhbGxvd3MgdGhl IHVzdWFsIGNhc2VzIHRvIGJlIHNpbXBsaWZpZWQsIGJ5IG9taXR0aW5nIGFuIHVubmVjZXNzYXJ5 Cj4gYnVmIHBhcmFtZXRlcnMsIGFuZCBiZWNhdXNlIHRoZSBtYWNyb3MgY2FuIGFwcHJvcHJpYXRl bHkgc2l6ZSB0aGUgb2JqZWN0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEFuZHJldyBDb29wZXIgPGFu ZHJldy5jb29wZXIzQGNpdHJpeC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSmVubmlmZXIgSGVyYmVy dCA8SmVubmlmZXIuSGVyYmVydEBjaXRyaXguY29tPgoKUmV2aWV3ZWQtYnk6IFBhdWwgRHVycmFu dCA8cGF1bC5kdXJyYW50QGNpdHJpeC5jb20+Cgo+IC0tCj4gQ0M6IFBhdWwgRHVycmFudCA8cGF1 bC5kdXJyYW50QGNpdHJpeC5jb20+Cj4gQ0M6IEFuZHJldyBDb29wZXIgPGFuZHJldy5jb29wZXIz QGNpdHJpeC5jb20+Cj4gQ0M6IEphbiBCZXVsaWNoIDxKQmV1bGljaEBzdXNlLmNvbT4KPiBDQzog SnVsaWVuIEdyYWxsIDxqdWxpZW4uZ3JhbGxAYXJtLmNvbT4KPiAtLS0KPiBSZWJhc2VkLgo+IC0t LQo+ICB4ZW4vYXJjaC94ODYvaHZtL2RtLmMgfCA0MyArKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0tLS0tLS0tLS0tLQo+IC0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAyNiBpbnNlcnRpb25zKCsp LCAxNyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2FyY2gveDg2L2h2bS9kbS5j IGIveGVuL2FyY2gveDg2L2h2bS9kbS5jCj4gaW5kZXggODkxODZkMi4uYjMxYzI1MiAxMDA2NDQK PiAtLS0gYS94ZW4vYXJjaC94ODYvaHZtL2RtLmMKPiArKysgYi94ZW4vYXJjaC94ODYvaHZtL2Rt LmMKPiBAQCAtMzIsMzggKzMyLDQ3IEBAIHN0cnVjdCBkbW9wX2FyZ3Mgewo+ICAgICAgc3RydWN0 IHhlbl9kbV9vcF9idWYgYnVmWzJdOwo+ICB9Owo+IAo+IC1zdGF0aWMgYm9vbCBjb3B5X2J1Zl9m cm9tX2d1ZXN0KGNvbnN0IHhlbl9kbV9vcF9idWZfdCBidWZzW10sCj4gLSAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IG5yX2J1ZnMsIHZvaWQgKmRzdCwKPiAtICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgaWR4LCBzaXplX3QgZHN0 X3NpemUpCj4gK3N0YXRpYyBib29sIF9yYXdfY29weV9mcm9tX2d1ZXN0X2J1Zih2b2lkICpkc3Qs Cj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgZG1v cF9hcmdzICphcmdzLAo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdW5z aWduZWQgaW50IGJ1Zl9pZHgsCj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBzaXplX3QgZHN0X2J5dGVzKQo+ICB7Cj4gICAgICBzaXplX3QgYnVmX2J5dGVzOwo+IAo+IC0g ICAgaWYgKCBpZHggPj0gbnJfYnVmcyApCj4gKyAgICBpZiAoIGJ1Zl9pZHggPj0gYXJncy0+bnJf YnVmcyApCj4gICAgICAgICAgcmV0dXJuIGZhbHNlOwo+IAo+IC0gICAgYnVmX2J5dGVzID0gYnVm c1tpZHhdLnNpemU7Cj4gLSAgICBpZiAoIGRzdF9zaXplID4gYnVmX2J5dGVzICkKPiArICAgIGJ1 Zl9ieXRlcyA9ICBhcmdzLT5idWZbYnVmX2lkeF0uc2l6ZTsKPiArCj4gKyAgICBpZiAoIGRzdF9i eXRlcyA+IGJ1Zl9ieXRlcyApCj4gICAgICAgICAgcmV0dXJuIGZhbHNlOwo+IAo+IC0gICAgcmV0 dXJuICFjb3B5X2Zyb21fZ3Vlc3QoZHN0LCBidWZzW2lkeF0uaCwgZHN0X3NpemUpOwo+ICsgICAg cmV0dXJuICFjb3B5X2Zyb21fZ3Vlc3QoZHN0LCBhcmdzLT5idWZbYnVmX2lkeF0uaCwgZHN0X2J5 dGVzKTsKPiAgfQo+IAo+IC1zdGF0aWMgYm9vbCBjb3B5X2J1Zl90b19ndWVzdChjb25zdCB4ZW5f ZG1fb3BfYnVmX3QgYnVmc1tdLAo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNp Z25lZCBpbnQgbnJfYnVmcywgdW5zaWduZWQgaW50IGlkeCwKPiAtICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgY29uc3Qgdm9pZCAqc3JjLCBzaXplX3Qgc3JjX3NpemUpCj4gK3N0YXRpYyBi b29sIF9yYXdfY29weV90b19ndWVzdF9idWYoY29uc3Qgc3RydWN0IGRtb3BfYXJncyAqYXJncywK PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgYnVmX2lk eCwKPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCB2b2lkICpzcmMs IHNpemVfdCBzcmNfYnl0ZXMpCj4gIHsKPiAgICAgIHNpemVfdCBidWZfYnl0ZXM7Cj4gCj4gLSAg ICBpZiAoIGlkeCA+PSBucl9idWZzICkKPiArICAgIGlmICggYnVmX2lkeCA+PSBhcmdzLT5ucl9i dWZzICkKPiAgICAgICAgICByZXR1cm4gZmFsc2U7Cj4gCj4gLSAgICBidWZfYnl0ZXMgPSBidWZz W2lkeF0uc2l6ZTsKPiAtICAgIGlmICggc3JjX3NpemUgPiBidWZfYnl0ZXMgKQo+ICsgICAgYnVm X2J5dGVzID0gYXJncy0+YnVmW2J1Zl9pZHhdLnNpemU7Cj4gKwo+ICsgICAgaWYgKCBzcmNfYnl0 ZXMgPiBidWZfYnl0ZXMgKQo+ICAgICAgICAgIHJldHVybiBmYWxzZTsKPiAKPiAtICAgIHJldHVy biAhY29weV90b19ndWVzdChidWZzW2lkeF0uaCwgc3JjLCBzcmNfc2l6ZSk7Cj4gKyAgICByZXR1 cm4gIWNvcHlfdG9fZ3Vlc3QoYXJncy0+YnVmW2J1Zl9pZHhdLmgsIHNyYywgc3JjX2J5dGVzKTsK PiAgfQo+IAo+ICsjZGVmaW5lIENPUFlfRlJPTV9HVUVTVF9CVUYoZHN0LCBhcmdzLCBidWZfaWR4 KSBcCj4gKyAgICBfcmF3X2NvcHlfZnJvbV9ndWVzdF9idWYoJmRzdCwgYXJncywgYnVmX2lkeCwg c2l6ZW9mKGRzdCkpCj4gKwo+ICsjZGVmaW5lIENPUFlfVE9fR1VFU1RfQlVGKGFyZ3MsIGJ1Zl9p ZHgsIHNyYykgXAo+ICsgICAgX3Jhd19jb3B5X3RvX2d1ZXN0X2J1ZihhcmdzLCBidWZfaWR4LCAm c3JjLCBzaXplb2Yoc3JjKSkKPiArCj4gIHN0YXRpYyBpbnQgdHJhY2tfZGlydHlfdnJhbShzdHJ1 Y3QgZG9tYWluICpkLCB4ZW5fcGZuX3QgZmlyc3RfcGZuLAo+ICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgdW5zaWduZWQgaW50IG5yLCBjb25zdCBzdHJ1Y3QgeGVuX2RtX29wX2J1ZiAqYnVm KQo+ICB7Cj4gQEAgLTMxNCw3ICszMjMsNyBAQCBzdGF0aWMgaW50IGRtX29wKGNvbnN0IHN0cnVj dCBkbW9wX2FyZ3MgKm9wX2FyZ3MpCj4gICAgICBpZiAoIHJjICkKPiAgICAgICAgICBnb3RvIG91 dDsKPiAKPiAtICAgIGlmICggIWNvcHlfYnVmX2Zyb21fZ3Vlc3QoJm9wX2FyZ3MtPmJ1ZlswXSwg b3BfYXJncy0+bnJfYnVmcywgJm9wLCAwLAo+IHNpemVvZihvcCkpICkKPiArICAgIGlmICggIUNP UFlfRlJPTV9HVUVTVF9CVUYob3AsIG9wX2FyZ3MsIDApICk7Cj4gICAgICB7Cj4gICAgICAgICAg cmMgPSAtRUZBVUxUOwo+ICAgICAgICAgIGdvdG8gb3V0Owo+IEBAIC01NzAsOCArNTc5LDggQEAg c3RhdGljIGludCBkbV9vcChjb25zdCBzdHJ1Y3QgZG1vcF9hcmdzICpvcF9hcmdzKQo+ICAgICAg fQo+IAo+ICAgICAgaWYgKCAoIXJjIHx8IHJjID09IC1FUkVTVEFSVCkgJiYKPiAtICAgICAgICAg IWNvbnN0X29wICYmCj4gLSAgICAgICAgICFjb3B5X2J1Zl90b19ndWVzdCgmb3BfYXJncy0+YnVm WzBdLCBvcF9hcmdzLT5ucl9idWZzLCAwLCAmb3AsCj4gc2l6ZW9mKG9wKSkgKQo+ICsgICAgICAg ICAhY29uc3Rfb3AgJiYgIUNPUFlfVE9fR1VFU1RfQlVGKG9wX2FyZ3MsIDAsIG9wKSApCj4gKwo+ ICAgICAgICAgIHJjID0gLUVGQVVMVDsKPiAKPiAgIG91dDoKPiAtLQo+IDIuMS40CgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxp bmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVu LWRldmVsCg==