From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 Date: Tue, 14 Apr 2020 18:32:57 +0300 Message-ID: <45b65baa-fd9b-3248-bc24-e226cfc8c8dc@gmail.com> References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> <3e518dfa-cb3d-e2ce-a9b8-5e143e02fc61@gmail.com> <6976796c-6972-328e-3e9f-60c1737cf0e2@gmail.com> <20200414150516.GL3593749@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200414150516.GL3593749@ulmo> Content-Language: en-US Sender: linux-clk-owner@vger.kernel.org To: Thierry Reding Cc: Rob Herring , Jon Hunter , Michael Turquette , Stephen Boyd , Joseph Lo , linux-tegra@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-tegra@vger.kernel.org 14.04.2020 18:05, Thierry Reding пишет: ... >> What about replacing those barely readable concatenated macros with a >> raw values? >> >> Like: >> >> TRIM_REG(brlshft_idx, ob_ddll_long_dq_rank_mask, ...) > > That's just going to move the complexity from the macros to the > callsites, isn't it? > > I suppose I could spend a few cycles trying to make this a little more > readable, but to be frank, the complexity in this driver is already so > high that this doesn't really make much of a difference, in my opinion. I can't guarantee that the final result will be excellent, but I'd try to turn that macro into the function and then use the raw HW values instead of the defines. It looks to me that the result at least should be better. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77E93C2BA19 for ; Tue, 14 Apr 2020 15:33:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 402F120578 for ; Tue, 14 Apr 2020 15:33:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="FWICrojZ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="MI34FaFA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 402F120578 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t3M3fnRottp+c78U133pI/8NOrFark8pLgY6BQAuXek=; b=FWICrojZLrCFKM u+F5oYc2guwav2+LNGhL2AciNrdEFPFkSM5guGBoDDydXRdJdksxuQU4fwN3t2KG2MBXntlhcWPYl U32WiGp8LN9k1AVfdLu6YWda2f9gjn8Fu1kg+1f5CDH/3wSyfCUGl3mNUWO7MEMlMxd34wPD4YYec pN4l2Bj8qGHvJTiXa8q/yevmMWpw0suJzH74Y9CvZezkTPje9AERxQm5sjl9CZVQnWmQaYCzSRxTA wCNIl+wheji7ERCRaiWlSgnSv8tvYU1+8YNSS5mG3FWkwu5Pz/b+AZntgadnSF4zKLIcQdIceT1sM GCCfuHcIXjMd5/xMyh6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONYd-0006Sh-Rs; Tue, 14 Apr 2020 15:33:03 +0000 Received: from mail-lf1-x141.google.com ([2a00:1450:4864:20::141]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jONYb-0006S3-1u for linux-arm-kernel@lists.infradead.org; Tue, 14 Apr 2020 15:33:02 +0000 Received: by mail-lf1-x141.google.com with SMTP id m19so39891lfq.13 for ; Tue, 14 Apr 2020 08:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4eIrItheLX7YX2ovx/taypeY8owEKNTnWW8Vad5FCew=; b=MI34FaFABelIhbrwZvWxpE3BeRjE+jLVkAPgR5417k1cCJsV73RHRHbvaa84RzMxgW xetz+hgEeMaQ9aO0rfNL/aOte1KsQtdBPkNlzr5dikvh/3Lig+gpmfNtfeB7GA9UJASU nbmkKqX2fP7DiasP27nvBvPpo6P2xGWSqXLGirBeR6WrvSn8jCF7ZJOUQZIBGwbgrnH5 Rbq+AalrTIDbO3yyhvli1Qw7FejKlGpXk9qwvwwGpEQxfl4FlhhfSlTZ3bxUBPrCRmjP OLqjoR1LLJqjShTkwHmyuGdWL+JU7XSJUeVHv+3YpsEdC8ONzx4MexTEHcObjT1kph/Z pSaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4eIrItheLX7YX2ovx/taypeY8owEKNTnWW8Vad5FCew=; b=aRtPu8gP+PSupG75erkMsFJnd6zVL0ksCTdoIrFjbOf8YPjDWN3ILAwBXcalHj21rn GCKa/OnQzfSkKcaRVp+UKpz4fI1AcdQK0KQnIL8i9jOV/rMJszUv0bNI49OLO2FLsa8P KofGEDyDtWcXYgmrUPEKL+G/bj2jgH3XYaRIxiZekEWAZsmvecrFGKvfNGHY+S0iS5Hs QenvVChr0qWHLpATvwXeIyun6IWd/fcvSfmvHAHdgyLVWRk6c4z+Kx9xshTGwCsaaaX1 mGm4demTZKrTDR1R/jy4khuJ/BRlSN3klhjfLBbcz7GvETKPrLXOSlmIpNqxDNxlo+w/ KxwA== X-Gm-Message-State: AGi0PubBwtNGcT3xB+ikxuFFK/GhwPqF2wga20isYON07yx/fffwb/c9 5ORzsXzWCxEVO1oonCm95ADckESi X-Google-Smtp-Source: APiQypKpGY5BqwvpNTlCvMY9U59k/lj+SeiqM+aeyFKz8Q5woDyVq/h4Ljj2eIGognuBJLL5rYF67g== X-Received: by 2002:a19:c216:: with SMTP id l22mr229478lfc.172.1586878378571; Tue, 14 Apr 2020 08:32:58 -0700 (PDT) Received: from [192.168.2.145] (ppp91-78-208-152.pppoe.mtu-net.ru. [91.78.208.152]) by smtp.googlemail.com with ESMTPSA id l12sm7528500lfp.35.2020.04.14.08.32.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Apr 2020 08:32:57 -0700 (PDT) Subject: Re: [PATCH v6 09/14] memory: tegra: Add EMC scaling support code for Tegra210 To: Thierry Reding References: <20200409175238.3586487-1-thierry.reding@gmail.com> <20200409175238.3586487-10-thierry.reding@gmail.com> <3e518dfa-cb3d-e2ce-a9b8-5e143e02fc61@gmail.com> <6976796c-6972-328e-3e9f-60c1737cf0e2@gmail.com> <20200414150516.GL3593749@ulmo> From: Dmitry Osipenko Message-ID: <45b65baa-fd9b-3248-bc24-e226cfc8c8dc@gmail.com> Date: Tue, 14 Apr 2020 18:32:57 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200414150516.GL3593749@ulmo> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200414_083301_093033_9D80330C X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Stephen Boyd , Michael Turquette , Jon Hunter , Rob Herring , Joseph Lo , linux-tegra@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org MTQuMDQuMjAyMCAxODowNSwgVGhpZXJyeSBSZWRpbmcg0L/QuNGI0LXRgjoKLi4uCj4+IFdoYXQg YWJvdXQgcmVwbGFjaW5nIHRob3NlIGJhcmVseSByZWFkYWJsZSBjb25jYXRlbmF0ZWQgbWFjcm9z IHdpdGggYQo+PiByYXcgdmFsdWVzPwo+Pgo+PiBMaWtlOgo+Pgo+PiBUUklNX1JFRyhicmxzaGZ0 X2lkeCwgb2JfZGRsbF9sb25nX2RxX3JhbmtfbWFzaywgLi4uKQo+IAo+IFRoYXQncyBqdXN0IGdv aW5nIHRvIG1vdmUgdGhlIGNvbXBsZXhpdHkgZnJvbSB0aGUgbWFjcm9zIHRvIHRoZQo+IGNhbGxz aXRlcywgaXNuJ3QgaXQ/Cj4gCj4gSSBzdXBwb3NlIEkgY291bGQgc3BlbmQgYSBmZXcgY3ljbGVz IHRyeWluZyB0byBtYWtlIHRoaXMgYSBsaXR0bGUgbW9yZQo+IHJlYWRhYmxlLCBidXQgdG8gYmUg ZnJhbmssIHRoZSBjb21wbGV4aXR5IGluIHRoaXMgZHJpdmVyIGlzIGFscmVhZHkgc28KPiBoaWdo IHRoYXQgdGhpcyBkb2Vzbid0IHJlYWxseSBtYWtlIG11Y2ggb2YgYSBkaWZmZXJlbmNlLCBpbiBt eSBvcGluaW9uLgoKSSBjYW4ndCBndWFyYW50ZWUgdGhhdCB0aGUgZmluYWwgcmVzdWx0IHdpbGwg YmUgZXhjZWxsZW50LCBidXQgSSdkIHRyeQp0byB0dXJuIHRoYXQgbWFjcm8gaW50byB0aGUgZnVu Y3Rpb24gYW5kIHRoZW4gdXNlIHRoZSByYXcgSFcgdmFsdWVzCmluc3RlYWQgb2YgdGhlIGRlZmlu ZXMuIEl0IGxvb2tzIHRvIG1lIHRoYXQgdGhlIHJlc3VsdCBhdCBsZWFzdCBzaG91bGQKYmUgYmV0 dGVyLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGlu dXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgt YXJtLWtlcm5lbAo=