All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Opdenacker" <michael.opdenacker@bootlin.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	bitbake-devel@lists.openembedded.org
Cc: docs@lists.yoctoproject.org, Quentin Schulz <foss@0leil.net>
Subject: Re: [bitbake-devel] [docs] [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"
Date: Thu, 29 Jul 2021 16:00:08 +0200	[thread overview]
Message-ID: <45d80029-ad50-14bd-9991-0c6726e2a1b1@bootlin.com> (raw)
In-Reply-To: <1e3abc561a0492b2908acb0cfb83c81a50479210.camel@linuxfoundation.org>

Hi Richard,

On 7/29/21 3:51 PM, Richard Purdie wrote:
> On Thu, 2021-07-29 at 15:13 +0200, Michael Opdenacker wrote:
>> "metadata" is used both as singular and as plural.
>> The first change fixes a case in which the verb has a singular conjugation
>> but absence of article indicates a plural case.
>>
>> The second and third changes are for consistency with the first one inside
>> the same paragraph.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
>> Reviewed-by: Quentin Schulz <foss@0leil.net>
>> ---
>>  doc/bitbake-user-manual/bitbake-user-manual-intro.rst | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> index eb140665..55effc35 100644
>> --- a/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> +++ b/doc/bitbake-user-manual/bitbake-user-manual-intro.rst
>> @@ -27,11 +27,11 @@ Linux software stacks using a task-oriented approach.
>>  Conceptually, BitBake is similar to GNU Make in some regards but has
>>  significant differences:
>>  
>>
>> --  BitBake executes tasks according to provided metadata that builds up
>> -   the tasks. Metadata is stored in recipe (``.bb``) and related recipe
>> +-  BitBake executes tasks according to provided metadata that build up
>> +   the tasks. Metadata are stored in recipe (``.bb``) and related recipe
>>     "append" (``.bbappend``) files, configuration (``.conf``) and
>>     underlying include (``.inc``) files, and in class (``.bbclass``)
>> -   files. The metadata provides BitBake with instructions on what tasks
>> +   files. The metadata provide BitBake with instructions on what tasks
>>     to run and the dependencies between those tasks.
> This change doesn't sound like an improvement to me. I would always say 
> "The metadata provides", not what you have here which doesn't read 
> correctly to me. "builds up" also sounds better to me than "build up". I'd
> also say "Metadata is" sounds more correct too.
>
> I'm not sure I like the original wording but this doesn't sound right, at
> least to me.


Many thanks for the review. I know what to update then :)
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com


      reply	other threads:[~2021-07-29 14:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <16964500F28F0291.7588@lists.openembedded.org>
2021-07-29 13:13 ` Michael Opdenacker
2021-07-29 13:51   ` [docs] " Richard Purdie
2021-07-29 14:00     ` Michael Opdenacker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45d80029-ad50-14bd-9991-0c6726e2a1b1@bootlin.com \
    --to=michael.opdenacker@bootlin.com \
    --cc=bitbake-devel@lists.openembedded.org \
    --cc=docs@lists.yoctoproject.org \
    --cc=foss@0leil.net \
    --cc=richard.purdie@linuxfoundation.org \
    --subject='Re: [bitbake-devel] [docs] [PATCH v2] doc: bitbake-user-manual: grammar fix for the number of "metadata"' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.