From mboxrd@z Thu Jan 1 00:00:00 1970 Subject: Re: [PATCH 8/9] net/igb: down interface upon PCI unregister References: <20181026140825.5251-1-rpm@xenomai.org> <20181026140825.5251-8-rpm@xenomai.org> From: Philippe Gerum Message-ID: <45d95e25-aa65-e537-4221-7a43d397159d@xenomai.org> Date: Wed, 31 Oct 2018 15:18:04 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: Discussions about the Xenomai project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka , xenomai@xenomai.org On 10/31/18 1:32 PM, Jan Kiszka wrote: > On 26.10.18 16:08, Philippe Gerum wrote: >> Allow to safely unload the IGB driver module still hosting an active >> rtnet interface, by forcing this interface down on behalf on the PCI >> device removal handler. >> --- >>   kernel/drivers/net/drivers/igb/igb_main.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/kernel/drivers/net/drivers/igb/igb_main.c >> b/kernel/drivers/net/drivers/igb/igb_main.c >> index 67a34b539..0a6cd4bd6 100644 >> --- a/kernel/drivers/net/drivers/igb/igb_main.c >> +++ b/kernel/drivers/net/drivers/igb/igb_main.c >> @@ -2432,6 +2432,7 @@ static void igb_remove(struct pci_dev *pdev) >>       struct igb_adapter *adapter = rtnetdev_priv(netdev); >>       struct e1000_hw *hw = &adapter->hw; >>   +    rtdev_down(netdev); >>       igb_down(adapter); >>         pm_runtime_get_noresume(&pdev->dev); >> > > Is that igb-only? Or should be add such call to all driver removals? > This is a use case for the new rtnet_down() call applied to IGB which I'm interested in ATM. If the new up/down API is merged, all drivers should be updated the same way eventually. -- Philippe.