From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8FDFC433F5 for ; Wed, 6 Oct 2021 16:26:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97E7B60F3A for ; Wed, 6 Oct 2021 16:26:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239365AbhJFQ20 (ORCPT ); Wed, 6 Oct 2021 12:28:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230014AbhJFQ2Y (ORCPT ); Wed, 6 Oct 2021 12:28:24 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2FAD9C061746 for ; Wed, 6 Oct 2021 09:26:31 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY9kQ-0006Op-55; Wed, 06 Oct 2021 18:26:26 +0200 Message-ID: <45dc35aa5e7901051cd86f3461aab01d8604c746.camel@pengutronix.de> Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix From: Lucas Stach To: Tim Harvey , Shawn Guo , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 06 Oct 2021 18:26:24 +0200 In-Reply-To: <20211006153836.13760-1-tharvey@gateworks.com> References: <20211006153836.13760-1-tharvey@gateworks.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey: > Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the > GW7901 will hang during kernel init because it does not power the unused > GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this. > > We also disable the GPU devices that depend on the gpumix power domain > and pgc_gpu to avoid them staying in a probe deferred state forever. > > Additionally as the MIPI voltage rail is also not connected on this > board we disable pgc_mipi and disp_blk_ctrl. > > Signed-off-by: Tim Harvey Reviewed-by: Lucas Stach > --- > v2: > - also disable pgc_gpu to keep gpu from getting in probe deferred state > - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are > not connected > --- > .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > index bafd5c8ea4e2..21c546c4628d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > @@ -255,6 +255,10 @@ > }; > }; > > +&disp_blk_ctrl { > + status = "disabled"; > +}; > + > &ecspi1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi1>; > @@ -282,6 +286,14 @@ > }; > }; > > +&gpu_2d { > + status = "disabled"; > +}; > + > +&gpu_3d { > + status = "disabled"; > +}; > + > &i2c1 { > clock-frequency = <100000>; > pinctrl-names = "default"; > @@ -632,6 +644,18 @@ > status = "okay"; > }; > > +&pgc_gpu { > + status = "disabled"; > +}; > + > +&pgc_gpumix { > + status = "disabled"; > +}; > + > +&pgc_mipi { > + status = "disabled"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F781C433F5 for ; Wed, 6 Oct 2021 16:28:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2B9360F3A for ; Wed, 6 Oct 2021 16:28:04 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2B9360F3A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jXsSIPPcrSoETxR7ep9UCojap3kJAg2VLNlFxC1bBD8=; b=38hPfth7PRlZA1 A4Epbh94R+6f+l3iIttL/syvvUpdpES6PS10cYZUcVg0nao61aoOCktxC1q4ylZEoYKUvMYOZ2tWH ngnXjb3eVOPJvkdDWFfQ8n7jT3p3TmGRMRG7coWf2N4B5+v4L9s+/dxM6CUfqipfHW/S4mXfhyoeY akGMMpwCHLZSEJ7fdqSDEoLDqTmT2HU2n0FtbwyJ5H59YdYIuAuMCIXdF6Cd3eVVaOtYB4tJdfo0Y 7EI93DnVcCSdd5ubGHZnLo2YlH8GtNSbqaPPV2i6uGsotnxIysaKj1IB7ofuaJK4mR99OGY58JPhZ /BDtK4+CSoSs6PIHckCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY9kb-00EznM-2I; Wed, 06 Oct 2021 16:26:37 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mY9kX-00Ezly-Ct for linux-arm-kernel@lists.infradead.org; Wed, 06 Oct 2021 16:26:34 +0000 Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mY9kQ-0006Op-55; Wed, 06 Oct 2021 18:26:26 +0200 Message-ID: <45dc35aa5e7901051cd86f3461aab01d8604c746.camel@pengutronix.de> Subject: Re: [PATCH v2] arm64: dts: imx8mm-venice-gw7901.dts: disable pgc_gpumix From: Lucas Stach To: Tim Harvey , Shawn Guo , Rob Herring , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 06 Oct 2021 18:26:24 +0200 In-Reply-To: <20211006153836.13760-1-tharvey@gateworks.com> References: <20211006153836.13760-1-tharvey@gateworks.com> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211006_092633_467375_652A39DC X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, dem 06.10.2021 um 08:38 -0700 schrieb Tim Harvey: > Since commit b21269b12e48 ("arm64: dts: imx8mm: add GPC node") the > GW7901 will hang during kernel init because it does not power the unused > GPU voltage rails on the IMX8MM. Disable pgc_gpumix to work around this. > > We also disable the GPU devices that depend on the gpumix power domain > and pgc_gpu to avoid them staying in a probe deferred state forever. > > Additionally as the MIPI voltage rail is also not connected on this > board we disable pgc_mipi and disp_blk_ctrl. > > Signed-off-by: Tim Harvey Reviewed-by: Lucas Stach > --- > v2: > - also disable pgc_gpu to keep gpu from getting in probe deferred state > - also disable pgc_mipi and disp_blk_ctrl as the MIPI power rails are > not connected > --- > .../dts/freescale/imx8mm-venice-gw7901.dts | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > index bafd5c8ea4e2..21c546c4628d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mm-venice-gw7901.dts > @@ -255,6 +255,10 @@ > }; > }; > > +&disp_blk_ctrl { > + status = "disabled"; > +}; > + > &ecspi1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_spi1>; > @@ -282,6 +286,14 @@ > }; > }; > > +&gpu_2d { > + status = "disabled"; > +}; > + > +&gpu_3d { > + status = "disabled"; > +}; > + > &i2c1 { > clock-frequency = <100000>; > pinctrl-names = "default"; > @@ -632,6 +644,18 @@ > status = "okay"; > }; > > +&pgc_gpu { > + status = "disabled"; > +}; > + > +&pgc_gpumix { > + status = "disabled"; > +}; > + > +&pgc_mipi { > + status = "disabled"; > +}; > + > &uart1 { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_uart1>, <&pinctrl_uart1_gpio>; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel