From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH 06/18] drm/amdgpu/sriov:fix memory leak after gpu reset Date: Mon, 18 Sep 2017 13:34:32 +0200 Message-ID: <45fa4145-41a4-6186-4f35-4f3347bad601@amd.com> References: <1505715122-23904-1-git-send-email-Monk.Liu@amd.com> <1505715122-23904-7-git-send-email-Monk.Liu@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Monk" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" QW0gMTguMDkuMjAxNyB1bSAxMjo0NyBzY2hyaWViIExpdSwgTW9uazoKPiBJIGRpZG4ndCBnZXQg eW91ciBwb2ludC4uLiBob3cgY291bGQgYm9fY3JlYXRlX2tlcm5lbCBzb2x2ZSBteSBpc3N1ZSA/ CgpJdCBkb2Vzbid0IHNvbHZlIHRoZSB1bmRlcmx5aW5nIGlzc3VlLCB5b3UganVzdCBuZWVkIGxl c3MgY29kZSBmb3IgeW91ciAKd29ya2Fyb3VuZC4KCldpdGggYm9fY3JlYXRlX2tlcm5lbCB5b3Ug Y2FuIGRvIGNyZWF0ZS9waW4va21hcCBpbiBqdXN0IG9uZSBmdW5jdGlvbiBjYWxsLgoKPgo+IFRo ZSB0aGluZyBoZXJlIGlzIGR1cmluZyBncHUgcmVzZXQgd2UgaW52b2tlIGh3X2luaXQgZm9yIGV2 ZXJ5IGh3IGNvbXBvbmVudCwgYW5kIGJ5IGRlc2lnbiBod19pbml0IHNob3VsZG4ndCBkb2luZyBh bnl0aGluZyBzb2Z0d2FyZSByZWxhdGVkLCB0aHVzIHRoZSBCTyBhbGxvY2F0aW5nIGluIGh3X2lu aXQgaXMgd3JvbmcsCgpZZWFoLCBidXQgeW91ciBwYXRjaCBkb2Vzbid0IGZpeCB0aGF0IGVpdGhl ciBhcyBmYXIgYXMgSSBjYW4gc2VlLgoKPiBFdmVuIHN3aXRjaCB0byBib19jcmVhdGVfa2VybmVs IHdvbid0IGFkZHJlc3MgdGhlIGlzc3VlIC4uLgoKU2VlIHRoZSBpbXBsZW1lbnRhdGlvbiBvZiBi b19jcmVhdGVfa2VybmVsKCk6Cj4gICAgICAgICBpZiAoISpib19wdHIpIHsKPiAgICAgICAgICAg ICAgICAgciA9IGFtZGdwdV9ib19jcmVhdGUoYWRldiwgc2l6ZSwgYWxpZ24sIHRydWUsIGRvbWFp biwKLi4uLgo+ICAgICAgICAgfQouLi4uCj4gICAgICAgICByID0gYW1kZ3B1X2JvX3BpbigqYm9f cHRyLCBkb21haW4sIGdwdV9hZGRyKTsKLi4uCj4gICAgICAgICBpZiAoY3B1X2FkZHIpIHsKPiAg ICAgICAgICAgICAgICAgciA9IGFtZGdwdV9ib19rbWFwKCpib19wdHIsIGNwdV9hZGRyKTsKLi4u Cj4gICAgICAgICB9CgpDcmVhdGluZyBpcyBhY3R1YWxseSBvcHRpb25hbCwgYnV0IHRoZSBmdW5j dGlvbiBhbHdheXMgcGlucyB0aGUgQk8gb25jZSAKbW9yZSBhbmQgZmlndXJlcyBvdXQgaXQncyBD UFUgYWRkcmVzcy4KCkFzIGZhciBhcyBJIGNhbiBzZWUgdGhhdCBzaG91bGQgc29sdmUgeW91ciBw cm9ibGVtIGZvciBub3cuCgpDaHJpc3RpYW4uCgoKPgo+Cj4gQlIgTW9uawo+Cj4gLS0tLS1Pcmln aW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBDaHJpc3RpYW4gS8O2bmlnIFttYWlsdG86Y2tvZW5p Zy5sZWljaHR6dW1lcmtlbkBnbWFpbC5jb21dCj4gU2VudDogMjAxN+W5tDnmnIgxOOaXpSAxNzox Mwo+IFRvOiBMaXUsIE1vbmsgPE1vbmsuTGl1QGFtZC5jb20+OyBhbWQtZ2Z4QGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMDYvMThdIGRybS9hbWRncHUvc3Jpb3Y6 Zml4IG1lbW9yeSBsZWFrIGFmdGVyIGdwdSByZXNldAo+Cj4gQW0gMTguMDkuMjAxNyB1bSAwODox MSBzY2hyaWViIE1vbmsgTGl1Ogo+PiBkb2luZyBncHUgcmVzZXQgd2lsbCByZXJ1biBhbGwgaHdf aW5pdCBhbmQgdGh1cyB1Y29kZV9pbml0X2JvIGlzCj4+IGludm9rZWQgYWdhaW4sIHNvIHdlIG5l ZWQgdG8gc2tpcCB0aGUgZndfYnVmIGFsbG9jYXRpb24gZHVyaW5nIHNyaW92Cj4+IGdwdSByZXNl dCB0byBhdm9pZCBtZW1vcnkgbGVhay4KPj4KPj4gQ2hhbmdlLUlkOiBJMzExMzFlZGExYmQ0NWVh MmY1YmRjNTBjNWRhNWZjNWE5ZmU5MDI3ZAo+PiBTaWduZWQtb2ZmLWJ5OiBNb25rIExpdSA8TW9u ay5MaXVAYW1kLmNvbT4KPj4gLS0tCj4+ICAgIGRyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdS5oICAgICAgIHwgIDMgKysKPj4gICAgZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1k Z3B1X3Vjb2RlLmMgfCA2NCArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4+ICAgIDIg ZmlsZXMgY2hhbmdlZCwgMzUgaW5zZXJ0aW9ucygrKSwgMzIgZGVsZXRpb25zKC0pCj4+Cj4+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+PiBiL2RyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4+IGluZGV4IDZmZjI5NTkuLjNkMGM2MzMg MTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4+IEBAIC0xMTg1LDYgKzEx ODUsOSBAQCBzdHJ1Y3QgYW1kZ3B1X2Zpcm13YXJlIHsKPj4gICAgCj4+ICAgIAkvKiBncHUgaW5m byBmaXJtd2FyZSBkYXRhIHBvaW50ZXIgKi8KPj4gICAgCWNvbnN0IHN0cnVjdCBmaXJtd2FyZSAq Z3B1X2luZm9fZnc7Cj4+ICsKPj4gKwl2b2lkICpmd19idWZfcHRyOwo+PiArCXVpbnQ2NF90IGZ3 X2J1Zl9tYzsKPj4gICAgfTsKPj4gICAgCj4+ICAgIC8qCj4+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfdWNvZGUuYwo+PiBiL2RyaXZlcnMvZ3B1L2RybS9h bWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4+IGluZGV4IGYzMDYzNzQuLjY1NjQ5MDIgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4+ICsr KyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV91Y29kZS5jCj4+IEBAIC0zNjAs OCArMzYwLDYgQEAgc3RhdGljIGludCBhbWRncHVfdWNvZGVfcGF0Y2hfanQoc3RydWN0IGFtZGdw dV9maXJtd2FyZV9pbmZvICp1Y29kZSwKPj4gICAgaW50IGFtZGdwdV91Y29kZV9pbml0X2JvKHN0 cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+PiAgICB7Cj4+ICAgIAlzdHJ1Y3QgYW1kZ3B1X2Jv ICoqYm8gPSAmYWRldi0+ZmlybXdhcmUuZndfYnVmOwo+PiAtCXVpbnQ2NF90IGZ3X21jX2FkZHI7 Cj4+IC0Jdm9pZCAqZndfYnVmX3B0ciA9IE5VTEw7Cj4+ICAgIAl1aW50NjRfdCBmd19vZmZzZXQg PSAwOwo+PiAgICAJaW50IGksIGVycjsKPj4gICAgCXN0cnVjdCBhbWRncHVfZmlybXdhcmVfaW5m byAqdWNvZGUgPSBOVUxMOyBAQCAtMzcyLDM3ICszNzAsMzkgQEAKPj4gaW50IGFtZGdwdV91Y29k ZV9pbml0X2JvKHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2KQo+PiAgICAJCXJldHVybiAwOwo+ PiAgICAJfQo+PiAgICAKPj4gLQllcnIgPSBhbWRncHVfYm9fY3JlYXRlKGFkZXYsIGFkZXYtPmZp cm13YXJlLmZ3X3NpemUsIFBBR0VfU0laRSwgdHJ1ZSwKPj4gLQkJCQlhbWRncHVfc3Jpb3ZfdmYo YWRldikgPyBBTURHUFVfR0VNX0RPTUFJTl9WUkFNIDogQU1ER1BVX0dFTV9ET01BSU5fR1RULAo+ PiAtCQkJCUFNREdQVV9HRU1fQ1JFQVRFX1ZSQU1fQ09OVElHVU9VUywKPj4gLQkJCQlOVUxMLCBO VUxMLCAwLCBibyk7Cj4+IC0JaWYgKGVycikgewo+PiAtCQlkZXZfZXJyKGFkZXYtPmRldiwgIigl ZCkgRmlybXdhcmUgYnVmZmVyIGFsbG9jYXRlIGZhaWxlZFxuIiwgZXJyKTsKPj4gLQkJZ290byBm YWlsZWQ7Cj4+IC0JfQo+PiArCWlmICghYW1kZ3B1X3NyaW92X3ZmKGFkZXYpIHx8ICFhZGV2LT5p bl9zcmlvdl9yZXNldCkgewo+IEluc3RlYWQgb2YgYWxsIHRoaXMgYmV0dGVyIHVzZSBhbWRncHVf Ym9fY3JlYXRlX2tlcm5lbCgpLCB0aGlzIHNob3VsZCBhbHJlYWR5IGluY2x1ZGUgbW9zdCBvZiB0 aGUgaGFuZGxpbmcgbmVjZXNzYXJ5IGhlcmUuCj4KPiBDaHJpc3RpYW4uCj4KPj4gKwkJZXJyID0g YW1kZ3B1X2JvX2NyZWF0ZShhZGV2LCBhZGV2LT5maXJtd2FyZS5md19zaXplLCBQQUdFX1NJWkUs IHRydWUsCj4+ICsJCQkJCWFtZGdwdV9zcmlvdl92ZihhZGV2KSA/IEFNREdQVV9HRU1fRE9NQUlO X1ZSQU0gOiBBTURHUFVfR0VNX0RPTUFJTl9HVFQsCj4+ICsJCQkJCUFNREdQVV9HRU1fQ1JFQVRF X1ZSQU1fQ09OVElHVU9VUywKPj4gKwkJCQkJTlVMTCwgTlVMTCwgMCwgYm8pOwo+PiArCQlpZiAo ZXJyKSB7Cj4+ICsJCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIGFs bG9jYXRlIGZhaWxlZFxuIiwgZXJyKTsKPj4gKwkJCWdvdG8gZmFpbGVkOwo+PiArCQl9Cj4+ICAg IAo+PiAtCWVyciA9IGFtZGdwdV9ib19yZXNlcnZlKCpibywgZmFsc2UpOwo+PiAtCWlmIChlcnIp IHsKPj4gLQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciByZXNlcnZl IGZhaWxlZFxuIiwgZXJyKTsKPj4gLQkJZ290byBmYWlsZWRfcmVzZXJ2ZTsKPj4gLQl9Cj4+ICsJ CWVyciA9IGFtZGdwdV9ib19yZXNlcnZlKCpibywgZmFsc2UpOwo+PiArCQlpZiAoZXJyKSB7Cj4+ ICsJCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIHJlc2VydmUgZmFp bGVkXG4iLCBlcnIpOwo+PiArCQkJZ290byBmYWlsZWRfcmVzZXJ2ZTsKPj4gKwkJfQo+PiAgICAK Pj4gLQllcnIgPSBhbWRncHVfYm9fcGluKCpibywgYW1kZ3B1X3NyaW92X3ZmKGFkZXYpID8gQU1E R1BVX0dFTV9ET01BSU5fVlJBTSA6IEFNREdQVV9HRU1fRE9NQUlOX0dUVCwKPj4gLQkJCQkmZndf bWNfYWRkcik7Cj4+IC0JaWYgKGVycikgewo+PiAtCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkg RmlybXdhcmUgYnVmZmVyIHBpbiBmYWlsZWRcbiIsIGVycik7Cj4+IC0JCWdvdG8gZmFpbGVkX3Bp bjsKPj4gLQl9Cj4+ICsJCWVyciA9IGFtZGdwdV9ib19waW4oKmJvLCBhbWRncHVfc3Jpb3ZfdmYo YWRldikgPyBBTURHUFVfR0VNX0RPTUFJTl9WUkFNIDogQU1ER1BVX0dFTV9ET01BSU5fR1RULAo+ PiArCQkJCQkmYWRldi0+ZmlybXdhcmUuZndfYnVmX21jKTsKPj4gKwkJaWYgKGVycikgewo+PiAr CQkJZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBwaW4gZmFpbGVkXG4i LCBlcnIpOwo+PiArCQkJZ290byBmYWlsZWRfcGluOwo+PiArCQl9Cj4+ICAgIAo+PiAtCWVyciA9 IGFtZGdwdV9ib19rbWFwKCpibywgJmZ3X2J1Zl9wdHIpOwo+PiAtCWlmIChlcnIpIHsKPj4gLQkJ ZGV2X2VycihhZGV2LT5kZXYsICIoJWQpIEZpcm13YXJlIGJ1ZmZlciBrbWFwIGZhaWxlZFxuIiwg ZXJyKTsKPj4gLQkJZ290byBmYWlsZWRfa21hcDsKPj4gLQl9Cj4+ICsJCWVyciA9IGFtZGdwdV9i b19rbWFwKCpibywgJmFkZXYtPmZpcm13YXJlLmZ3X2J1Zl9wdHIpOwo+PiArCQlpZiAoZXJyKSB7 Cj4+ICsJCQlkZXZfZXJyKGFkZXYtPmRldiwgIiglZCkgRmlybXdhcmUgYnVmZmVyIGttYXAgZmFp bGVkXG4iLCBlcnIpOwo+PiArCQkJZ290byBmYWlsZWRfa21hcDsKPj4gKwkJfQo+PiAgICAKPj4g LQlhbWRncHVfYm9fdW5yZXNlcnZlKCpibyk7Cj4+ICsJCWFtZGdwdV9ib191bnJlc2VydmUoKmJv KTsKPj4gKwl9Cj4+ICAgIAo+PiAtCW1lbXNldChmd19idWZfcHRyLCAwLCBhZGV2LT5maXJtd2Fy ZS5md19zaXplKTsKPj4gKwltZW1zZXQoYWRldi0+ZmlybXdhcmUuZndfYnVmX3B0ciwgMCwgYWRl di0+ZmlybXdhcmUuZndfc2l6ZSk7Cj4+ICAgIAo+PiAgICAJLyoKPj4gICAgCSAqIGlmIFNNVSBs b2FkZWQgZmlybXdhcmUsIGl0IG5lZWRuJ3QgYWRkIFNNQywgVVZELCBhbmQgVkNFIEBACj4+IC00 MjEsMTQgKzQyMSwxNCBAQCBpbnQgYW1kZ3B1X3Vjb2RlX2luaXRfYm8oc3RydWN0IGFtZGdwdV9k ZXZpY2UgKmFkZXYpCj4+ICAgIAkJdWNvZGUgPSAmYWRldi0+ZmlybXdhcmUudWNvZGVbaV07Cj4+ ICAgIAkJaWYgKHVjb2RlLT5mdykgewo+PiAgICAJCQloZWFkZXIgPSAoY29uc3Qgc3RydWN0IGNv bW1vbl9maXJtd2FyZV9oZWFkZXIgKil1Y29kZS0+ZnctPmRhdGE7Cj4+IC0JCQlhbWRncHVfdWNv ZGVfaW5pdF9zaW5nbGVfZncoYWRldiwgdWNvZGUsIGZ3X21jX2FkZHIgKyBmd19vZmZzZXQsCj4+ IC0JCQkJCQkgICAgKHZvaWQgKikoKHVpbnQ4X3QgKilmd19idWZfcHRyICsgZndfb2Zmc2V0KSk7 Cj4+ICsJCQlhbWRncHVfdWNvZGVfaW5pdF9zaW5nbGVfZncoYWRldiwgdWNvZGUsIGFkZXYtPmZp cm13YXJlLmZ3X2J1Zl9tYyArIGZ3X29mZnNldCwKPj4gKwkJCQkJCSAgICBhZGV2LT5maXJtd2Fy ZS5md19idWZfcHRyICsgZndfb2Zmc2V0KTsKPj4gICAgCQkJaWYgKGkgPT0gQU1ER1BVX1VDT0RF X0lEX0NQX01FQzEgJiYKPj4gICAgCQkJICAgIGFkZXYtPmZpcm13YXJlLmxvYWRfdHlwZSAhPSBB TURHUFVfRldfTE9BRF9QU1ApIHsKPj4gICAgCQkJCWNvbnN0IHN0cnVjdCBnZnhfZmlybXdhcmVf aGVhZGVyX3YxXzAgKmNwX2hkcjsKPj4gICAgCQkJCWNwX2hkciA9IChjb25zdCBzdHJ1Y3QgZ2Z4 X2Zpcm13YXJlX2hlYWRlcl92MV8wICopdWNvZGUtPmZ3LT5kYXRhOwo+PiAtCQkJCWFtZGdwdV91 Y29kZV9wYXRjaF9qdCh1Y29kZSwgZndfbWNfYWRkciArIGZ3X29mZnNldCwKPj4gLQkJCQkJCSAg ICBmd19idWZfcHRyICsgZndfb2Zmc2V0KTsKPj4gKwkJCQlhbWRncHVfdWNvZGVfcGF0Y2hfanQo dWNvZGUsICBhZGV2LT5maXJtd2FyZS5md19idWZfbWMgKyBmd19vZmZzZXQsCj4+ICsJCQkJCQkg ICAgYWRldi0+ZmlybXdhcmUuZndfYnVmX3B0ciArIGZ3X29mZnNldCk7Cj4+ICAgIAkJCQlmd19v ZmZzZXQgKz0gQUxJR04obGUzMl90b19jcHUoY3BfaGRyLT5qdF9zaXplKSA8PCAyLCBQQUdFX1NJ WkUpOwo+PiAgICAJCQl9Cj4+ICAgIAkJCWZ3X29mZnNldCArPSBBTElHTih1Y29kZS0+dWNvZGVf c2l6ZSwgUEFHRV9TSVpFKTsKPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQt Z2Z4Cg==