All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Grandegger <wg@domain.hid>
To: "Hartkopp, Oliver (K-GEFE/E)" <oliver.hartkopp@domain.hid>
Cc: socketcan-core@domain.hid, Oliver Hartkopp <socketcan@domain.hid>,
	Jan Kiszka <jan.kiszka@domain.hid>,
	xenomai-core <xenomai@xenomai.org>
Subject: [Xenomai-core] Re: RT-Socket-CAN bus error rate and latencies
Date: Thu, 22 Mar 2007 09:12:29 +0100	[thread overview]
Message-ID: <46023A6D.5010002@domain.hid> (raw)
In-Reply-To: <460237BD.1020205@domain.hid>

Hartkopp, Oliver (K-GEFE/E) wrote:
> Even if i know, that my reply with our f*cking exchange mailserver will 
> break the thread ...
> 
> Jan Kiszka wrote:
>> I think Oliver's suggestions points in the right direction. But instead
>> of only coding a timer into the stack, I still vote for closing the loop
>> over the application:
>>
>> After the first error in a potential series, the related error frame is
>> queued, listeners are woken up, and BEI is disabled for now. Once some
>> listener read the error frame *and* decided to call into the stack for
>> further bus errors, BEI is enabled again.
>>
>>   
> IMO this is really a good idea! Even if it look just a bit different on 
> (non-RT) socketcan, the procedure could look like this:
> 
> 1. BEI occurs => disable BEI & lauch receiption of one error frame for 
> the user
> 2. Wait for user interaction
> 
> I would suggest to create an IOCTL, where you can define, if you only 
> want to receive one BE-frame (== default!) or every BE-frame (may flood 
> your system). After an occurance of a BEI the BE-frames are disabled (in 
> the default case) until the user decides to reenable it via the 
> suggested IOCTL.
> 
> Does this look acceptable to you?

No extra IOCTL please. I would place re-enabling of BEI in sendmsg.

> Btw. Currently the enabling of error frames (in socketcan) currently 
> does not depend on subscribed listeners (what is definitely a good idea!).

Why?

Wolfgang.



       reply	other threads:[~2007-03-22  8:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <460237BD.1020205@domain.hid>
2007-03-22  8:12 ` Wolfgang Grandegger [this message]
2007-03-20 18:58 [Xenomai-core] RT-Socket-CAN bus error rate and latencies Wolfgang Grandegger
2007-03-21 17:14 ` [Xenomai-core] " Wolfgang Grandegger
     [not found]   ` <46017CA7.2080801@domain.hid>
2007-03-21 20:29     ` Wolfgang Grandegger
2007-03-21 21:43       ` Jan Kiszka
2007-03-22  8:08         ` Wolfgang Grandegger
     [not found]           ` <46036D32.7000603@domain.hid>
     [not found]             ` <46036F22.60709@domain.hid>
2007-03-23  8:34               ` Jan Kiszka
2007-03-23  8:51                 ` Wolfgang Grandegger
2007-03-24 11:51                   ` Wolfgang Grandegger
2007-03-24 13:38                     ` Jan Kiszka
2007-04-02 16:22                       ` Wolfgang Grandegger
2007-04-07 21:03                         ` Jan Kiszka
2007-04-07 21:12                           ` Wolfgang Grandegger
2007-03-23  8:37             ` Wolfgang Grandegger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46023A6D.5010002@domain.hid \
    --to=wg@domain.hid \
    --cc=jan.kiszka@domain.hid \
    --cc=oliver.hartkopp@domain.hid \
    --cc=socketcan-core@domain.hid \
    --cc=socketcan@domain.hid \
    --cc=xenomai@xenomai.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.