From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from de01egw02.freescale.net (de01egw02.freescale.net [192.88.165.103]) by ozlabs.org (Postfix) with ESMTP id 07F46DDE3B for ; Sat, 24 Mar 2007 03:54:17 +1100 (EST) Message-ID: <46040634.3040200@freescale.com> Date: Fri, 23 Mar 2007 11:54:12 -0500 From: Timur Tabi MIME-Version: 1.0 To: Segher Boessenkool Subject: Re: [PATCH 10/17] bootwrapper: Add dt_set_mac_addresses(). References: <20070317013159.GH3969@localhost.localdomain> <45FC8643.1080807@freescale.com> <20070318115656.GA12765@localhost.localdomain> <45FEA7B3.9090304@freescale.com> <20070320035957.GC21124@localhost.localdomain> <45FFE8FD.9020902@freescale.com> <20070321025447.GG27969@localhost.localdomain> <460148DC.3020600@freescale.com> <20070322000620.GC2295@localhost.localdomain> <1174576516.6595.542.camel@ld0161-tx32> <20070323032214.GC28006@localhost.localdomain> <4603E648.4030907@freescale.com> <4604035F.8070703@freescale.com> <10eb99e3d4037e36ba32d136f0e2bb52@kernel.crashing.org> In-Reply-To: <10eb99e3d4037e36ba32d136f0e2bb52@kernel.crashing.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Cc: linuxppc-dev@ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Segher Boessenkool wrote: >> No, because that might break of_get_mac_address() which considers an >> all-zero MAC address to be invalid. > > If you want to default a certain field, you shouldn't set it > to ? ? ? ?, but to the default value you have in mind :-) Fair enough, but then we can't use it for local-mac-address, which was the whole point behind this discussion! So you can use ? for every property *except* local-mac-address. If it's going to be this complicated, I say forget the whole thing. -- Timur Tabi Linux Kernel Developer @ Freescale