* [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed
@ 2007-02-11 3:04 Horms
2007-03-06 4:45 ` David Miller
2007-03-27 1:04 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Horms @ 2007-02-11 3:04 UTC (permalink / raw)
To: netdev
Cc: Janusz Krzysztofik, Julian Anastasov, Wensong Zhang,
Joseph Mack NA3T, Roberto Nibali
Hi,
this is a small patch by Janusz Krzysztofik to ip_route_output_slow()
that allows VIP-less LVS linux director to generate packets originating
>From VIP if sysctl_ip_nonlocal_bind is set.
In a nutshell, the intention is for an LVS linux director to be able
to send ICMP unreachable responses to end-users when real-servers are
removed.
http://archive.linuxvirtualserver.org/html/lvs-users/2007-01/msg00106.html
I'm not really sure about the correctness of this approach,
so I am sending it here to netdev for review
Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Signed-off-by: Simon Horman <horms@verge.net.au>
Index: net-2.6/net/ipv4/route.c
===================================================================
--- net-2.6.orig/net/ipv4/route.c 2007-02-11 11:46:08.000000000 +0900
+++ net-2.6/net/ipv4/route.c 2007-02-11 11:46:23.000000000 +0900
@@ -2397,7 +2397,7 @@
/* It is equivalent to inet_addr_type(saddr) == RTN_LOCAL */
dev_out = ip_dev_find(oldflp->fl4_src);
- if (dev_out == NULL)
+ if ((dev_out == NULL) && !(sysctl_ip_nonlocal_bind))
goto out;
/* I removed check for oif == dev_out->oif here.
@@ -2408,7 +2408,7 @@
of another iface. --ANK
*/
- if (oldflp->oif == 0
+ if (dev_out && oldflp->oif == 0
&& (MULTICAST(oldflp->fl4_dst) || oldflp->fl4_dst == htonl(0xFFFFFFFF))) {
/* Special hack: user can direct multicasts
and limited broadcast via necessary interface
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed
2007-02-11 3:04 [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed Horms
@ 2007-03-06 4:45 ` David Miller
2007-03-27 1:04 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2007-03-06 4:45 UTC (permalink / raw)
To: horms; +Cc: netdev, jkrzyszt, ja, wensong, jmack, ratz
From: Horms <horms@verge.net.au>
Date: Sun, 11 Feb 2007 12:04:43 +0900
> this is a small patch by Janusz Krzysztofik to ip_route_output_slow()
> that allows VIP-less LVS linux director to generate packets originating
> >From VIP if sysctl_ip_nonlocal_bind is set.
>
> In a nutshell, the intention is for an LVS linux director to be able
> to send ICMP unreachable responses to end-users when real-servers are
> removed.
>
> http://archive.linuxvirtualserver.org/html/lvs-users/2007-01/msg00106.html
>
> I'm not really sure about the correctness of this approach,
> so I am sending it here to netdev for review
>
> Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> Signed-off-by: Simon Horman <horms@verge.net.au>
I'm not against this patch or the idea, I just want to
think about it some more to make sure there are not bad
unintended side effects to allowing this.
If someone else could provide some feedback or comments,
I'd very much appreciate that as well.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed
2007-02-11 3:04 [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed Horms
2007-03-06 4:45 ` David Miller
@ 2007-03-27 1:04 ` David Miller
2007-03-27 10:53 ` Janusz Krzysztofik
1 sibling, 1 reply; 4+ messages in thread
From: David Miller @ 2007-03-27 1:04 UTC (permalink / raw)
To: horms; +Cc: netdev, jkrzyszt, ja, wensong, jmack, ratz
From: Horms <horms@verge.net.au>
Date: Sun, 11 Feb 2007 12:04:43 +0900
> Hi,
>
> this is a small patch by Janusz Krzysztofik to ip_route_output_slow()
> that allows VIP-less LVS linux director to generate packets originating
> >From VIP if sysctl_ip_nonlocal_bind is set.
>
> In a nutshell, the intention is for an LVS linux director to be able
> to send ICMP unreachable responses to end-users when real-servers are
> removed.
>
> http://archive.linuxvirtualserver.org/html/lvs-users/2007-01/msg00106.html
>
> I'm not really sure about the correctness of this approach,
> so I am sending it here to netdev for review
>
> Cc: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Applied to net-2.6.22, thanks Simon.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed
2007-03-27 1:04 ` David Miller
@ 2007-03-27 10:53 ` Janusz Krzysztofik
0 siblings, 0 replies; 4+ messages in thread
From: Janusz Krzysztofik @ 2007-03-27 10:53 UTC (permalink / raw)
To: David Miller; +Cc: horms, netdev, ja, wensong, jmack, ratz
David Miller wrote:
>> this is a small patch by Janusz Krzysztofik to ip_route_output_slow()
>> that allows VIP-less LVS linux director to generate packets originating
>> >From VIP if sysctl_ip_nonlocal_bind is set.
>
> Applied to net-2.6.22, thanks Simon.
Thank you,
Janusz
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-27 10:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-02-11 3:04 [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed Horms
2007-03-06 4:45 ` David Miller
2007-03-27 1:04 ` David Miller
2007-03-27 10:53 ` Janusz Krzysztofik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.