All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sunil Mushran <Sunil.Mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 0/3] Properly protect the extent map
Date: Thu Mar 29 09:41:35 2007	[thread overview]
Message-ID: <460BEC3A.2050009@oracle.com> (raw)
In-Reply-To: <460B7B00.30004@ubuntu.com>

Thanks Fabbio. Yes, we'll schedule the test on the big cluster after the
1.2.5 release run. Next week, I hope.

Fabio Massimo Di Nitto wrote:
> Joel Becker wrote:
>   
>> The extent map code was seeing an error trip when inserting records.
>> There is a sanity check ensuring that the new record is within the known
>> size of the file - as known by the extent map.  The problem was that the
>> "known" size was smaller than expected, returning an error to the caller.
>>
>> This is a lot easier to see in local mounts.  It has only been rarely seen
>> in clusters.
>>
>> We have three "independant" problems.
>>
>> 1) We don't take ip_alloc_sem when touching directory allocations.
>> 2) We don't lock em_clusters properly.
>> 3) Local mounts race to ocfs2_extent_map_trunc() in ocfs2_meta_lock_update().
>>
>> The patches that follow are against mainline.  They have been tested
>> against 1.2 with local mounts.
>>
>> Patches (1) and (2) will be ported to the ocfs2 1.2 branch directly,
>> and all three fixes will be pushed to mainline.
>>
>> Joel
>>     
>
> add a
>
> Signed-off-by: Fabio M. Di Nitto <fabbione@ubuntu.com>
>
> on all 3 of them. They fix the problem as i reported it, but it looks like they
> introduce a performance hit. Somebody other than me should test it too.
>
> Fabio
>
>   

  reply	other threads:[~2007-03-29  9:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-28 18:50 [Ocfs2-devel] [PATCH 0/3] Properly protect the extent map Joel Becker
2007-03-28 18:50 ` [Ocfs2-devel] [PATCH 1/3] ocfs2: Wrap access of directory allocations with ip_alloc_sem Joel Becker
2007-03-28 18:51 ` [Ocfs2-devel] [PATCH 2/3] ocfs2: Properly lock extent map size changes Joel Becker
2007-03-28 18:51 ` [Ocfs2-devel] [PATCH 3/3] ocfs2: Local mounts should not truncate the extent map Joel Becker
2007-03-29  2:04 ` [Ocfs2-devel] [PATCH 0/3] Properly protect " Fabio Massimo Di Nitto
2007-03-29  9:41   ` Sunil Mushran [this message]
2007-04-02 11:45   ` Mark Fasheh
2007-04-02 11:48     ` Fabio Massimo Di Nitto
2007-04-02 11:58       ` Mark Fasheh
2007-04-02 12:00         ` Fabio Massimo Di Nitto
2007-04-02 11:47 ` Mark Fasheh
2007-04-02 16:55   ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=460BEC3A.2050009@oracle.com \
    --to=sunil.mushran@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.