From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] SVM: enable LBRV virtualization if available Date: Fri, 30 Mar 2007 17:04:29 +0300 Message-ID: <460D18ED.909@qumranet.com> References: <20070330122153.GO6644@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Joerg Roedel Return-path: In-Reply-To: <20070330122153.GO6644-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Joerg Roedel wrote: > From: Joerg Roedel > > This patch enables the virtualization of the last branch record MSRs on > SVM if this feature is available in hardware. It also introduces a small > and simple check feature for specific SVM extensions. > > +#define SVM_DEATURE_SVML (1 << 2) > FEATURE? DENTURE? > + > +#define svm_has(feat) (svm_features & (feat)) > + > I prefer a static inline instead of a function-like macro. > unsigned long iopm_base; > unsigned long msrpm_base; > > @@ -68,6 +74,7 @@ struct svm_cpu_data { > }; > > static DEFINE_PER_CPU(struct svm_cpu_data *, svm_data); > +static uint32_t svm_features; > u32 outside userspace headers. Anyway I fixed these up and applied. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV