From: Julien Grall <julien@xen.org>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Vikram Garhwal <vikram.garhwal@amd.com>,
qemu-devel@nongnu.org, stefano.stabellini@amd.com,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Perard <anthony.perard@citrix.com>,
Paul Durrant <paul@xen.org>,
"open list:ARM TCG CPUs" <qemu-arm@nongnu.org>,
"open list:X86 Xen CPUs" <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v1 10/12] hw/arm: introduce xenpv machine
Date: Tue, 18 Oct 2022 09:24:48 +0100 [thread overview]
Message-ID: <460a480e-4e91-8d78-60da-59b9cc98beee@xen.org> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2210171345450.2351079@ubuntu-linux-20-04-desktop>
Hi Stefano,
On 18/10/2022 02:26, Stefano Stabellini wrote:
> On Sun, 16 Oct 2022, Julien Grall wrote:
>> Hi,
>>
>> There seem to be some missing patches on xen-devel (including the cover
>> letter). Is that expected?
>>
>> On 15/10/2022 06:07, Vikram Garhwal wrote:
>>> Add a new machine xenpv which creates a IOREQ server to register/connect
>>> with
>>> Xen Hypervisor.
>>
>> I don't like the name 'xenpv' because it doesn't convey the fact that some of
>> the HW may be emulated rather than para-virtualized. In fact one may only want
>> to use for emulating devices.
>>
>> Potential name would be 'xen-arm' or re-using 'virt' but with 'accel=xen' to
>> select a Xen layout.
>
> The benefit of 'xenpv' is that it doesn't require any changes to libxl.
I am quite surprised. Looking at the code, it seems to work more by
chance than it is intentional as the code is gated by
libxl__need_xenpv_qemu(). So it would not start if there were no
emulated devices.
> It is even backward compatible so it could be used with an older version
> of Xen/libxl.
We don't really gain much here. IOREQ is a tech preview and anyone that
wants to try it should really use the latest Xen.
> Backward compatibility aside, if we come up with a
> different name then we'll need changes to libxl and to manage those
> changes. For instance, if we use 'xen-arm' that would mean we would need
> to handle per-arch QEMU machine names.
Right, so the main argument here is for simplicity in libxl
Looking at how 'xenpv' is built, this is really expected to deal with PV
backend rather than emulated device. I do expect some changes as we go
along to be able to add emulated device.
Furthermore, libxl is not the only toolstack out. So I am not convinced
this is a good argument to keep the name the same.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2022-10-18 8:38 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-15 5:07 [PATCH v1 00/12] Introduce xenpv machine for arm architecture Vikram Garhwal
2022-10-15 5:07 ` [PATCH v1 01/12] hw/xen: Correct build config for xen_pt_stub Vikram Garhwal
2022-10-19 14:46 ` Paul Durrant
2022-10-26 19:01 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 02/12] hw/i386/xen/: move xen-mapcache.c to hw/xen/ Vikram Garhwal
2022-10-19 14:53 ` Paul Durrant
2022-12-01 20:25 ` Garhwal, Vikram
2022-10-15 5:07 ` [PATCH v1 03/12] hw/i386/xen: rearrange xen_hvm_init_pc Vikram Garhwal
2022-10-19 14:59 ` Paul Durrant
2022-10-15 5:07 ` [PATCH v1 04/12] hw/i386/xen/xen-hvm: move x86-specific fields out of XenIOState Vikram Garhwal
2022-10-19 15:56 ` Paul Durrant
2022-10-19 16:00 ` Paul Durrant
2022-10-27 8:59 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 05/12] hw/i386/xen/xen-hvm: create arch_handle_ioreq and arch_xen_set_memory Vikram Garhwal
2022-10-19 16:09 ` Paul Durrant
2022-10-27 9:02 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 06/12] xen-hvm: move common functions to hw/xen/xen-hvm-common.c Vikram Garhwal
2022-10-16 18:07 ` Julien Grall
2022-10-19 16:16 ` Paul Durrant
2022-10-19 23:12 ` Garhwal, Vikram
2022-10-15 5:07 ` [PATCH v1 07/12] include/hw/xen/xen_common: return error from xen_create_ioreq_server Vikram Garhwal
2022-10-16 17:53 ` Julien Grall
2022-10-15 5:07 ` [PATCH v1 08/12] hw/xen/xen-hvm-common: skip ioreq creation on ioreq registration failure Vikram Garhwal
2022-10-27 8:46 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 09/12] accel/xen/xen-all: export xenstore_record_dm_state Vikram Garhwal
2022-10-19 16:20 ` Paul Durrant
2022-10-27 9:14 ` Alex Bennée
2022-10-28 20:26 ` Oleksandr Tyshchenko
2022-10-29 5:36 ` Vikram Garhwal
2022-10-29 5:22 ` Garhwal, Vikram
2022-11-01 11:29 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 10/12] hw/arm: introduce xenpv machine Vikram Garhwal
2022-10-16 17:47 ` Julien Grall
2022-10-18 1:26 ` Stefano Stabellini
2022-10-18 8:24 ` Julien Grall [this message]
2022-10-19 0:15 ` Stefano Stabellini
2022-10-19 9:49 ` Julien Grall
2022-10-27 8:37 ` Alex Bennée
2022-12-02 3:24 ` Garhwal, Vikram
2022-12-02 9:53 ` Julien Grall
2022-10-27 8:02 ` Alex Bennée
2022-10-28 17:57 ` Julien Grall
2022-10-28 19:05 ` Oleksandr Tyshchenko
2022-10-27 8:40 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 11/12] meson.build: enable xenpv machine build for ARM Vikram Garhwal
2022-10-27 9:11 ` Alex Bennée
2022-10-15 5:07 ` [PATCH v1 12/12] meson.build: do not set have_xen_pci_passthrough for aarch64 targets Vikram Garhwal
2022-10-27 9:14 ` Alex Bennée
2022-10-27 8:26 ` [PATCH v1 00/12] Introduce xenpv machine for arm architecture Alex Bennée
2022-10-27 9:24 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460a480e-4e91-8d78-60da-59b9cc98beee@xen.org \
--to=julien@xen.org \
--cc=anthony.perard@citrix.com \
--cc=paul@xen.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=stefano.stabellini@amd.com \
--cc=vikram.garhwal@amd.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.