From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFFEAC6FD1F for ; Tue, 14 Mar 2023 03:29:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD8B685900; Tue, 14 Mar 2023 04:29:55 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 63BF585DF9; Tue, 14 Mar 2023 04:29:53 +0100 (CET) Received: from mail-m11874.qiye.163.com (mail-m11874.qiye.163.com [115.236.118.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 69B5D858FF for ; Tue, 14 Mar 2023 04:29:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11874.qiye.163.com (Hmail) with ESMTPA id 8D9763C01C0; Tue, 14 Mar 2023 11:29:35 +0800 (CST) Message-ID: <461231ab-7b69-a211-4a71-e1284ed7a8b3@rock-chips.com> Date: Tue, 14 Mar 2023 11:29:35 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH 11/12] rockchip: include: configs: Remove unused SDRAM_BANK_SIZE Content-Language: en-US To: Jonas Karlman , Simon Glass , Philipp Tomsich , Quentin Schulz , Klaus Goger , Levin Du , Suniel Mahesh , Manivannan Sadhasivam , Akash Gajjar , Jagan Teki Cc: Jagan Teki , Eugen Hristev , u-boot@lists.denx.de References: <20230314003755.512696-1-jonas@kwiboo.se> <20230314003755.512696-12-jonas@kwiboo.se> From: Kever Yang In-Reply-To: <20230314003755.512696-12-jonas@kwiboo.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQh5PSlYYH05MHU5DTB1PGE9VEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSkpLSE5IVUpLS1VLWQ Y+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Ogw6Sgw*Hz0cPS0KDkM5DAoI DDgwCQNVSlVKTUxDTE1PTkxNT0hOVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFMQk1PNwY+ X-HM-Tid: 0a86de2a8c862eb0kusn8d9763c01c0 X-HM-MType: 1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 2023/3/14 08:38, Jonas Karlman wrote: > Remove unused SDRAM_BANK_SIZE define. > > Signed-off-by: Jonas Karlman Reviewed-by: Kever Yang Thanks, - Kever > --- > include/configs/evb_rk3328.h | 2 -- > include/configs/evb_rk3399.h | 2 -- > include/configs/pinebook-pro-rk3399.h | 2 -- > include/configs/pinephone-pro-rk3399.h | 2 -- > include/configs/puma_rk3399.h | 2 -- > include/configs/px30_common.h | 1 - > include/configs/rk3188_common.h | 1 - > include/configs/rk322x_common.h | 1 - > include/configs/rk3288_common.h | 1 - > include/configs/rk3308_common.h | 1 - > include/configs/roc-pc-rk3399.h | 2 -- > include/configs/rock960_rk3399.h | 1 - > include/configs/rockpro64_rk3399.h | 1 - > 13 files changed, 19 deletions(-) > > diff --git a/include/configs/evb_rk3328.h b/include/configs/evb_rk3328.h > index cac613d021a8..d10e5b1d2e03 100644 > --- a/include/configs/evb_rk3328.h > +++ b/include/configs/evb_rk3328.h > @@ -8,6 +8,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/evb_rk3399.h b/include/configs/evb_rk3399.h > index b7e850370b31..70ab587795e2 100644 > --- a/include/configs/evb_rk3399.h > +++ b/include/configs/evb_rk3399.h > @@ -13,6 +13,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/pinebook-pro-rk3399.h b/include/configs/pinebook-pro-rk3399.h > index 241dc39be008..141ffcd036bb 100644 > --- a/include/configs/pinebook-pro-rk3399.h > +++ b/include/configs/pinebook-pro-rk3399.h > @@ -14,6 +14,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/pinephone-pro-rk3399.h b/include/configs/pinephone-pro-rk3399.h > index 78017d6bcc37..9cd444734392 100644 > --- a/include/configs/pinephone-pro-rk3399.h > +++ b/include/configs/pinephone-pro-rk3399.h > @@ -14,6 +14,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/puma_rk3399.h b/include/configs/puma_rk3399.h > index 23de326e7208..969acc89b937 100644 > --- a/include/configs/puma_rk3399.h > +++ b/include/configs/puma_rk3399.h > @@ -8,6 +8,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/px30_common.h b/include/configs/px30_common.h > index c0896e5f6281..8df481b09788 100644 > --- a/include/configs/px30_common.h > +++ b/include/configs/px30_common.h > @@ -15,7 +15,6 @@ > > #define CFG_SYS_SDRAM_BASE 0 > #define SDRAM_MAX_SIZE 0xff000000 > -#define SDRAM_BANK_SIZE (2UL << 30) > > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x00500000\0" \ > diff --git a/include/configs/rk3188_common.h b/include/configs/rk3188_common.h > index ebb421c69297..fcb274565e9e 100644 > --- a/include/configs/rk3188_common.h > +++ b/include/configs/rk3188_common.h > @@ -12,7 +12,6 @@ > #define CFG_IRAM_BASE 0x10080000 > > #define CFG_SYS_SDRAM_BASE 0x60000000 > -#define SDRAM_BANK_SIZE (2UL << 30) > #define SDRAM_MAX_SIZE 0x80000000 > > #define ENV_MEM_LAYOUT_SETTINGS \ > diff --git a/include/configs/rk322x_common.h b/include/configs/rk322x_common.h > index fcaf9c52c4be..39a40f4e2d10 100644 > --- a/include/configs/rk322x_common.h > +++ b/include/configs/rk322x_common.h > @@ -13,7 +13,6 @@ > #define CFG_IRAM_BASE 0x10080000 > > #define CFG_SYS_SDRAM_BASE 0x60000000 > -#define SDRAM_BANK_SIZE (512UL << 20UL) > #define SDRAM_MAX_SIZE 0x80000000 > > #define ENV_MEM_LAYOUT_SETTINGS \ > diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h > index fa409c70c931..71d2426d72a4 100644 > --- a/include/configs/rk3288_common.h > +++ b/include/configs/rk3288_common.h > @@ -14,7 +14,6 @@ > #define CFG_IRAM_BASE 0xff700000 > > #define CFG_SYS_SDRAM_BASE 0 > -#define SDRAM_BANK_SIZE (2UL << 30) > #define SDRAM_MAX_SIZE 0xfe000000 > > #define ENV_MEM_LAYOUT_SETTINGS \ > diff --git a/include/configs/rk3308_common.h b/include/configs/rk3308_common.h > index 55a0dfecb21b..ba9ee112e2df 100644 > --- a/include/configs/rk3308_common.h > +++ b/include/configs/rk3308_common.h > @@ -12,7 +12,6 @@ > > #define CFG_SYS_SDRAM_BASE 0 > #define SDRAM_MAX_SIZE 0xff000000 > -#define SDRAM_BANK_SIZE (2UL << 30) > > #define ENV_MEM_LAYOUT_SETTINGS \ > "scriptaddr=0x00500000\0" \ > diff --git a/include/configs/roc-pc-rk3399.h b/include/configs/roc-pc-rk3399.h > index 59fe22289cff..f99871cb9fc5 100644 > --- a/include/configs/roc-pc-rk3399.h > +++ b/include/configs/roc-pc-rk3399.h > @@ -13,6 +13,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > - > #endif > diff --git a/include/configs/rock960_rk3399.h b/include/configs/rock960_rk3399.h > index 6099d2fa55a6..b85978115f5b 100644 > --- a/include/configs/rock960_rk3399.h > +++ b/include/configs/rock960_rk3399.h > @@ -13,5 +13,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > #endif > diff --git a/include/configs/rockpro64_rk3399.h b/include/configs/rockpro64_rk3399.h > index 9195b9b99e41..5381efac3f63 100644 > --- a/include/configs/rockpro64_rk3399.h > +++ b/include/configs/rockpro64_rk3399.h > @@ -13,5 +13,4 @@ > > #include > > -#define SDRAM_BANK_SIZE (2UL << 30) > #endif